Skip to content

[fix](table) Move drop editlog in table lock #55705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Sep 6, 2025
Merged

[fix](table) Move drop editlog in table lock #55705

dataroaring merged 1 commit into from
Sep 6, 2025

Conversation

@deardeng
Copy link
Contributor

@deardeng deardeng commented Sep 5, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Sep 5, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@deardeng
Copy link
Contributor Author

deardeng commented Sep 5, 2025

run buildall

dataroaring
dataroaring approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Sep 5, 2025

TPC-H: Total hot run time: 34242 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f43e66f2845a690175a8430245a6c5c9ceae71ac, data reload: false

------ Round 1 ----------------------------------
q1	17632	5174	5071	5071
q2	2010	337	252	252
q3	10198	1307	739	739
q4	10234	1076	530	530
q5	7492	2478	2326	2326
q6	187	173	141	141
q7	939	754	643	643
q8	9354	1368	1165	1165
q9	7147	5138	5182	5138
q10	6962	2409	1974	1974
q11	517	316	278	278
q12	390	360	235	235
q13	17823	3704	3048	3048
q14	252	239	236	236
q15	575	528	493	493
q16	431	438	373	373
q17	621	841	387	387
q18	7641	7271	7092	7092
q19	1405	965	564	564
q20	339	346	230	230
q21	3861	3198	2341	2341
q22	1066	1057	986	986
Total cold run time: 107076 ms
Total hot run time: 34242 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5262	5126	5098	5098
q2	259	335	229	229
q3	2204	2725	2295	2295
q4	1400	1796	1345	1345
q5	4246	4569	4581	4569
q6	223	178	132	132
q7	2080	1996	1847	1847
q8	2635	2653	2731	2653
q9	7538	7307	7391	7307
q10	3148	3337	2866	2866
q11	594	532	504	504
q12	707	797	684	684
q13	3569	3978	3320	3320
q14	322	302	278	278
q15	529	495	493	493
q16	455	537	460	460
q17	1196	1815	1382	1382
q18	7846	7845	7636	7636
q19	834	865	962	865
q20	2035	2046	1949	1949
q21	5015	4632	4457	4457
q22	1080	1081	1013	1013
Total cold run time: 53177 ms
Total hot run time: 51382 ms

@doris-robot
Copy link

doris-robot commented Sep 5, 2025

TPC-DS: Total hot run time: 187027 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f43e66f2845a690175a8430245a6c5c9ceae71ac, data reload: false

query1	1088	446	409	409
query2	6567	1747	1764	1747
query3	6747	232	219	219
query4	26203	23717	23313	23313
query5	4366	643	515	515
query6	350	254	244	244
query7	4649	515	311	311
query8	313	267	268	267
query9	8664	2962	2888	2888
query10	486	380	311	311
query11	16105	15035	14790	14790
query12	182	125	120	120
query13	1675	572	429	429
query14	9695	5833	5850	5833
query15	225	193	171	171
query16	7547	676	502	502
query17	1250	742	665	665
query18	2041	436	339	339
query19	210	206	177	177
query20	142	126	123	123
query21	217	134	114	114
query22	4125	4136	4053	4053
query23	34011	33054	32960	32960
query24	8173	2368	2397	2368
query25	587	574	469	469
query26	1246	287	170	170
query27	2719	513	354	354
query28	4374	2260	2225	2225
query29	826	641	542	542
query30	299	228	209	209
query31	922	802	717	717
query32	97	90	87	87
query33	594	415	368	368
query34	803	868	538	538
query35	869	833	771	771
query36	998	1032	927	927
query37	126	113	95	95
query38	4090	3988	4063	3988
query39	1491	1445	1425	1425
query40	237	144	142	142
query41	73	68	69	68
query42	198	115	113	113
query43	537	500	478	478
query44	1335	868	867	867
query45	181	176	172	172
query46	885	1017	663	663
query47	1762	1837	1725	1725
query48	387	437	323	323
query49	746	498	404	404
query50	659	700	418	418
query51	4110	4275	4076	4076
query52	126	125	158	125
query53	251	267	201	201
query54	619	609	561	561
query55	92	98	88	88
query56	358	335	324	324
query57	1198	1214	1145	1145
query58	295	280	276	276
query59	2610	2785	2697	2697
query60	367	345	350	345
query61	170	162	156	156
query62	804	755	654	654
query63	230	194	194	194
query64	4407	1140	835	835
query65	4303	4220	4179	4179
query66	1156	428	350	350
query67	15239	15101	15001	15001
query68	9546	937	593	593
query69	493	332	304	304
query70	1248	1175	1143	1143
query71	574	342	322	322
query72	5943	5091	4988	4988
query73	776	684	359	359
query74	9070	9225	8982	8982
query75	4395	3096	2616	2616
query76	3927	1157	747	747
query77	1008	430	330	330
query78	9543	9600	8903	8903
query79	5217	836	575	575
query80	718	579	525	525
query81	468	258	231	231
query82	377	146	115	115
query83	295	269	247	247
query84	311	111	91	91
query85	938	462	422	422
query86	348	322	317	317
query87	4303	4355	4255	4255
query88	2887	2271	2236	2236
query89	457	351	294	294
query90	2100	233	222	222
query91	166	179	130	130
query92	100	78	75	75
query93	3218	983	636	636
query94	695	409	329	329
query95	413	340	328	328
query96	492	607	287	287
query97	2609	2711	2577	2577
query98	239	223	224	223
query99	1413	1401	1292	1292
Total cold run time: 282694 ms
Total hot run time: 187027 ms

@doris-robot
Copy link

doris-robot commented Sep 5, 2025

ClickBench: Total hot run time: 30 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f43e66f2845a690175a8430245a6c5c9ceae71ac, data reload: false

query1	0.06	0.05	0.05
query2	0.08	0.05	0.06
query3	0.26	0.08	0.08
query4	1.61	0.11	0.11
query5	0.46	0.42	0.42
query6	1.18	0.64	0.65
query7	0.04	0.03	0.02
query8	0.06	0.04	0.04
query9	0.60	0.54	0.54
query10	0.59	0.58	0.58
query11	0.17	0.12	0.12
query12	0.15	0.12	0.12
query13	0.62	0.64	0.61
query14	0.80	0.86	0.85
query15	0.87	0.87	0.86
query16	0.39	0.40	0.39
query17	1.08	1.07	1.05
query18	0.21	0.20	0.20
query19	1.88	1.82	1.78
query20	0.01	0.01	0.02
query21	15.40	0.92	0.57
query22	0.76	1.15	0.79
query23	14.88	1.42	0.65
query24	6.66	0.76	2.01
query25	0.52	0.20	0.07
query26	0.55	0.18	0.13
query27	0.07	0.05	0.06
query28	10.15	0.88	0.43
query29	12.67	3.91	3.26
query30	0.28	0.13	0.12
query31	2.84	0.59	0.39
query32	3.25	0.55	0.49
query33	3.00	3.13	3.14
query34	16.11	5.48	4.87
query35	4.92	4.89	4.93
query36	0.70	0.53	0.51
query37	0.10	0.07	0.08
query38	0.06	0.04	0.05
query39	0.04	0.03	0.03
query40	0.17	0.14	0.14
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 104.41 s
Total hot run time: 30 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 5, 2025

FE Regression Coverage Report

Increment line coverage 100.00% (2/2) 🎉
Increment coverage report
Complete coverage report

1 similar comment
@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 6, 2025

FE Regression Coverage Report

Increment line coverage 100.00% (2/2) 🎉
Increment coverage report
Complete coverage report

@dataroaring dataroaring merged commit b08e82e into apache:master Sep 6, 2025
27 of 29 checks passed
wenzhenghu pushed a commit to wenzhenghu/doris that referenced this pull request Sep 8, 2025
@deardeng @wenzhenghu
[fix](table) Move drop editlog in table lock (apache#55705)
761c61a
@deardeng deardeng mentioned this pull request Sep 12, 2025
Merged
deardeng added a commit to deardeng/incubator-doris that referenced this pull request Sep 12, 2025
@deardeng
[fix](table) Move drop editlog in table lock (apache#55705)
5a8ce16
@deardeng deardeng mentioned this pull request Sep 12, 2025
Merged
deardeng added a commit to deardeng/incubator-doris that referenced this pull request Sep 12, 2025
@deardeng
[fix](table) Move drop editlog in table lock (apache#55705)
25bd89e
@deardeng deardeng mentioned this pull request Sep 12, 2025
Merged
deardeng added a commit to deardeng/incubator-doris that referenced this pull request Sep 12, 2025
@deardeng
[fix](table) Move drop editlog in table lock (apache#55705)
f686886
dataroaring pushed a commit that referenced this pull request Sep 13, 2025
@deardeng
branch-3.0: [fix](table) Move drop editlog in table lock #55705 (#55946)
d0873c6 
cherry pick from #55705
morrySnow pushed a commit that referenced this pull request Sep 13, 2025
@deardeng
branch-3.1: [fix](table) Move drop editlog in table lock #55705 (#55947)
cb3ac11 
cherry pick from #55705
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Closed
yiguolei pushed a commit that referenced this pull request Sep 29, 2025
@deardeng
branch-2.1: [fix](table) Move drop editlog in table lock #55705 (#55948)
7660ddb 
cherry pick from #55705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

+1 more reviewer

@koarz koarz koarz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.12-merged dev/3.0.x-conflict dev/3.0.9-merged dev/3.1.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@deardeng @Thearas @doris-robot @hello-stephen @koarz @dataroaring @yiguolei @morrySnow