Skip to content

branch-3.1: [chore](sk) Encrypt secret key and hide access key for log #55241 #55619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Sep 5, 2025
Merged

branch-3.1: [chore](sk) Encrypt secret key and hide access key for log #55241 #55619

morrySnow merged 1 commit into from
Sep 5, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Sep 3, 2025

Cherry-picked from #55241

@github-actions github-actions bot requested a review from morrySnow as a code owner September 3, 2025 04:28
@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 3, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Sep 3, 2025
@dataroaring dataroaring reopened this Sep 3, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 3, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 3, 2025

Cloud UT Coverage Report

Increment line coverage 88.89% (80/90) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.24% (1217/1498)
Line Coverage 65.74% (21873/33274)
Region Coverage 67.29% (10986/16326)
Branch Coverage 56.98% (5805/10188)

@doris-robot
Copy link

doris-robot commented Sep 3, 2025

TPC-H: Total hot run time: 32933 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0c03bd8e0aceb032f61840eafbd3d4e7c434dffa, data reload: false

------ Round 1 ----------------------------------
q1	17575	5542	5480	5480
q2	2049	283	165	165
q3	10426	1299	734	734
q4	10206	887	457	457
q5	7673	2421	2152	2152
q6	182	170	136	136
q7	932	749	605	605
q8	9344	1469	1236	1236
q9	5274	4989	4956	4956
q10	6774	2288	1833	1833
q11	512	284	266	266
q12	334	352	208	208
q13	17768	3632	3044	3044
q14	232	218	220	218
q15	537	467	464	464
q16	410	419	377	377
q17	603	873	366	366
q18	7137	6446	6490	6446
q19	1221	978	554	554
q20	338	344	214	214
q21	2846	2208	2030	2030
q22	1088	1011	992	992
Total cold run time: 103461 ms
Total hot run time: 32933 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5553	5546	5522	5522
q2	240	328	230	230
q3	2199	2636	2283	2283
q4	1362	1785	1357	1357
q5	4419	4869	5169	4869
q6	167	162	129	129
q7	2093	1951	1812	1812
q8	2660	2870	2720	2720
q9	7244	7203	7199	7199
q10	2970	3312	2771	2771
q11	593	523	500	500
q12	649	788	618	618
q13	3404	3793	3138	3138
q14	281	315	281	281
q15	528	471	470	470
q16	447	483	446	446
q17	1259	1765	1283	1283
q18	7662	7556	7407	7407
q19	805	1027	1152	1027
q20	2010	2029	1867	1867
q21	5705	4887	4614	4614
q22	1089	1095	1066	1066
Total cold run time: 53339 ms
Total hot run time: 51609 ms

@doris-robot
Copy link

doris-robot commented Sep 3, 2025

TPC-DS: Total hot run time: 191438 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0c03bd8e0aceb032f61840eafbd3d4e7c434dffa, data reload: false

query1	978	386	375	375
query2	6531	2011	1921	1921
query3	6710	216	227	216
query4	33961	23816	23865	23816
query5	4417	650	461	461
query6	281	184	190	184
query7	4618	480	308	308
query8	279	244	224	224
query9	9583	2609	2616	2609
query10	471	336	263	263
query11	18058	15442	15164	15164
query12	156	113	104	104
query13	1644	544	427	427
query14	9356	7028	7019	7019
query15	230	188	188	188
query16	8177	687	506	506
query17	1638	784	570	570
query18	2130	410	343	343
query19	214	177	163	163
query20	123	119	116	116
query21	204	127	110	110
query22	4696	4590	4461	4461
query23	35316	33802	33484	33484
query24	7523	2597	2632	2597
query25	515	482	422	422
query26	1214	291	178	178
query27	2037	465	334	334
query28	5109	2163	2139	2139
query29	747	556	425	425
query30	242	184	156	156
query31	973	889	816	816
query32	94	63	54	54
query33	516	353	303	303
query34	730	830	510	510
query35	769	776	706	706
query36	984	1050	946	946
query37	98	100	68	68
query38	3897	3852	3865	3852
query39	1475	1448	1622	1448
query40	201	112	100	100
query41	48	51	49	49
query42	118	109	103	103
query43	499	502	453	453
query44	1301	799	799	799
query45	180	173	166	166
query46	860	1028	680	680
query47	1895	1914	1858	1858
query48	428	426	376	376
query49	780	477	397	397
query50	676	679	419	419
query51	7250	7208	7171	7171
query52	101	97	94	94
query53	234	253	179	179
query54	528	536	463	463
query55	80	81	79	79
query56	265	276	267	267
query57	1229	1198	1198	1198
query58	257	223	229	223
query59	3039	3138	2862	2862
query60	297	303	283	283
query61	165	143	133	133
query62	796	728	642	642
query63	228	192	189	189
query64	4686	1065	735	735
query65	3288	3180	3194	3180
query66	1076	424	319	319
query67	16084	15670	15687	15670
query68	4577	846	560	560
query69	473	316	282	282
query70	1156	1128	1106	1106
query71	490	304	267	267
query72	5812	3860	3764	3764
query73	637	745	365	365
query74	10173	9298	9049	9049
query75	3172	3148	2703	2703
query76	3166	1176	761	761
query77	467	354	283	283
query78	10512	10468	9688	9688
query79	2867	884	597	597
query80	1504	523	445	445
query81	549	256	218	218
query82	584	117	90	90
query83	167	161	147	147
query84	245	112	87	87
query85	813	357	310	310
query86	443	322	304	304
query87	4272	4309	4253	4253
query88	5332	2408	2397	2397
query89	396	331	290	290
query90	1873	187	190	187
query91	142	156	106	106
query92	66	59	55	55
query93	2752	900	538	538
query94	726	408	306	306
query95	341	270	266	266
query96	498	613	295	295
query97	3195	3309	3157	3157
query98	233	211	196	196
query99	1326	1428	1293	1293
Total cold run time: 292242 ms
Total hot run time: 191438 ms

@doris-robot
Copy link

doris-robot commented Sep 3, 2025

ClickBench: Total hot run time: 29.02 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0c03bd8e0aceb032f61840eafbd3d4e7c434dffa, data reload: false

query1	0.03	0.03	0.04
query2	0.07	0.03	0.03
query3	0.23	0.07	0.06
query4	1.63	0.10	0.11
query5	0.53	0.52	0.52
query6	1.12	0.72	0.73
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.56	0.52	0.51
query10	0.57	0.56	0.55
query11	0.15	0.10	0.11
query12	0.14	0.11	0.11
query13	0.61	0.62	0.61
query14	0.76	0.80	0.78
query15	0.85	0.84	0.82
query16	0.42	0.40	0.42
query17	1.05	1.02	1.01
query18	0.23	0.22	0.22
query19	1.84	1.81	1.86
query20	0.01	0.01	0.01
query21	15.40	0.93	0.58
query22	0.74	0.81	0.67
query23	15.10	1.47	0.60
query24	3.27	0.98	1.27
query25	0.17	0.08	0.08
query26	0.29	0.15	0.13
query27	0.04	0.04	0.04
query28	13.68	1.00	0.43
query29	12.57	3.83	3.20
query30	0.24	0.08	0.06
query31	2.83	0.58	0.38
query32	3.22	0.53	0.45
query33	3.02	3.04	3.02
query34	16.53	5.24	4.62
query35	4.67	4.57	4.56
query36	0.65	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.03	0.02
query40	0.16	0.13	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.77 s
Total hot run time: 29.02 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 3, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/34) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 3, 2025

BE UT Coverage Report

Increment line coverage 75.76% (25/33) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.49% (12726/27974)
Line Coverage 36.39% (113515/311961)
Region Coverage 34.02% (64979/191030)
Branch Coverage 31.06% (34112/109828)

@morrySnow
Copy link
Contributor

morrySnow commented Sep 4, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 4, 2025

Cloud UT Coverage Report

Increment line coverage 88.89% (80/90) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 82.06% (1221/1488)
Line Coverage 65.95% (21871/33163)
Region Coverage 67.44% (10997/16307)
Branch Coverage 57.06% (5809/10180)

@doris-robot
Copy link

doris-robot commented Sep 4, 2025

TPC-H: Total hot run time: 32910 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0c03bd8e0aceb032f61840eafbd3d4e7c434dffa, data reload: false

------ Round 1 ----------------------------------
q1	17707	5479	5549	5479
q2	2032	413	288	288
q3	12162	1256	749	749
q4	10244	885	466	466
q5	8647	2416	2165	2165
q6	187	165	136	136
q7	910	757	618	618
q8	9343	1463	1167	1167
q9	5364	5070	4942	4942
q10	6814	2278	1814	1814
q11	501	273	266	266
q12	340	353	217	217
q13	17787	3742	3020	3020
q14	233	229	215	215
q15	533	475	467	467
q16	440	436	378	378
q17	594	866	369	369
q18	7169	6529	6444	6444
q19	1974	955	556	556
q20	339	354	202	202
q21	2785	2133	1943	1943
q22	1100	1046	1009	1009
Total cold run time: 107205 ms
Total hot run time: 32910 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5622	5519	5527	5519
q2	238	327	240	240
q3	2275	2611	2345	2345
q4	1349	1780	1405	1405
q5	4426	5090	5008	5008
q6	178	168	127	127
q7	2106	1950	1805	1805
q8	2629	2845	2703	2703
q9	7439	7295	7282	7282
q10	3058	3211	2789	2789
q11	603	503	502	502
q12	674	787	610	610
q13	3553	3879	3130	3130
q14	279	295	264	264
q15	529	475	471	471
q16	445	489	458	458
q17	1263	1766	1295	1295
q18	7638	7567	7285	7285
q19	819	1210	1069	1069
q20	2055	2096	1967	1967
q21	5314	4927	4614	4614
q22	1128	1077	1009	1009
Total cold run time: 53620 ms
Total hot run time: 51897 ms

@doris-robot
Copy link

doris-robot commented Sep 4, 2025

TPC-DS: Total hot run time: 193949 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0c03bd8e0aceb032f61840eafbd3d4e7c434dffa, data reload: false

query1	948	413	412	412
query2	6188	2062	1995	1995
query3	8724	210	205	205
query4	33340	23839	23772	23772
query5	3855	624	482	482
query6	285	185	172	172
query7	4220	497	321	321
query8	304	242	234	234
query9	9144	2598	2573	2573
query10	469	343	262	262
query11	18082	15585	15540	15540
query12	161	109	108	108
query13	1560	553	422	422
query14	9928	6795	6661	6661
query15	219	199	175	175
query16	8016	676	547	547
query17	1536	761	609	609
query18	2100	425	338	338
query19	227	194	177	177
query20	129	128	129	128
query21	210	129	115	115
query22	4547	4594	4417	4417
query23	35109	33916	34832	33916
query24	7234	2692	2742	2692
query25	521	500	447	447
query26	926	296	171	171
query27	2244	464	377	377
query28	5337	2242	2203	2203
query29	712	619	472	472
query30	262	203	171	171
query31	1008	936	883	883
query32	90	64	62	62
query33	516	380	322	322
query34	756	901	532	532
query35	830	833	735	735
query36	1028	1086	986	986
query37	109	92	67	67
query38	4044	4041	4045	4041
query39	1557	1504	1477	1477
query40	227	138	110	110
query41	59	50	49	49
query42	124	107	109	107
query43	547	543	521	521
query44	1378	861	878	861
query45	185	180	175	175
query46	908	1085	689	689
query47	2011	1973	1926	1926
query48	433	434	355	355
query49	744	497	407	407
query50	678	713	442	442
query51	7462	7395	7335	7335
query52	109	105	97	97
query53	233	270	199	199
query54	559	554	491	491
query55	81	85	87	85
query56	273	294	261	261
query57	1299	1294	1235	1235
query58	239	225	223	223
query59	3175	3374	3197	3197
query60	289	270	279	270
query61	112	113	117	113
query62	791	775	731	731
query63	246	197	196	196
query64	3653	1020	673	673
query65	3513	3319	3306	3306
query66	943	423	319	319
query67	16292	15694	15651	15651
query68	7612	836	557	557
query69	507	311	267	267
query70	1218	1162	1160	1160
query71	396	293	264	264
query72	5830	3916	3901	3901
query73	642	744	355	355
query74	10326	9193	9193	9193
query75	3301	3188	2682	2682
query76	3175	1173	752	752
query77	723	370	292	292
query78	10466	10444	9694	9694
query79	3559	888	601	601
query80	632	530	435	435
query81	508	260	224	224
query82	576	119	88	88
query83	172	166	148	148
query84	287	95	82	82
query85	769	356	298	298
query86	363	324	316	316
query87	4318	4357	4253	4253
query88	4982	2423	2415	2415
query89	415	336	300	300
query90	1793	190	190	190
query91	131	140	112	112
query92	65	55	53	53
query93	2022	894	542	542
query94	683	424	320	320
query95	345	289	266	266
query96	496	609	283	283
query97	3233	3318	3172	3172
query98	229	224	194	194
query99	1561	1404	1297	1297
Total cold run time: 294373 ms
Total hot run time: 193949 ms

@doris-robot
Copy link

doris-robot commented Sep 4, 2025

ClickBench: Total hot run time: 28.82 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0c03bd8e0aceb032f61840eafbd3d4e7c434dffa, data reload: false

query1	0.03	0.03	0.04
query2	0.06	0.03	0.03
query3	0.23	0.07	0.06
query4	1.62	0.10	0.10
query5	0.54	0.52	0.52
query6	1.13	0.73	0.73
query7	0.03	0.01	0.01
query8	0.04	0.03	0.03
query9	0.61	0.50	0.52
query10	0.55	0.55	0.57
query11	0.14	0.10	0.11
query12	0.14	0.10	0.11
query13	0.62	0.61	0.59
query14	0.77	0.82	0.79
query15	0.85	0.85	0.83
query16	0.39	0.40	0.37
query17	1.01	1.04	1.05
query18	0.25	0.22	0.22
query19	1.85	1.77	1.89
query20	0.02	0.01	0.01
query21	15.42	1.00	0.57
query22	0.72	0.72	0.63
query23	15.19	1.52	0.54
query24	3.08	0.92	1.98
query25	0.18	0.19	0.06
query26	0.25	0.18	0.14
query27	0.06	0.06	0.05
query28	14.10	1.05	0.46
query29	12.59	3.96	3.24
query30	0.25	0.09	0.06
query31	2.82	0.60	0.39
query32	3.23	0.54	0.47
query33	3.03	3.02	3.03
query34	16.68	5.20	4.56
query35	4.64	4.56	4.56
query36	0.64	0.50	0.48
query37	0.09	0.06	0.06
query38	0.04	0.03	0.03
query39	0.04	0.03	0.02
query40	0.18	0.13	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 104.26 s
Total hot run time: 28.82 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 4, 2025

BE UT Coverage Report

Increment line coverage 75.76% (25/33) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.52% (12744/27997)
Line Coverage 36.38% (113646/312419)
Region Coverage 34.02% (65037/191193)
Branch Coverage 31.04% (34126/109930)

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 4, 2025

BE Regression && UT Coverage Report

Increment line coverage 87.88% (29/33) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.26% (20991/27526)
Line Coverage 69.49% (216370/311370)
Region Coverage 67.41% (129376/191932)
Branch Coverage 61.01% (67374/110426)

2 similar comments
@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 4, 2025

BE Regression && UT Coverage Report

Increment line coverage 87.88% (29/33) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.26% (20991/27526)
Line Coverage 69.49% (216370/311370)
Region Coverage 67.41% (129376/191932)
Branch Coverage 61.01% (67374/110426)

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 5, 2025

BE Regression && UT Coverage Report

Increment line coverage 87.88% (29/33) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.26% (20991/27526)
Line Coverage 69.49% (216370/311370)
Region Coverage 67.41% (129376/191932)
Branch Coverage 61.01% (67374/110426)

@morrySnow morrySnow merged commit 07d2425 into branch-3.1 Sep 5, 2025
22 of 23 checks passed
@morrySnow morrySnow deleted the auto-pick-55241-branch-3.1 branch September 5, 2025 16:36
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hello-stephen @doris-robot @morrySnow @dataroaring @wyxxxcat