Skip to content

branch-3.1: [opt](mow) do not capture stack to reduce cpu #55368 #55526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Sep 4, 2025
Merged

branch-3.1: [opt](mow) do not capture stack to reduce cpu #55368 #55526

morrySnow merged 1 commit into from
Sep 4, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Sep 1, 2025

Cherry-picked from #55368

@github-actions github-actions bot requested a review from morrySnow as a code owner September 1, 2025 07:15
@Thearas
Copy link
Contributor

Thearas commented Sep 1, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Sep 1, 2025
@dataroaring dataroaring reopened this Sep 1, 2025
@Thearas
Copy link
Contributor

Thearas commented Sep 1, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 1, 2025

TPC-H: Total hot run time: 32849 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 01cb42172663263c52b7d07657b00e6a30753bdd, data reload: false

------ Round 1 ----------------------------------
q1	17604	5627	5413	5413
q2	2054	301	157	157
q3	10418	1318	749	749
q4	10212	876	455	455
q5	7663	2393	2117	2117
q6	184	162	130	130
q7	902	744	596	596
q8	9336	1434	1244	1244
q9	5392	4970	5021	4970
q10	6782	2274	1844	1844
q11	487	293	264	264
q12	342	359	211	211
q13	17774	3609	3054	3054
q14	224	228	207	207
q15	532	459	464	459
q16	416	428	386	386
q17	598	869	370	370
q18	6955	6516	6396	6396
q19	1212	957	585	585
q20	340	351	204	204
q21	3126	2205	2054	2054
q22	1038	995	984	984
Total cold run time: 103591 ms
Total hot run time: 32849 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5580	5566	5627	5566
q2	238	339	233	233
q3	2249	2639	2291	2291
q4	1370	1784	1312	1312
q5	4424	4880	5087	4880
q6	171	160	130	130
q7	2179	2010	1784	1784
q8	2653	2806	2698	2698
q9	7220	7124	7185	7124
q10	3044	3266	2765	2765
q11	581	518	492	492
q12	676	753	634	634
q13	3417	3810	3158	3158
q14	281	304	278	278
q15	525	461	478	461
q16	441	496	444	444
q17	1273	1760	1257	1257
q18	7713	7387	7206	7206
q19	809	1227	1117	1117
q20	2002	2026	1912	1912
q21	5426	4902	4640	4640
q22	1115	1109	1037	1037
Total cold run time: 53387 ms
Total hot run time: 51419 ms

@doris-robot
Copy link

doris-robot commented Sep 1, 2025

TPC-DS: Total hot run time: 191370 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 01cb42172663263c52b7d07657b00e6a30753bdd, data reload: false

query1	976	393	366	366
query2	6528	2032	1955	1955
query3	6698	212	222	212
query4	33756	23571	23508	23508
query5	4314	628	466	466
query6	278	190	180	180
query7	4610	500	322	322
query8	285	240	236	236
query9	9617	2624	2615	2615
query10	488	343	251	251
query11	18322	15469	15252	15252
query12	160	106	108	106
query13	1650	587	439	439
query14	9298	7235	6686	6686
query15	216	197	187	187
query16	8103	671	505	505
query17	1641	744	598	598
query18	2087	431	340	340
query19	233	187	177	177
query20	128	120	119	119
query21	210	139	111	111
query22	4550	4687	4436	4436
query23	35509	33617	33590	33590
query24	7313	2642	2581	2581
query25	462	468	415	415
query26	1082	252	172	172
query27	2382	464	347	347
query28	5292	2200	2144	2144
query29	580	557	463	463
query30	261	187	161	161
query31	996	889	827	827
query32	68	65	56	56
query33	521	374	326	326
query34	738	823	515	515
query35	772	798	714	714
query36	984	1023	958	958
query37	109	104	79	79
query38	3954	3912	3852	3852
query39	1498	1418	1409	1409
query40	215	118	108	108
query41	59	62	52	52
query42	122	105	106	105
query43	514	514	497	497
query44	1308	817	809	809
query45	187	179	171	171
query46	874	1042	667	667
query47	1876	1968	1881	1881
query48	436	419	361	361
query49	812	548	390	390
query50	670	684	425	425
query51	7239	7185	7096	7096
query52	99	97	96	96
query53	232	250	183	183
query54	536	529	474	474
query55	85	82	84	82
query56	278	265	249	249
query57	1208	1210	1154	1154
query58	248	216	216	216
query59	3008	3059	2959	2959
query60	290	284	274	274
query61	117	113	114	113
query62	806	721	703	703
query63	222	191	187	187
query64	3977	992	647	647
query65	3273	3202	3218	3202
query66	1052	420	302	302
query67	16067	15752	15732	15732
query68	6467	826	554	554
query69	479	309	266	266
query70	1211	1083	1064	1064
query71	497	301	257	257
query72	5603	3759	3957	3759
query73	643	743	364	364
query74	10143	9479	9298	9298
query75	3139	3176	2655	2655
query76	3175	1136	767	767
query77	474	373	295	295
query78	10341	10454	9710	9710
query79	3423	886	592	592
query80	748	526	442	442
query81	497	256	221	221
query82	640	119	88	88
query83	165	165	146	146
query84	251	101	87	87
query85	776	386	304	304
query86	386	317	305	305
query87	4308	4335	4281	4281
query88	5281	2438	2367	2367
query89	398	342	295	295
query90	1843	183	182	182
query91	133	143	108	108
query92	65	56	58	56
query93	2335	917	544	544
query94	695	414	296	296
query95	334	277	265	265
query96	496	610	290	290
query97	3243	3277	3219	3219
query98	221	210	196	196
query99	1676	1391	1286	1286
Total cold run time: 292565 ms
Total hot run time: 191370 ms

@doris-robot
Copy link

doris-robot commented Sep 1, 2025

ClickBench: Total hot run time: 29.2 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 01cb42172663263c52b7d07657b00e6a30753bdd, data reload: false

query1	0.04	0.03	0.02
query2	0.07	0.03	0.02
query3	0.24	0.07	0.07
query4	1.64	0.11	0.10
query5	0.53	0.50	0.52
query6	1.13	0.75	0.74
query7	0.03	0.01	0.02
query8	0.05	0.03	0.03
query9	0.58	0.51	0.51
query10	0.56	0.56	0.58
query11	0.15	0.10	0.10
query12	0.13	0.11	0.11
query13	0.61	0.62	0.61
query14	0.80	0.78	0.78
query15	0.85	0.84	0.84
query16	0.40	0.39	0.41
query17	1.01	0.99	1.01
query18	0.23	0.22	0.23
query19	1.92	1.78	1.83
query20	0.01	0.01	0.01
query21	15.42	0.89	0.60
query22	0.74	0.91	0.65
query23	15.03	1.50	0.54
query24	3.26	1.17	1.66
query25	0.15	0.13	0.08
query26	0.25	0.14	0.14
query27	0.05	0.05	0.05
query28	13.83	0.99	0.45
query29	12.56	3.93	3.28
query30	0.25	0.09	0.07
query31	2.86	0.62	0.39
query32	3.21	0.56	0.46
query33	3.05	3.02	3.04
query34	16.50	5.24	4.59
query35	4.55	4.58	4.53
query36	0.64	0.51	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.16	0.13	0.13
query41	0.08	0.02	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 103.82 s
Total hot run time: 29.2 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 1, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.49% (12725/27973)
Line Coverage 36.38% (113483/311931)
Region Coverage 34.00% (64945/191010)
Branch Coverage 31.05% (34102/109814)

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 2, 2025

BE Regression && UT Coverage Report

Increment line coverage 50.00% (2/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.49% (21038/27503)
Line Coverage 69.90% (217309/310880)
Region Coverage 67.84% (130088/191748)
Branch Coverage 61.42% (67755/110308)

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 4, 2025

BE Regression && UT Coverage Report

Increment line coverage 50.00% (2/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.48% (21035/27503)
Line Coverage 69.88% (217243/310880)
Region Coverage 67.82% (130047/191748)
Branch Coverage 61.41% (67736/110308)

@morrySnow morrySnow merged commit 7007e12 into branch-3.1 Sep 4, 2025
21 of 23 checks passed
@github-actions github-actions bot deleted the auto-pick-55368-branch-3.1 branch September 4, 2025 06:35
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Thearas @doris-robot @hello-stephen @morrySnow @dataroaring