Skip to content

[opt](mow) do not capture stack to reduce cpu #55368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 2 commits into from
Aug 29, 2025
Merged

[opt](mow) do not capture stack to reduce cpu #55368

dataroaring merged 2 commits into from
Aug 29, 2025

Conversation

@dataroaring
Copy link
Contributor

@dataroaring dataroaring commented Aug 27, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 27, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring
Copy link
Contributor Author

dataroaring commented Aug 27, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Aug 27, 2025

TPC-H: Total hot run time: 34159 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f3507183f6840718cf6110c2fd12e63d42b1d646, data reload: false

------ Round 1 ----------------------------------
q1	17590	5208	5075	5075
q2	1998	341	222	222
q3	10225	1282	745	745
q4	10236	1015	520	520
q5	7524	2394	2350	2350
q6	183	176	141	141
q7	926	748	625	625
q8	9361	1316	1067	1067
q9	6940	5231	5126	5126
q10	6891	2373	1976	1976
q11	478	313	284	284
q12	344	351	238	238
q13	17783	3636	3003	3003
q14	235	238	232	232
q15	554	509	496	496
q16	437	426	376	376
q17	591	851	375	375
q18	7733	7145	7168	7145
q19	1090	969	560	560
q20	351	359	231	231
q21	3753	3181	2358	2358
q22	1095	1027	1014	1014
Total cold run time: 106318 ms
Total hot run time: 34159 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5160	5132	5125	5125
q2	255	331	224	224
q3	2207	2675	2356	2356
q4	1381	1789	1347	1347
q5	4192	4373	4595	4373
q6	227	171	140	140
q7	2061	1954	1777	1777
q8	2651	2607	2629	2607
q9	7542	7353	7222	7222
q10	3077	3278	2878	2878
q11	582	505	523	505
q12	720	834	680	680
q13	3685	3908	3354	3354
q14	296	324	282	282
q15	537	482	489	482
q16	472	526	447	447
q17	1227	1575	1396	1396
q18	7957	7563	7766	7563
q19	866	833	888	833
q20	2005	2109	1845	1845
q21	5051	4579	4345	4345
q22	1081	1072	1046	1046
Total cold run time: 53232 ms
Total hot run time: 50827 ms

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Aug 27, 2025

TPC-DS: Total hot run time: 187679 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f3507183f6840718cf6110c2fd12e63d42b1d646, data reload: false

query1	1103	436	391	391
query2	6555	1786	1792	1786
query3	6756	234	231	231
query4	26363	23315	23416	23315
query5	4961	680	531	531
query6	339	250	223	223
query7	4640	524	304	304
query8	294	267	258	258
query9	8634	2938	2938	2938
query10	524	363	290	290
query11	15996	15343	14714	14714
query12	184	122	118	118
query13	1673	580	435	435
query14	9921	5953	6045	5953
query15	222	198	179	179
query16	7693	697	477	477
query17	1209	772	659	659
query18	2063	452	354	354
query19	218	204	197	197
query20	141	128	125	125
query21	228	137	120	120
query22	3979	4190	4031	4031
query23	34066	32952	33024	32952
query24	8055	2425	2428	2425
query25	580	571	461	461
query26	1249	300	169	169
query27	2701	522	361	361
query28	4352	2291	2261	2261
query29	786	604	493	493
query30	292	228	205	205
query31	922	806	741	741
query32	90	84	81	81
query33	591	402	363	363
query34	827	851	530	530
query35	841	849	752	752
query36	995	1045	936	936
query37	136	118	96	96
query38	4129	4143	3976	3976
query39	1495	1444	1431	1431
query40	227	133	133	133
query41	71	67	74	67
query42	127	121	119	119
query43	540	495	486	486
query44	1418	890	877	877
query45	184	180	179	179
query46	871	1019	666	666
query47	1785	1841	1708	1708
query48	408	450	337	337
query49	755	520	421	421
query50	681	683	413	413
query51	4110	4145	4126	4126
query52	117	113	108	108
query53	248	284	207	207
query54	637	623	552	552
query55	95	91	94	91
query56	358	342	331	331
query57	1192	1213	1153	1153
query58	298	290	285	285
query59	2676	2755	2633	2633
query60	372	363	354	354
query61	162	166	166	166
query62	797	728	664	664
query63	241	205	200	200
query64	4501	1159	936	936
query65	4346	4224	4268	4224
query66	1115	458	371	371
query67	15511	15265	15265	15265
query68	8240	956	664	664
query69	495	350	302	302
query70	1223	1195	1166	1166
query71	521	365	331	331
query72	5573	5005	4893	4893
query73	691	603	367	367
query74	9088	9152	8902	8902
query75	3888	3114	2707	2707
query76	3770	1143	760	760
query77	823	434	340	340
query78	9585	9777	8875	8875
query79	2444	857	593	593
query80	669	590	511	511
query81	502	263	225	225
query82	457	141	114	114
query83	264	256	290	256
query84	259	110	87	87
query85	904	472	437	437
query86	397	335	327	327
query87	4280	4224	4210	4210
query88	3820	2251	2224	2224
query89	420	336	290	290
query90	1894	231	221	221
query91	161	163	135	135
query92	90	74	74	74
query93	1858	995	649	649
query94	701	427	328	328
query95	426	341	331	331
query96	507	584	280	280
query97	2635	2693	2606	2606
query98	265	225	219	219
query99	1376	1429	1321	1321
Total cold run time: 277872 ms
Total hot run time: 187679 ms

@doris-robot
Copy link

doris-robot commented Aug 27, 2025

ClickBench: Total hot run time: 33.12 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f3507183f6840718cf6110c2fd12e63d42b1d646, data reload: false

query1	0.06	0.05	0.05
query2	0.08	0.06	0.05
query3	0.26	0.08	0.08
query4	1.60	0.12	0.12
query5	0.45	0.42	0.41
query6	1.18	0.65	0.66
query7	0.03	0.02	0.02
query8	0.06	0.04	0.04
query9	0.61	0.54	0.53
query10	0.57	0.58	0.59
query11	0.18	0.11	0.12
query12	0.15	0.12	0.13
query13	0.63	0.64	0.63
query14	0.80	0.87	0.85
query15	0.87	0.85	0.86
query16	0.39	0.42	0.39
query17	1.07	1.06	1.03
query18	0.22	0.20	0.20
query19	2.01	1.86	1.82
query20	0.01	0.01	0.01
query21	15.44	0.99	0.58
query22	0.78	1.34	0.73
query23	14.79	1.37	0.66
query24	6.93	1.81	0.96
query25	0.48	0.29	0.10
query26	0.56	0.16	0.15
query27	0.07	0.06	0.06
query28	10.10	0.91	0.43
query29	12.58	3.92	3.23
query30	3.08	3.04	3.07
query31	2.83	0.58	0.38
query32	3.23	0.54	0.50
query33	3.04	3.11	3.13
query34	16.11	5.47	4.86
query35	4.90	4.91	4.95
query36	0.70	0.52	0.51
query37	0.10	0.07	0.08
query38	0.06	0.05	0.04
query39	0.04	0.03	0.03
query40	0.19	0.15	0.15
query41	0.09	0.03	0.02
query42	0.04	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 107.41 s
Total hot run time: 33.12 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 27, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 51.78% (17148/33115)
Line Coverage 37.26% (156253/419368)
Region Coverage 31.94% (119073/372788)
Branch Coverage 33.24% (52342/157464)

@dataroaring dataroaring merged commit 2d16c54 into apache:master Aug 29, 2025
26 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 1, 2025
@dataroaring
[opt](mow) do not capture stack to reduce cpu (#55368)
01cb421
@github-actions github-actions bot mentioned this pull request Sep 1, 2025
Merged
morrySnow pushed a commit that referenced this pull request Sep 4, 2025
@github-actions @dataroaring
branch-3.1: [opt](mow) do not capture stack to reduce cpu #55368 (#55526
7007e12 
)

Cherry-picked from #55368

Co-authored-by: Yongqiang YANG <[email protected]>
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mymeiyi mymeiyi mymeiyi approved these changes

+1 more reviewer

@bobhan1 bobhan1 bobhan1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dataroaring @hello-stephen @doris-robot @mymeiyi @bobhan1 @morrySnow