[fix](virtual column) should not push down WhenClause in case when by morrySnow · Pull Request #54998 · apache/doris

morrySnow · 2025-08-19T08:18:16Z

What problem does this PR solve?

Related PR: #52701

Problem Summary:

do not push down WhenClause in case when
not generate virtual column which only used once: fix the pattern like select func_a(x), func_b(func_a(x)), func_c(func_b(func_a(x))).

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2025-08-19T08:18:21Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

morrySnow · 2025-08-19T08:18:24Z

run buildall

doris-robot · 2025-08-19T08:41:51Z

TPC-H: Total hot run time: 33770 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 053f0c5b24b110262048e00383df6debf4f5e316, data reload: false

------ Round 1 ----------------------------------
q1	17599	5238	5090	5090
q2	1919	284	178	178
q3	10324	1308	742	742
q4	10233	1013	502	502
q5	7533	2427	2294	2294
q6	178	160	132	132
q7	904	733	592	592
q8	9299	1294	1088	1088
q9	7157	5044	5031	5031
q10	6875	2383	1987	1987
q11	472	287	280	280
q12	346	348	219	219
q13	17755	3680	2977	2977
q14	234	236	218	218
q15	532	483	477	477
q16	411	434	370	370
q17	591	838	372	372
q18	7470	7093	7078	7078
q19	1096	946	568	568
q20	361	349	222	222
q21	3730	3207	2380	2380
q22	1049	1051	973	973
Total cold run time: 106068 ms
Total hot run time: 33770 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5184	5108	5104	5104
q2	257	328	223	223
q3	2177	2698	2284	2284
q4	1339	1766	1364	1364
q5	4194	4557	4444	4444
q6	225	171	125	125
q7	2054	1991	1803	1803
q8	2688	2610	2514	2514
q9	7403	7295	7302	7295
q10	3146	3294	2827	2827
q11	608	532	510	510
q12	683	917	616	616
q13	3613	3900	3263	3263
q14	282	304	280	280
q15	512	484	486	484
q16	441	491	469	469
q17	1185	1524	1424	1424
q18	8028	7932	7444	7444
q19	884	842	834	834
q20	1965	1949	1845	1845
q21	4691	4467	4354	4354
q22	1058	1018	998	998
Total cold run time: 52617 ms
Total hot run time: 50504 ms

doris-robot · 2025-08-19T08:53:28Z

TPC-DS: Total hot run time: 185087 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 053f0c5b24b110262048e00383df6debf4f5e316, data reload: false

query1	996	380	405	380
query2	6524	1788	1758	1758
query3	6747	223	226	223
query4	26352	23076	23095	23076
query5	4303	625	506	506
query6	324	214	215	214
query7	4624	499	296	296
query8	273	230	230	230
query9	8579	2875	2886	2875
query10	474	347	276	276
query11	15852	15019	14717	14717
query12	158	111	113	111
query13	1655	552	417	417
query14	9302	5709	5790	5709
query15	202	189	162	162
query16	7580	662	497	497
query17	1201	741	607	607
query18	2061	400	304	304
query19	186	184	154	154
query20	125	116	113	113
query21	209	156	112	112
query22	4373	4111	3984	3984
query23	34071	33349	33104	33104
query24	8059	2383	2379	2379
query25	549	478	425	425
query26	1239	269	156	156
query27	2743	502	339	339
query28	4369	2242	2222	2222
query29	727	563	463	463
query30	287	221	187	187
query31	909	777	707	707
query32	80	73	75	73
query33	566	355	345	345
query34	786	854	530	530
query35	812	848	726	726
query36	982	1035	906	906
query37	124	106	89	89
query38	4083	4055	4050	4050
query39	1460	1411	1423	1411
query40	220	123	119	119
query41	59	55	52	52
query42	118	107	110	107
query43	480	500	465	465
query44	1325	842	832	832
query45	180	170	167	167
query46	844	997	638	638
query47	1780	1852	1745	1745
query48	384	417	303	303
query49	720	488	394	394
query50	636	694	403	403
query51	4084	4113	4133	4113
query52	112	105	103	103
query53	238	253	202	202
query54	593	584	512	512
query55	89	93	90	90
query56	317	301	299	299
query57	1205	1196	1128	1128
query58	282	255	270	255
query59	2725	2759	2766	2759
query60	358	324	307	307
query61	128	125	122	122
query62	811	733	658	658
query63	230	184	187	184
query64	4273	998	756	756
query65	4300	4234	4209	4209
query66	1097	414	318	318
query67	15460	15178	15051	15051
query68	8345	907	611	611
query69	481	327	279	279
query70	1259	1116	1146	1116
query71	448	324	310	310
query72	5604	4699	4774	4699
query73	756	618	358	358
query74	8966	9146	9090	9090
query75	3853	3088	2624	2624
query76	3696	1125	729	729
query77	790	402	314	314
query78	9575	9703	8828	8828
query79	4891	806	591	591
query80	682	529	539	529
query81	484	257	220	220
query82	442	134	111	111
query83	297	257	237	237
query84	293	108	85	85
query85	783	369	339	339
query86	360	315	293	293
query87	4244	4271	4135	4135
query88	2870	2205	2229	2205
query89	434	321	275	275
query90	2068	222	220	220
query91	141	146	108	108
query92	79	68	64	64
query93	2846	982	632	632
query94	669	381	314	314
query95	398	324	309	309
query96	482	588	277	277
query97	2620	2735	2588	2588
query98	249	220	208	208
query99	1466	1384	1265	1265
Total cold run time: 277565 ms
Total hot run time: 185087 ms

doris-robot · 2025-08-19T08:58:54Z

ClickBench: Total hot run time: 32.05 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 053f0c5b24b110262048e00383df6debf4f5e316, data reload: false

query1	0.04	0.04	0.03
query2	0.09	0.04	0.04
query3	0.24	0.07	0.07
query4	1.63	0.12	0.11
query5	0.42	0.42	0.41
query6	1.17	0.65	0.64
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.62	0.52	0.52
query10	0.57	0.57	0.57
query11	0.16	0.11	0.11
query12	0.14	0.11	0.12
query13	0.62	0.61	0.60
query14	0.80	0.85	0.82
query15	0.87	0.85	0.87
query16	0.39	0.40	0.39
query17	1.06	0.99	1.04
query18	0.20	0.19	0.20
query19	1.94	1.81	1.82
query20	0.02	0.01	0.01
query21	15.39	0.92	0.57
query22	0.80	1.18	0.84
query23	14.79	1.35	0.64
query24	6.59	0.74	0.26
query25	0.34	0.17	0.09
query26	0.67	0.17	0.12
query27	0.05	0.05	0.05
query28	9.44	0.99	0.42
query29	12.67	3.86	3.25
query30	3.10	3.06	3.03
query31	2.81	0.58	0.37
query32	3.24	0.55	0.46
query33	3.04	3.05	3.07
query34	16.09	5.44	4.87
query35	4.88	4.88	4.92
query36	0.68	0.50	0.49
query37	0.10	0.07	0.07
query38	0.05	0.05	0.03
query39	0.03	0.02	0.02
query40	0.18	0.14	0.13
query41	0.09	0.03	0.02
query42	0.03	0.03	0.02
query43	0.04	0.04	0.04
Total cold run time: 106.14 s
Total hot run time: 32.05 s

morrySnow · 2025-08-21T03:45:35Z

run buildall

doris-robot · 2025-08-21T04:13:59Z

TPC-H: Total hot run time: 33813 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ebeac497d2612e446545acf4a00257d3ce2c9ab2, data reload: false

------ Round 1 ----------------------------------
q1	17623	5200	5166	5166
q2	1928	290	185	185
q3	10315	1264	733	733
q4	10208	1004	516	516
q5	7508	2369	2319	2319
q6	177	156	131	131
q7	897	759	591	591
q8	9301	1253	1047	1047
q9	6849	5076	5116	5076
q10	6931	2386	1963	1963
q11	485	283	260	260
q12	346	359	220	220
q13	17777	3687	3022	3022
q14	239	241	213	213
q15	577	486	474	474
q16	424	426	388	388
q17	591	859	361	361
q18	7375	7068	7057	7057
q19	1125	944	568	568
q20	333	334	226	226
q21	3710	2544	2308	2308
q22	1090	1036	989	989
Total cold run time: 105809 ms
Total hot run time: 33813 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5143	5471	5132	5132
q2	242	323	219	219
q3	2258	2651	2305	2305
q4	1348	1743	1357	1357
q5	4206	4347	4539	4347
q6	214	173	139	139
q7	2043	1982	1823	1823
q8	2613	2615	2521	2521
q9	7356	7408	7364	7364
q10	3113	3319	2869	2869
q11	606	525	488	488
q12	862	788	620	620
q13	3768	4010	3321	3321
q14	294	347	333	333
q15	525	493	474	474
q16	456	474	486	474
q17	1151	1785	1398	1398
q18	7688	7644	7713	7644
q19	802	804	863	804
q20	1994	2142	1999	1999
q21	5010	4374	4415	4374
q22	1089	1059	994	994
Total cold run time: 52781 ms
Total hot run time: 50999 ms

doris-robot · 2025-08-21T04:25:32Z

TPC-DS: Total hot run time: 185615 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ebeac497d2612e446545acf4a00257d3ce2c9ab2, data reload: false

query1	979	398	403	398
query2	6536	1734	1708	1708
query3	6739	215	216	215
query4	26522	23569	23661	23569
query5	4408	619	468	468
query6	317	243	208	208
query7	4631	512	287	287
query8	274	238	225	225
query9	8564	2840	2828	2828
query10	491	334	296	296
query11	15880	15321	14874	14874
query12	166	117	112	112
query13	1669	581	426	426
query14	8985	5770	5837	5770
query15	202	183	178	178
query16	7389	651	470	470
query17	1204	728	600	600
query18	2007	418	320	320
query19	189	192	172	172
query20	125	121	122	121
query21	213	127	108	108
query22	4009	4109	4038	4038
query23	34323	33369	33573	33369
query24	8115	2346	2351	2346
query25	539	461	406	406
query26	1232	291	159	159
query27	2717	494	341	341
query28	4362	2201	2200	2200
query29	768	544	449	449
query30	283	218	186	186
query31	865	819	708	708
query32	83	72	75	72
query33	557	369	334	334
query34	798	837	497	497
query35	782	836	758	758
query36	1005	1037	920	920
query37	118	109	86	86
query38	4074	4039	3992	3992
query39	1494	1441	1400	1400
query40	215	124	116	116
query41	57	54	52	52
query42	117	107	110	107
query43	501	483	495	483
query44	1339	855	848	848
query45	183	168	160	160
query46	847	1020	631	631
query47	1744	1811	1756	1756
query48	379	419	306	306
query49	722	488	390	390
query50	637	687	405	405
query51	4088	4174	4094	4094
query52	116	109	97	97
query53	237	259	196	196
query54	584	594	514	514
query55	93	88	82	82
query56	320	304	297	297
query57	1202	1187	1114	1114
query58	285	277	266	266
query59	2634	2773	2589	2589
query60	338	337	318	318
query61	156	121	116	116
query62	809	735	656	656
query63	225	194	192	192
query64	4323	1012	720	720
query65	4321	4234	4214	4214
query66	1169	408	325	325
query67	15590	15411	15028	15028
query68	8609	908	577	577
query69	465	319	282	282
query70	1186	1093	1155	1093
query71	470	327	304	304
query72	5372	4722	4756	4722
query73	721	583	349	349
query74	8905	8908	9030	8908
query75	3906	3047	2627	2627
query76	3653	1136	719	719
query77	795	425	329	329
query78	9492	9602	8969	8969
query79	2161	851	577	577
query80	641	542	483	483
query81	473	256	227	227
query82	238	134	108	108
query83	283	254	241	241
query84	293	105	83	83
query85	755	367	336	336
query86	357	322	289	289
query87	4323	4331	4122	4122
query88	2849	2212	2211	2211
query89	390	325	285	285
query90	2078	227	219	219
query91	145	138	109	109
query92	90	68	69	68
query93	1311	1009	643	643
query94	690	400	300	300
query95	390	313	303	303
query96	484	591	273	273
query97	2660	2685	2568	2568
query98	233	218	213	213
query99	1419	1430	1392	1392
Total cold run time: 272682 ms
Total hot run time: 185615 ms

doris-robot · 2025-08-21T04:31:02Z

ClickBench: Total hot run time: 32.78 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ebeac497d2612e446545acf4a00257d3ce2c9ab2, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.24	0.08	0.07
query4	1.62	0.11	0.11
query5	0.41	0.43	0.42
query6	1.15	0.64	0.67
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.61	0.53	0.52
query10	0.59	0.56	0.58
query11	0.16	0.11	0.11
query12	0.14	0.11	0.12
query13	0.63	0.60	0.60
query14	0.80	0.84	0.87
query15	0.89	0.87	0.86
query16	0.39	0.40	0.39
query17	1.05	1.03	1.04
query18	0.22	0.20	0.20
query19	1.89	1.82	1.86
query20	0.01	0.01	0.01
query21	15.39	0.96	0.57
query22	0.78	1.40	1.13
query23	14.69	1.36	0.62
query24	6.69	1.51	0.42
query25	0.57	0.16	0.13
query26	0.59	0.16	0.13
query27	0.05	0.05	0.05
query28	10.36	0.95	0.44
query29	12.53	3.92	3.25
query30	3.03	3.03	3.01
query31	2.84	0.59	0.40
query32	3.25	0.54	0.47
query33	3.13	3.13	3.10
query34	16.21	5.51	4.86
query35	4.95	4.92	4.97
query36	0.70	0.52	0.51
query37	0.10	0.07	0.07
query38	0.05	0.04	0.04
query39	0.03	0.03	0.03
query40	0.18	0.15	0.13
query41	0.08	0.03	0.02
query42	0.04	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 107.26 s
Total hot run time: 32.78 s

hello-stephen · 2025-08-21T04:43:54Z

FE UT Coverage Report

Increment line coverage 95.31% (61/64) 🎉
Increment coverage report
Complete coverage report

morrySnow · 2025-08-27T03:34:42Z

run buildall

doris-robot · 2025-08-27T04:07:48Z

TPC-H: Total hot run time: 33966 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 32303ddca8c223024cb9a3a73e0dc46dcd088cc6, data reload: false

------ Round 1 ----------------------------------
q1	17594	5154	5098	5098
q2	1991	341	206	206
q3	10223	1254	713	713
q4	10239	1012	544	544
q5	7537	2410	2318	2318
q6	186	174	142	142
q7	929	786	626	626
q8	9350	1331	1119	1119
q9	6909	5074	5241	5074
q10	6947	2399	1969	1969
q11	485	307	274	274
q12	353	356	225	225
q13	17788	3636	3023	3023
q14	232	240	230	230
q15	580	502	505	502
q16	434	424	382	382
q17	593	841	365	365
q18	7706	7041	7032	7032
q19	1363	952	536	536
q20	343	340	233	233
q21	4232	2575	2357	2357
q22	1066	1042	998	998
Total cold run time: 107080 ms
Total hot run time: 33966 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5156	5092	5100	5092
q2	257	330	223	223
q3	2197	2659	2301	2301
q4	1367	1786	1339	1339
q5	4234	4322	4481	4322
q6	214	169	132	132
q7	2052	1925	1864	1864
q8	2614	2658	2664	2658
q9	7396	7391	7295	7295
q10	3139	3275	2926	2926
q11	577	508	489	489
q12	696	795	664	664
q13	3528	3908	3292	3292
q14	296	300	271	271
q15	555	496	475	475
q16	455	493	454	454
q17	1187	1590	1392	1392
q18	7967	7779	7555	7555
q19	837	758	789	758
q20	1949	1958	1854	1854
q21	4640	4326	4352	4326
q22	1085	1039	1009	1009
Total cold run time: 52398 ms
Total hot run time: 50691 ms

doris-robot · 2025-08-27T04:19:28Z

TPC-DS: Total hot run time: 186879 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 32303ddca8c223024cb9a3a73e0dc46dcd088cc6, data reload: false

query1	1041	463	408	408
query2	6587	1784	1750	1750
query3	6752	229	226	226
query4	26352	24095	23593	23593
query5	5089	704	515	515
query6	357	251	228	228
query7	4655	526	313	313
query8	317	257	250	250
query9	8677	2934	2908	2908
query10	537	347	298	298
query11	15833	14975	14825	14825
query12	175	121	120	120
query13	1710	578	479	479
query14	9306	5905	5910	5905
query15	217	192	179	179
query16	7684	669	466	466
query17	1280	799	641	641
query18	2034	437	334	334
query19	202	197	172	172
query20	135	136	119	119
query21	222	127	111	111
query22	4007	4296	3959	3959
query23	33709	32944	32869	32869
query24	8134	2365	2396	2365
query25	580	515	457	457
query26	1235	289	172	172
query27	2668	519	349	349
query28	4341	2264	2237	2237
query29	789	606	520	520
query30	297	228	197	197
query31	899	819	729	729
query32	98	82	84	82
query33	585	390	354	354
query34	788	855	521	521
query35	820	833	744	744
query36	983	1020	927	927
query37	132	117	92	92
query38	4141	4019	3991	3991
query39	1480	1436	1426	1426
query40	224	135	155	135
query41	76	65	64	64
query42	130	116	118	116
query43	520	518	488	488
query44	1340	861	871	861
query45	196	177	183	177
query46	889	1016	656	656
query47	1773	1838	1755	1755
query48	394	436	340	340
query49	773	508	416	416
query50	669	683	409	409
query51	4082	4102	4132	4102
query52	119	119	106	106
query53	246	259	202	202
query54	625	592	542	542
query55	99	88	94	88
query56	342	370	340	340
query57	1198	1189	1135	1135
query58	299	282	295	282
query59	2628	2716	2646	2646
query60	363	352	339	339
query61	168	164	162	162
query62	805	756	695	695
query63	236	196	196	196
query64	4417	1131	828	828
query65	4259	4230	4227	4227
query66	1100	440	345	345
query67	15421	15066	14988	14988
query68	7827	927	587	587
query69	508	338	301	301
query70	1242	1126	1117	1117
query71	467	359	325	325
query72	6163	5191	5123	5123
query73	710	661	369	369
query74	9237	9180	8619	8619
query75	3530	3090	2643	2643
query76	3472	1150	768	768
query77	771	438	338	338
query78	9564	9697	8824	8824
query79	2558	832	604	604
query80	640	584	523	523
query81	494	265	229	229
query82	465	144	112	112
query83	261	265	259	259
query84	263	112	91	91
query85	874	464	419	419
query86	398	324	312	312
query87	4215	4313	4152	4152
query88	3720	2266	2253	2253
query89	412	336	287	287
query90	2001	218	226	218
query91	158	160	140	140
query92	93	76	70	70
query93	1914	994	659	659
query94	721	430	337	337
query95	420	345	326	326
query96	512	581	280	280
query97	2644	2658	2587	2587
query98	240	216	217	216
query99	1382	1416	1320	1320
Total cold run time: 276115 ms
Total hot run time: 186879 ms

doris-robot · 2025-08-27T04:25:06Z

ClickBench: Total hot run time: 32.61 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 32303ddca8c223024cb9a3a73e0dc46dcd088cc6, data reload: false

query1	0.05	0.04	0.04
query2	0.10	0.05	0.06
query3	0.26	0.08	0.08
query4	1.61	0.12	0.12
query5	0.45	0.41	0.41
query6	1.20	0.64	0.68
query7	0.03	0.03	0.03
query8	0.06	0.06	0.05
query9	0.61	0.53	0.54
query10	0.58	0.58	0.57
query11	0.18	0.12	0.11
query12	0.15	0.12	0.13
query13	0.63	0.63	0.62
query14	0.79	0.85	0.82
query15	0.88	0.86	0.85
query16	0.41	0.41	0.41
query17	1.07	1.04	1.07
query18	0.22	0.20	0.20
query19	1.96	1.80	1.79
query20	0.01	0.01	0.02
query21	15.40	0.95	0.59
query22	0.79	1.11	0.62
query23	15.02	1.37	0.62
query24	6.60	0.61	1.22
query25	0.51	0.12	0.13
query26	0.64	0.18	0.13
query27	0.07	0.07	0.05
query28	9.52	0.94	0.44
query29	12.54	3.89	3.26
query30	3.11	3.01	3.02
query31	2.83	0.60	0.39
query32	3.24	0.55	0.47
query33	3.07	3.09	3.10
query34	16.09	5.47	4.96
query35	4.90	4.89	4.97
query36	0.70	0.51	0.50
query37	0.10	0.08	0.07
query38	0.06	0.05	0.05
query39	0.03	0.03	0.04
query40	0.19	0.15	0.14
query41	0.09	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 106.83 s
Total hot run time: 32.61 s

hello-stephen · 2025-08-27T04:36:56Z

FE UT Coverage Report

Increment line coverage 95.31% (61/64) 🎉
Increment coverage report
Complete coverage report

RoanHeNaN

LGTM, fix the pattern like select func_a(x), func_b(func_a(x)), func_c(func_b(func_a(x))).

github-actions · 2025-08-28T03:07:39Z

PR approved by anyone and no changes requested.

github-actions · 2025-08-28T07:46:16Z

PR approved by at least one committer and no changes requested.

…pache#54998) ### What problem does this PR solve? Related PR: apache#52701 Problem Summary: 1. do not push down WhenClause in case when 2. not generate virtual column which only used once: fix the pattern like `select func_a(x), func_b(func_a(x)), func_c(func_b(func_a(x)))`.

morrySnow force-pushed the fix_push_when_to_virtual branch from 053f0c5 to ebeac49 Compare August 21, 2025 03:35

[fix](virtual column) should not push down WhenClause in case when

32303dd

morrySnow force-pushed the fix_push_when_to_virtual branch from ebeac49 to 32303dd Compare August 27, 2025 03:34

RoanHeNaN approved these changes Aug 28, 2025

View reviewed changes

github-actions Bot added the reviewed label Aug 28, 2025

starocean999 approved these changes Aug 28, 2025

View reviewed changes

morrySnow marked this pull request as ready for review August 28, 2025 07:46

github-actions Bot added the approved Indicates a PR has been approved by one committer. label Aug 28, 2025

morrySnow merged commit 90391dc into apache:master Aug 28, 2025

morrySnow deleted the fix_push_when_to_virtual branch August 28, 2025 07:55

Conversation

morrySnow commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented Aug 19, 2025

Uh oh!

morrySnow commented Aug 19, 2025

Uh oh!

doris-robot commented Aug 19, 2025

Uh oh!

doris-robot commented Aug 19, 2025

Uh oh!

doris-robot commented Aug 19, 2025

Uh oh!

morrySnow commented Aug 21, 2025

Uh oh!

doris-robot commented Aug 21, 2025

Uh oh!

doris-robot commented Aug 21, 2025

Uh oh!

doris-robot commented Aug 21, 2025

Uh oh!

hello-stephen commented Aug 21, 2025

FE UT Coverage Report

Uh oh!

morrySnow commented Aug 27, 2025

Uh oh!

doris-robot commented Aug 27, 2025

Uh oh!

doris-robot commented Aug 27, 2025

Uh oh!

doris-robot commented Aug 27, 2025

Uh oh!

hello-stephen commented Aug 27, 2025

FE UT Coverage Report

Uh oh!

RoanHeNaN left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 28, 2025

Uh oh!

github-actions Bot commented Aug 28, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

morrySnow commented Aug 19, 2025 •

edited

Loading