Skip to content

[chore](config) add config for brpc::usercode_in_pthread to let asan #54656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Aug 15, 2025
Merged

[chore](config) add config for brpc::usercode_in_pthread to let asan #54656

dataroaring merged 1 commit into from
Aug 15, 2025

Conversation

@dataroaring
Copy link
Contributor

@dataroaring dataroaring commented Aug 13, 2025

happy

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@dataroaring
Copy link
Contributor Author

dataroaring commented Aug 13, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Aug 13, 2025

TPC-H: Total hot run time: 34971 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a17dbc296a7ce77dc74814b2c45ffe9a1384b4e6, data reload: false

------ Round 1 ----------------------------------
q1	17639	5276	5111	5111
q2	1937	276	185	185
q3	10313	1331	730	730
q4	10257	1001	534	534
q5	8225	2718	2382	2382
q6	214	164	134	134
q7	932	733	627	627
q8	9317	1309	1093	1093
q9	7116	5127	5169	5127
q10	6957	2405	2003	2003
q11	473	288	273	273
q12	357	362	233	233
q13	17785	3735	3067	3067
q14	242	249	228	228
q15	576	485	486	485
q16	432	430	379	379
q17	616	871	355	355
q18	7459	7182	7184	7182
q19	1081	948	579	579
q20	345	352	227	227
q21	3820	3195	3049	3049
q22	1050	1041	988	988
Total cold run time: 107143 ms
Total hot run time: 34971 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5220	5168	5118	5118
q2	240	332	223	223
q3	2189	2700	2338	2338
q4	1360	1790	1349	1349
q5	4451	4556	4551	4551
q6	218	184	136	136
q7	2033	1999	1772	1772
q8	2682	2637	2609	2609
q9	7407	7343	7296	7296
q10	3158	3333	2887	2887
q11	741	526	515	515
q12	712	773	637	637
q13	3455	4087	3418	3418
q14	273	345	281	281
q15	518	488	484	484
q16	447	505	465	465
q17	1213	1591	1438	1438
q18	7911	7804	7576	7576
q19	829	799	823	799
q20	1926	1965	1802	1802
q21	4821	4417	4308	4308
q22	1081	1047	1004	1004
Total cold run time: 52885 ms
Total hot run time: 51006 ms

@doris-robot
Copy link

doris-robot commented Aug 13, 2025

TPC-DS: Total hot run time: 185314 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a17dbc296a7ce77dc74814b2c45ffe9a1384b4e6, data reload: false

query1	971	395	411	395
query2	6548	1719	1726	1719
query3	6747	228	224	224
query4	26716	23349	23414	23349
query5	4322	618	514	514
query6	312	205	212	205
query7	4629	503	288	288
query8	265	225	213	213
query9	8581	2910	2948	2910
query10	489	332	301	301
query11	15427	14943	14772	14772
query12	154	116	111	111
query13	1668	543	414	414
query14	8579	5875	5809	5809
query15	205	184	167	167
query16	7148	640	489	489
query17	928	694	556	556
query18	1971	410	312	312
query19	182	185	161	161
query20	129	119	117	117
query21	207	157	106	106
query22	4108	4044	4006	4006
query23	34150	33066	33404	33066
query24	8140	2390	2413	2390
query25	542	462	432	432
query26	1240	272	161	161
query27	2742	501	342	342
query28	4362	2286	2253	2253
query29	786	578	460	460
query30	288	213	191	191
query31	900	824	737	737
query32	87	77	78	77
query33	598	400	366	366
query34	807	861	525	525
query35	802	831	756	756
query36	993	1020	915	915
query37	124	112	87	87
query38	4099	4062	3978	3978
query39	1481	1422	1416	1416
query40	235	138	125	125
query41	69	65	64	64
query42	126	116	112	112
query43	520	516	482	482
query44	1411	864	854	854
query45	180	177	172	172
query46	903	1029	680	680
query47	1753	1792	1718	1718
query48	398	435	339	339
query49	764	506	411	411
query50	715	713	429	429
query51	4024	4150	4047	4047
query52	112	118	102	102
query53	249	261	205	205
query54	612	603	529	529
query55	91	88	86	86
query56	332	319	297	297
query57	1226	1185	1117	1117
query58	299	275	273	273
query59	2647	2655	2681	2655
query60	361	337	323	323
query61	131	119	124	119
query62	841	726	642	642
query63	230	197	198	197
query64	4339	1054	685	685
query65	4318	4187	4226	4187
query66	1150	414	331	331
query67	15320	15284	15205	15205
query68	7845	945	576	576
query69	483	330	295	295
query70	1243	1177	1079	1079
query71	446	338	323	323
query72	5676	4702	4802	4702
query73	650	624	358	358
query74	9129	8939	8629	8629
query75	3825	3092	2616	2616
query76	3446	1159	775	775
query77	808	408	341	341
query78	9526	9635	8899	8899
query79	2171	852	597	597
query80	613	554	482	482
query81	479	259	220	220
query82	428	148	104	104
query83	253	249	298	249
query84	297	106	85	85
query85	792	359	327	327
query86	348	322	293	293
query87	4295	4372	4204	4204
query88	3327	2244	2189	2189
query89	391	307	285	285
query90	1917	225	219	219
query91	142	143	110	110
query92	81	72	69	69
query93	1406	975	635	635
query94	655	393	309	309
query95	389	321	309	309
query96	489	580	273	273
query97	2640	2698	2587	2587
query98	249	218	208	208
query99	1352	1450	1291	1291
Total cold run time: 271574 ms
Total hot run time: 185314 ms

@doris-robot
Copy link

doris-robot commented Aug 13, 2025

ClickBench: Total hot run time: 32.97 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a17dbc296a7ce77dc74814b2c45ffe9a1384b4e6, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.04	0.04
query3	0.24	0.07	0.08
query4	1.64	0.11	0.11
query5	0.44	0.40	0.40
query6	1.17	0.65	0.65
query7	0.02	0.02	0.02
query8	0.05	0.04	0.04
query9	0.60	0.51	0.50
query10	0.57	0.57	0.57
query11	0.17	0.11	0.11
query12	0.15	0.12	0.12
query13	0.63	0.62	0.61
query14	0.81	0.82	0.85
query15	0.89	0.86	0.88
query16	0.38	0.41	0.39
query17	1.02	1.07	1.04
query18	0.21	0.20	0.19
query19	1.91	1.87	1.85
query20	0.02	0.01	0.01
query21	15.44	0.91	0.55
query22	0.76	1.04	0.61
query23	15.19	1.33	0.63
query24	6.49	2.30	1.12
query25	0.55	0.16	0.06
query26	0.52	0.17	0.13
query27	0.05	0.05	0.06
query28	10.30	0.95	0.42
query29	12.54	3.85	3.25
query30	3.07	3.03	3.04
query31	2.82	0.59	0.39
query32	3.24	0.55	0.48
query33	3.15	3.10	3.14
query34	16.11	5.48	4.94
query35	5.00	4.91	4.98
query36	0.66	0.50	0.50
query37	0.10	0.07	0.07
query38	0.06	0.04	0.05
query39	0.03	0.02	0.03
query40	0.18	0.15	0.14
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 107.46 s
Total hot run time: 32.97 s

@doris-robot
Copy link

doris-robot commented Aug 13, 2025

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 59.03% (16629/28172)
Line Coverage 47.90% (150831/314885)
Region Coverage 36.73% (112975/307565)
Branch Coverage 39.65% (50134/126457)

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 13, 2025

BE Regression && UT Coverage Report

Increment line coverage 33.33% (1/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.73% (22598/27649)
Line Coverage 74.35% (234115/314895)
Region Coverage 61.59% (194531/315828)
Branch Coverage 65.66% (84053/128005)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2025

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2025

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit e88b8cc into apache:master Aug 15, 2025
30 of 32 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 15, 2025
@dataroaring
[chore](config) add config for brpc::usercode_in_pthread to let asan (#…
4b2e4c4 
…54656)

happy

Co-authored-by: Yongqiang YANG <[email protected]>
@github-actions github-actions bot mentioned this pull request Aug 15, 2025
Open
github-actions bot pushed a commit that referenced this pull request Aug 15, 2025
@dataroaring
[chore](config) add config for brpc::usercode_in_pthread to let asan (#…
eb37b29 
…54656)

happy

Co-authored-by: Yongqiang YANG <[email protected]>
@github-actions github-actions bot mentioned this pull request Aug 15, 2025
Merged
morrySnow pushed a commit that referenced this pull request Sep 4, 2025
@github-actions @dataroaring
branch-3.1: [chore](config) add config for brpc::usercode_in_pthread …
60b5c22 
…to let asan #54656 (#54829)

Cherry-picked from #54656

Co-authored-by: Yongqiang YANG <[email protected]>
Co-authored-by: Yongqiang YANG <[email protected]>
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

+1 more reviewer

@Yukang-Lian Yukang-Lian Yukang-Lian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.x dev/3.1.1-merged p0_test reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dataroaring @doris-robot @hello-stephen @gavinchou @Yukang-Lian @morrySnow