Skip to content

Revert "[third-party](faiss) Enable FAISS integration in Doris. (#496… - #53945

Merged
airborne12 merged 1 commit into
apache:masterfrom
RoanHeNaN:chore-1
Jul 28, 2025
Merged

Revert "[third-party](faiss) Enable FAISS integration in Doris. (#496…#53945
airborne12 merged 1 commit into
apache:masterfrom
RoanHeNaN:chore-1

Conversation

@RoanHeNaN

@RoanHeNaN RoanHeNaN commented Jul 28, 2025

Copy link
Copy Markdown
Contributor

…44)"

This reverts commit 8740049.

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

hello-stephen commented Jul 28, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@RoanHeNaN

RoanHeNaN commented Jul 28, 2025

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

doris-robot commented Jul 28, 2025

Copy link
Copy Markdown
TPC-H: Total hot run time: 33735 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3813266e42f2120e78df2fdca4ce081c1164d21f, data reload: false

------ Round 1 ----------------------------------
q1	17588	5304	5247	5247
q2	1923	286	182	182
q3	10306	1333	706	706
q4	10236	1020	509	509
q5	7526	2319	2268	2268
q6	186	166	132	132
q7	906	751	604	604
q8	9307	1255	1067	1067
q9	6774	5069	5023	5023
q10	6895	2350	1970	1970
q11	453	278	264	264
q12	354	361	224	224
q13	17790	3537	2999	2999
q14	241	238	218	218
q15	538	459	471	459
q16	444	424	378	378
q17	576	848	358	358
q18	7451	7014	7135	7014
q19	3362	1003	548	548
q20	321	321	220	220
q21	3374	3064	2330	2330
q22	1057	1063	1015	1015
Total cold run time: 107608 ms
Total hot run time: 33735 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5622	5358	5332	5332
q2	245	309	216	216
q3	2097	2543	2242	2242
q4	1330	1734	1334	1334
q5	4172	4514	4406	4406
q6	222	179	135	135
q7	2052	2003	1817	1817
q8	2539	2703	2746	2703
q9	7233	7218	7209	7209
q10	3058	3419	2947	2947
q11	548	574	552	552
q12	1071	753	648	648
q13	3387	3805	3459	3459
q14	303	324	283	283
q15	497	455	479	455
q16	459	530	466	466
q17	1149	1512	1387	1387
q18	7997	7834	7663	7663
q19	10563	939	1055	939
q20	3072	2061	1840	1840
q21	11865	4280	4283	4280
q22	1125	1052	991	991
Total cold run time: 70606 ms
Total hot run time: 51304 ms

@doris-robot

doris-robot commented Jul 28, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 171331 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3813266e42f2120e78df2fdca4ce081c1164d21f, data reload: false

============================================
query1	996	392	413	392
query2	6505	1793	1737	1737
query3	6744	232	224	224
query4	27179	23840	22873	22873
query5	4371	643	569	569
query6	325	258	239	239
query7	4651	525	298	298
query8	282	235	246	235
query9	8564	2962	2978	2962
query10	464	338	287	287
query11	15598	14934	14711	14711
query12	183	131	134	131
query13	1653	558	402	402
query14	8766	5942	6062	5942
query15	231	203	170	170
query16	7151	639	444	444
query17	972	771	637	637
query18	1994	457	327	327
query19	225	220	191	191
query20	147	142	141	141
query21	219	135	117	117
query22	4044	4070	3833	3833
query23	34481	33946	33829	33829
query24	5322	2400	2450	2400
query25	478	514	437	437
query26	723	286	165	165
query27	2265	507	396	396
query28	3015	2294	2305	2294
query29	611	623	490	490
query30	290	230	198	198
query31	841	788	737	737
query32	107	80	78	78
query33	485	427	371	371
query34	801	851	525	525
query35	809	804	741	741
query36	1028	1042	943	943
query37	141	110	91	91
query38	4017	3985	4046	3985
query39	1465	1387	1365	1365
query40	242	149	138	138
query41	63	58	54	54
query42	140	122	129	122
query43	523	508	507	507
query44	1458	878	885	878
query45	201	187	186	186
query46	937	1061	697	697
query47	1818	1824	1776	1776
query48	410	462	311	311
query49	707	508	442	442
query50	658	694	434	434
query51	5597	5466	5479	5466
query52	130	134	119	119
query53	283	300	218	218
query54	656	652	568	568
query55	93	90	89	89
query56	358	367	346	346
query57	1186	1209	1152	1152
query58	336	329	338	329
query59	2726	2612	2588	2588
query60	413	429	404	404
query61	122	120	120	120
query62	720	754	662	662
query63	260	236	222	222
query64	2341	1071	813	813
query65	4189	4085	4053	4053
query66	713	433	343	343
query67	query68	17036	844	931	844
query69	1054	285	289	285
query70	1420	1137	1070	1070
query71	719	321	332	321
query72	9193	2224	2117	2117
query73	3493	691	359	359
query74	9227	8719	8801	8719
query75	7581	3158	2723	2723
query76	8894	1236	807	807
query77	1143	425	343	343
query78	9712	10637	9578	9578
query79	14605	681	583	583
query80	1887	570	491	491
query81	547	261	230	230
query82	499	150	116	116
query83	371	286	259	259
query84	300	104	84	84
query85	939	386	405	386
query86	357	332	307	307
query87	4319	4324	4141	4141
query88	5598	2281	2300	2281
query89	484	376	312	312
query90	2674	241	238	238
query91	158	136	109	109
query92	87	73	74	73
query93	6269	1026	661	661
query94	1017	403	279	279
query95	403	336	328	328
query96	524	615	286	286
query97	2758	2761	2589	2589
query98	266	235	222	222
query99	1451	1441	1246	1246
Total cold run time: 300408 ms
Total hot run time: 171331 ms

@doris-robot

doris-robot commented Jul 28, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 32.73 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3813266e42f2120e78df2fdca4ce081c1164d21f, data reload: false

query1	0.05	0.03	0.04
query2	0.08	0.04	0.05
query3	0.24	0.07	0.06
query4	1.66	0.10	0.11
query5	0.44	0.40	0.45
query6	1.17	0.68	0.70
query7	0.02	0.02	0.01
query8	0.05	0.04	0.03
query9	0.55	0.49	0.47
query10	0.52	0.53	0.52
query11	0.16	0.11	0.10
query12	0.15	0.11	0.11
query13	0.67	0.66	0.63
query14	0.94	1.15	1.05
query15	0.93	0.90	0.91
query16	0.38	0.40	0.40
query17	1.08	1.04	1.10
query18	0.22	0.20	0.20
query19	1.97	1.84	1.94
query20	0.02	0.01	0.01
query21	15.37	0.86	0.54
query22	0.78	1.16	0.74
query23	14.88	1.20	0.58
query24	6.45	1.67	0.36
query25	0.45	0.13	0.12
query26	0.67	0.17	0.14
query27	0.06	0.05	0.06
query28	9.55	0.87	0.45
query29	12.56	3.86	3.32
query30	3.10	2.93	2.92
query31	2.85	0.58	0.41
query32	3.23	0.58	0.50
query33	3.03	3.23	3.22
query34	15.77	5.30	4.94
query35	4.85	4.99	5.00
query36	0.67	0.51	0.49
query37	0.10	0.07	0.07
query38	0.05	0.05	0.04
query39	0.03	0.02	0.02
query40	0.16	0.14	0.13
query41	0.08	0.03	0.03
query42	0.03	0.02	0.02
query43	0.05	0.04	0.03
Total cold run time: 106.07 s
Total hot run time: 32.73 s

@doris-robot

doris-robot commented Jul 28, 2025

Copy link
Copy Markdown

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.56% (15938/27690)
Line Coverage 46.35% (143327/309223)
Region Coverage 35.78% (107961/301777)
Branch Coverage 38.31% (47655/124406)

@hello-stephen

hello-stephen commented Jul 28, 2025

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.11% (22050/27184)
Line Coverage 73.71% (227603/308799)
Region Coverage 61.31% (189780/309529)
Branch Coverage 65.05% (81843/125814)

airborne12
airborne12 approved these changes Jul 28, 2025
View reviewed changes

@airborne12 airborne12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Jul 28, 2025
@github-actions

github-actions Bot commented Jul 28, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actions Bot commented Jul 28, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

zzzxl1993
zzzxl1993 approved these changes Jul 28, 2025
View reviewed changes

@zzzxl1993 zzzxl1993 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@airborne12
airborne12 merged commit 150bc0a into apache:master Jul 28, 2025
@RoanHeNaN
RoanHeNaN deleted the chore-1 branch July 29, 2025 06:12
@morningman morningman mentioned this pull request Sep 29, 2026
Closed
3 of 16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@airborne12 airborne12 airborne12 approved these changes
@zzzxl1993 zzzxl1993 zzzxl1993 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RoanHeNaN @hello-stephen @doris-robot @airborne12 @zzzxl1993