Skip to content

branch-2.1: [Enhancement](GEO) Support Multipolygon and some spatial functions #50073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 3 commits into from
Apr 17, 2025
Merged

branch-2.1: [Enhancement](GEO) Support Multipolygon and some spatial functions #50073

yiguolei merged 3 commits into from
Apr 17, 2025

Conversation

@linrrzqqq
Copy link
Contributor

@linrrzqqq linrrzqqq commented Apr 15, 2025 •
edited
Loading

pick: #37003, #48695 and #49665

@linrrzqqq linrrzqqq requested a review from yiguolei as a code owner April 15, 2025 16:12
@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 15, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@linrrzqqq
Copy link
Contributor Author

linrrzqqq commented Apr 15, 2025

run buildall

@linrrzqqq linrrzqqq force-pushed the pick_34396_48695_49665_branch_2_1 branch from d19d4f4 to 0729f05 Compare April 16, 2025 11:44
@linrrzqqq
Copy link
Contributor Author

linrrzqqq commented Apr 16, 2025

run buildall

Mryange and others added 3 commits April 16, 2025 23:20
@Mryange @linrrzqqq
[opt](function)avoid virtual function calls in geo functions (apache#…
90464b6 
…37003)
@koi2000 @linrrzqqq
[Enhancement] Support some spatial functions (apache#48695)
f72a88e 
Support for ST_Intersects, ST_Disjoint, ST_Touches sql functions.
@linrrzqqq
[Enhancement] (GEO) Support MultiPolygon for Geometry functions (apac…
66b591b 
…he#49665)

### What problem does this PR solve?
1. Enhances the `GeometryFromText` function to support parsing
`MULTIPOLYGON` WKT
2. Support `ST_CONTAINS ` , `ST_INTERSECTS`, `ST_TOUCHES` for it and
other shapes.
3. Fixed the behavior of `ST_Touches` between two polygons, which has
been updated to return `true` when they touch at a single point that is
not on a horizontal or vertical edge.
For example, the following polygons now return true for ST_Touches:
         - `POLYGON((0 0, 10 0, 10 10, 0 10, 0 0))`
         -  `POLYGON((5 10, 0 15, 10 15))`
Obviously, they touches at the point `(5 10)`
@linrrzqqq linrrzqqq force-pushed the pick_34396_48695_49665_branch_2_1 branch from 0729f05 to 66b591b Compare April 16, 2025 15:26
@linrrzqqq
Copy link
Contributor Author

linrrzqqq commented Apr 16, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 16, 2025

BE UT Coverage Report

Increment line coverage 72.60% (779/1073) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.80% (10251/26421)
Line Coverage 29.84% (85072/285070)
Region Coverage 28.51% (43857/153843)
Branch Coverage 25.23% (22416/88858)

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Apr 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2025

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit ea29bc5 into apache:branch-2.1 Apr 17, 2025
21 of 22 checks passed
@linrrzqqq linrrzqqq deleted the pick_34396_48695_49665_branch_2_1 branch April 17, 2025 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@linrrzqqq @hello-stephen @yiguolei @Mryange @koi2000