[Enhancement] (GEO) Support MultiPolygon for Geometry functions #49665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
linrrzqqq
force-pushed
the
mtPolygon
branch
2 times, most recently
from
7c0a233 to
eacdd3d
Compare
linrrzqqq
changed the title
linrrzqqq
force-pushed
the
mtPolygon
branch
2 times, most recently
from
cddc1ef to
6d6de26
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34125 ms |
TPC-DS: Total hot run time: 193478 ms |
ClickBench: Total hot run time: 30.92 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
linrrzqqq
force-pushed
the
mtPolygon
branch
2 times, most recently
from
3cd8e0d to
1bd72c1
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34062 ms |
TPC-DS: Total hot run time: 193985 ms |
ClickBench: Total hot run time: 31.09 s |
linrrzqqq
force-pushed
the
mtPolygon
branch
3 times, most recently
from
0283175 to
c2c05ad
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33929 ms |
TPC-DS: Total hot run time: 192578 ms |
ClickBench: Total hot run time: 30.96 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34228 ms |
TPC-DS: Total hot run time: 186471 ms |
linrrzqqq
added a commit
to linrrzqqq/doris
that referenced
this pull request
Apr 15, 2025
…he#49665) 1. Enhances the `GeometryFromText` function to support parsing `MULTIPOLYGON` WKT 2. Support `ST_CONTAINS ` , `ST_INTERSECTS`, `ST_TOUCHES` for it and other shapes. 3. Fixed the behavior of `ST_Touches` between two polygons, which has been updated to return `true` when they touch at a single point that is not on a horizontal or vertical edge. For example, the following polygons now return true for ST_Touches: - `POLYGON((0 0, 10 0, 10 10, 0 10, 0 0))` - `POLYGON((5 10, 0 15, 10 15))` Obviously, they touches at the point `(5 10)`
linrrzqqq
added a commit
to linrrzqqq/doris
that referenced
this pull request
Apr 15, 2025
…he#49665) ### What problem does this PR solve? 1. Enhances the `GeometryFromText` function to support parsing `MULTIPOLYGON` WKT 2. Support `ST_CONTAINS ` , `ST_INTERSECTS`, `ST_TOUCHES` for it and other shapes. 3. Fixed the behavior of `ST_Touches` between two polygons, which has been updated to return `true` when they touch at a single point that is not on a horizontal or vertical edge. For example, the following polygons now return true for ST_Touches: - `POLYGON((0 0, 10 0, 10 10, 0 10, 0 0))` - `POLYGON((5 10, 0 15, 10 15))` Obviously, they touches at the point `(5 10)`
linrrzqqq
added a commit
to linrrzqqq/doris
that referenced
this pull request
Apr 15, 2025
…he#49665) ### What problem does this PR solve? 1. Enhances the `GeometryFromText` function to support parsing `MULTIPOLYGON` WKT 2. Support `ST_CONTAINS ` , `ST_INTERSECTS`, `ST_TOUCHES` for it and other shapes. 3. Fixed the behavior of `ST_Touches` between two polygons, which has been updated to return `true` when they touch at a single point that is not on a horizontal or vertical edge. For example, the following polygons now return true for ST_Touches: - `POLYGON((0 0, 10 0, 10 10, 0 10, 0 0))` - `POLYGON((5 10, 0 15, 10 15))` Obviously, they touches at the point `(5 10)`
linrrzqqq
added a commit
to linrrzqqq/doris
that referenced
this pull request
Apr 16, 2025
…he#49665) ### What problem does this PR solve? 1. Enhances the `GeometryFromText` function to support parsing `MULTIPOLYGON` WKT 2. Support `ST_CONTAINS ` , `ST_INTERSECTS`, `ST_TOUCHES` for it and other shapes. 3. Fixed the behavior of `ST_Touches` between two polygons, which has been updated to return `true` when they touch at a single point that is not on a horizontal or vertical edge. For example, the following polygons now return true for ST_Touches: - `POLYGON((0 0, 10 0, 10 10, 0 10, 0 0))` - `POLYGON((5 10, 0 15, 10 15))` Obviously, they touches at the point `(5 10)`
linrrzqqq
added a commit
to linrrzqqq/doris
that referenced
this pull request
Apr 16, 2025
…he#49665) ### What problem does this PR solve? 1. Enhances the `GeometryFromText` function to support parsing `MULTIPOLYGON` WKT 2. Support `ST_CONTAINS ` , `ST_INTERSECTS`, `ST_TOUCHES` for it and other shapes. 3. Fixed the behavior of `ST_Touches` between two polygons, which has been updated to return `true` when they touch at a single point that is not on a horizontal or vertical edge. For example, the following polygons now return true for ST_Touches: - `POLYGON((0 0, 10 0, 10 10, 0 10, 0 0))` - `POLYGON((5 10, 0 15, 10 15))` Obviously, they touches at the point `(5 10)`
linrrzqqq
added a commit
to linrrzqqq/doris
that referenced
this pull request
Apr 16, 2025
…he#49665) ### What problem does this PR solve? 1. Enhances the `GeometryFromText` function to support parsing `MULTIPOLYGON` WKT 2. Support `ST_CONTAINS ` , `ST_INTERSECTS`, `ST_TOUCHES` for it and other shapes. 3. Fixed the behavior of `ST_Touches` between two polygons, which has been updated to return `true` when they touch at a single point that is not on a horizontal or vertical edge. For example, the following polygons now return true for ST_Touches: - `POLYGON((0 0, 10 0, 10 10, 0 10, 0 0))` - `POLYGON((5 10, 0 15, 10 15))` Obviously, they touches at the point `(5 10)`
linrrzqqq
added a commit
to linrrzqqq/doris
that referenced
this pull request
Apr 16, 2025
…he#49665) ### What problem does this PR solve? 1. Enhances the `GeometryFromText` function to support parsing `MULTIPOLYGON` WKT 2. Support `ST_CONTAINS ` , `ST_INTERSECTS`, `ST_TOUCHES` for it and other shapes. 3. Fixed the behavior of `ST_Touches` between two polygons, which has been updated to return `true` when they touch at a single point that is not on a horizontal or vertical edge. For example, the following polygons now return true for ST_Touches: - `POLYGON((0 0, 10 0, 10 10, 0 10, 0 0))` - `POLYGON((5 10, 0 15, 10 15))` Obviously, they touches at the point `(5 10)`
yiguolei
pushed a commit
that referenced
this pull request
Apr 17, 2025
…functions (#50073) pick: #37003, #48695 and #49665 --------- Co-authored-by: Mryange <[email protected]> Co-authored-by: koi <[email protected]>
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Apr 17, 2025
…he#49665) ### What problem does this PR solve? 1. Enhances the `GeometryFromText` function to support parsing `MULTIPOLYGON` WKT 2. Support `ST_CONTAINS ` , `ST_INTERSECTS`, `ST_TOUCHES` for it and other shapes. 3. Fixed the behavior of `ST_Touches` between two polygons, which has been updated to return `true` when they touch at a single point that is not on a horizontal or vertical edge. For example, the following polygons now return true for ST_Touches: - `POLYGON((0 0, 10 0, 10 10, 0 10, 0 0))` - `POLYGON((5 10, 0 15, 10 15))` Obviously, they touches at the point `(5 10)`
dataroaring
pushed a commit
that referenced
this pull request
Apr 22, 2025
…0061) pick: #48695 and #49665 --------- Co-authored-by: koi <[email protected]>
Closed
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…he#49665) ### What problem does this PR solve? 1. Enhances the `GeometryFromText` function to support parsing `MULTIPOLYGON` WKT 2. Support `ST_CONTAINS ` , `ST_INTERSECTS`, `ST_TOUCHES` for it and other shapes. 3. Fixed the behavior of `ST_Touches` between two polygons, which has been updated to return `true` when they touch at a single point that is not on a horizontal or vertical edge. For example, the following polygons now return true for ST_Touches: - `POLYGON((0 0, 10 0, 10 10, 0 10, 0 0))` - `POLYGON((5 10, 0 15, 10 15))` Obviously, they touches at the point `(5 10)`
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
GeometryFromTextfunction to support parsingMULTIPOLYGONWKTST_CONTAINS,ST_INTERSECTS,ST_TOUCHESfor it and other shapes.ST_Touchesbetween two polygons, which has been updated to returntruewhen they touch at a single point that is not on a horizontal or vertical edge.For example, the following polygons now return true for ST_Touches:
-
POLYGON((0 0, 10 0, 10 10, 0 10, 0 0))-
POLYGON((5 10, 0 15, 10 15))Obviously, they touches at the point
(5 10)Issue Number: close #49481
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)