Skip to content

branch-3.0: [fix](arrow) Fix Arrow serialization and deserialization of Date/Datetime/Array/Map/Struct/Bitmap/HLL/Decimal256 types - #49643

Merged
dataroaring merged 1 commit into
apache:branch-3.0from
xinyiZzz:branch-3.0_20250328
May 6, 2025
Merged

dataroaring merged 1 commit into
apache:branch-3.0from
xinyiZzz:branch-3.0_20250328

Conversation

@xinyiZzz

Copy link
Copy Markdown
Contributor

pick #48944 fix Fix UT DataTypeSerDeArrowTest of Array/Map/Struct/Bitmap/HLL/Decimal256 types
pick #48398 fix Fix UT DataTypeSerDeArrowTest of Date type

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@xinyiZzz
xinyiZzz requested a review from dataroaring as a code owner March 28, 2025 11:45
@Thearas

Thearas commented Mar 28, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@xinyiZzz

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 84.47% (87/103) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.99% (10206/26174)
Line Coverage 30.51% (87393/286416)
Region Coverage 29.50% (44832/151971)
Branch Coverage 26.01% (22810/87692)

@yiguolei yiguolei added the usercase Important user case type label label Mar 29, 2025
yiguolei
yiguolei previously approved these changes Mar 31, 2025
@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Mar 31, 2025
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

…of Date/Datetime/Array/Map/Struct/Bitmap/HLL/Decimal256 types (apache#49244)

pick apache#48944 [fix](arrow) Fix UT DataTypeSerDeArrowTest of
Array/Map/Struct/Bitmap/HLL/Decimal256 types
pick apache#48398  [fix](arrow) Fix UT DataTypeSerDeArrowTest of Date type
@xinyiZzz

Copy link
Copy Markdown
Contributor Author

run buildall

@github-actions github-actions Bot removed the approved Indicates a PR has been approved by one committer. label Apr 30, 2025
@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 84.47% (87/103) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 40.69% (10694/26283)
Line Coverage 31.49% (90921/288719)
Region Coverage 30.60% (46902/153291)
Branch Coverage 27.07% (23993/88634)

@dataroaring dataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
dataroaring merged commit 84c6e21 into apache:branch-3.0 May 6, 2025
yiguolei pushed a commit that referenced this pull request Jul 1, 2025
…ompatibility (#52531)

Introduced from #49643

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
morrySnow pushed a commit that referenced this pull request Jul 1, 2025
yiguolei pushed a commit that referenced this pull request Jul 2, 2025
dataroaring pushed a commit that referenced this pull request Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewed usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants