Skip to content

branch-2.1: [fix](arrow) Fix Arrow serialization and deserialization of Date/Datetime/Array/Map/Struct/Bitmap/HLL/Decimal256 types - #49244

Merged
yiguolei merged 2 commits into
apache:branch-2.1from
xinyiZzz:branch-2.1_20250317_pick
Mar 20, 2025
Merged

branch-2.1: [fix](arrow) Fix Arrow serialization and deserialization of Date/Datetime/Array/Map/Struct/Bitmap/HLL/Decimal256 types#49244
yiguolei merged 2 commits into
apache:branch-2.1from
xinyiZzz:branch-2.1_20250317_pick

Conversation

@xinyiZzz

@xinyiZzz xinyiZzz commented Mar 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

pick #48944 fix Fix UT DataTypeSerDeArrowTest of Array/Map/Struct/Bitmap/HLL/Decimal256 types
pick #48398 fix Fix UT DataTypeSerDeArrowTest of Date type

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@xinyiZzz
[fix](arrow) Fix UT DataTypeSerDeArrowTest of Array/Map/Struct/Bitmap…
568f757 
…/HLL/Decimal256 types (apache#48944)

Fix UT DataTypeSerDeArrowTest of Array/Map/Struct/Bitmap/HLL/Decimal256
types.

TODO:
1. Map and Struct types `deserialize_one_cell_from_json` has Bug, which
makes some cases unable to be tested by the framework. cannot test
Struct type nested Array and Map and Struct, so manually construct data
to test them. scalar type can be covered in the
`data_type_serde_arrow_test`.
2. Bitmap and HLL types only support Doris Column serialization to
Arrow, but not deserialization. Currently, only ArrowReader of Data Lake
uses deserialization Arrow -> Doris.
@xinyiZzz
xinyiZzz requested a review from yiguolei as a code owner March 19, 2025 06:37
@Thearas

Thearas commented Mar 19, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@xinyiZzz
xinyiZzz force-pushed the branch-2.1_20250317_pick branch from 399c2a3 to 1d5ae8a Compare March 19, 2025 08:26
@xinyiZzz xinyiZzz changed the title branch-2.1: [fix](arrow) Fix UT DataTypeSerDeArrowTest of Array/Map/Struct/Bitmap/HLL/Decimal256 types branch-2.1: [fix](arrow) Fix Arrow serialization and deserialization of Date/Datetime/Array/Map/Struct/Bitmap/HLL/Decimal256 types Mar 19, 2025
@xinyiZzz

xinyiZzz commented Mar 19, 2025

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

doris-robot commented Mar 19, 2025

Copy link
Copy Markdown

BE UT Coverage Report

Increment line coverage 80.18% (89/111) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 37.38% (9847/26343)
Line Coverage 29.06% (82455/283746)
Region Coverage 27.68% (42303/152842)
Branch Coverage 24.43% (21534/88150)

@yiguolei
yiguolei merged commit 8f79742 into apache:branch-2.1 Mar 20, 2025
xinyiZzz added a commit to xinyiZzz/incubator-doris that referenced this pull request Mar 28, 2025
@xinyiZzz
branch-2.1: [fix](arrow) Fix Arrow serialization and deserialization …
16f43c4 
…of Date/Datetime/Array/Map/Struct/Bitmap/HLL/Decimal256 types (apache#49244)

pick apache#48944 [fix](arrow) Fix UT DataTypeSerDeArrowTest of
Array/Map/Struct/Bitmap/HLL/Decimal256 types
pick apache#48398  [fix](arrow) Fix UT DataTypeSerDeArrowTest of Date type
xinyiZzz added a commit to xinyiZzz/incubator-doris that referenced this pull request Apr 30, 2025
@xinyiZzz
branch-2.1: [fix](arrow) Fix Arrow serialization and deserialization …
da3cf11 
…of Date/Datetime/Array/Map/Struct/Bitmap/HLL/Decimal256 types (apache#49244)

pick apache#48944 [fix](arrow) Fix UT DataTypeSerDeArrowTest of
Array/Map/Struct/Bitmap/HLL/Decimal256 types
pick apache#48398  [fix](arrow) Fix UT DataTypeSerDeArrowTest of Date type
@Doris-Breakwater Doris-Breakwater mentioned this pull request Sep 22, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xinyiZzz @Thearas @doris-robot @yiguolei