Repository navigation
[Enhancement] (nereids)implement alterCatalogCommentCommand in nereids - #45160
Merged
Merged
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
msridhar78
marked this pull request as draft
December 8, 2024 13:57
msridhar78
force-pushed
the
alter_catalog_comment
branch
from
December 8, 2024 15:46
8a2c50d to
8ec8e5f
Compare
msridhar78
marked this pull request as ready for review
December 8, 2024 15:47
Contributor
Author
|
run buildall |
starocean999
reviewed
Dec 9, 2024
| if (Strings.isNullOrEmpty(comment)) { | ||
| throw new AnalysisException("New comment is not set."); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
some validation code from base class is missed. for example:
Util.checkCatalogAllRules(catalogName);
if (!Env.getCurrentEnv().getAccessManager().checkCtlPriv(
ConnectContext.get(), catalogName, PrivPredicate.ALTER)) {
ErrorReport.reportAnalysisException(ErrorCode.ERR_CATALOG_ACCESS_DENIED,
analyzer.getQualifiedUser(), catalogName);
}
if (catalogName.equals(InternalCatalog.INTERNAL_CATALOG_NAME)) {
throw new AnalysisException("Internal catalog can't be alter.");
}
You can create a base class AlterCatalogCommand like AlterCatalogStmt in old planner for all AlterCatalogxxx commands
Contributor
Author
There was a problem hiding this comment.
done - please review
This was referenced Dec 9, 2024
msridhar78
force-pushed
the
alter_catalog_comment
branch
from
December 12, 2024 12:56
8ec8e5f to
11c5660
Compare
Contributor
Author
|
run buildall |
starocean999
approved these changes
Dec 16, 2024
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
LiBinfeng-01
approved these changes
Dec 16, 2024
HappenLee
pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #42790
Related PR: #xxx
Problem Summary:
[Enhancement] (nereids)implement alterCatalogCommentCommand in nereids
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)