Skip to content

branch-2.1: [fix](third party) fix hang when destroy of rdkafka instances #44913#44951

Merged
yiguolei merged 2 commits intobranch-2.1from
auto-pick-44913-branch-2.1
Dec 9, 2024
Merged

branch-2.1: [fix](third party) fix hang when destroy of rdkafka instances #44913#44951
yiguolei merged 2 commits intobranch-2.1from
auto-pick-44913-branch-2.1

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented Dec 3, 2024

Cherry-picked from #44913

@doris-robot
Copy link
Copy Markdown

doris-robot commented Dec 3, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Dec 3, 2024
@dataroaring dataroaring reopened this Dec 3, 2024
@doris-robot
Copy link
Copy Markdown

doris-robot commented Dec 3, 2024

run buildall

@doris-robot
Copy link
Copy Markdown

doris-robot commented Dec 3, 2024

TeamCity be ut coverage result:
Function Coverage: 36.74% (9612/26161)
Line Coverage: 28.13% (79064/281054)
Region Coverage: 26.79% (40581/151506)
Branch Coverage: 23.61% (20651/87466)
Coverage Report: http://coverage.selectdb-in.cc/coverage/74e685bc0b2f9107766ffbcee87e675a622709bf_74e685bc0b2f9107766ffbcee87e675a622709bf/report/index.html

@dataroaring dataroaring force-pushed the auto-pick-44913-branch-2.1 branch from 74e685b to 983edb6 Compare December 5, 2024 11:19
@dataroaring
Copy link
Copy Markdown
Contributor

dataroaring commented Dec 5, 2024

run buildall

@doris-robot
Copy link
Copy Markdown

doris-robot commented Dec 5, 2024

TeamCity be ut coverage result:
Function Coverage: 36.73% (9615/26180)
Line Coverage: 28.12% (79075/281203)
Region Coverage: 26.77% (40581/151572)
Branch Coverage: 23.60% (20650/87500)
Coverage Report: http://coverage.selectdb-in.cc/coverage/983edb68131dbeddb5ff165863bcba2773834bbb_983edb68131dbeddb5ff165863bcba2773834bbb/report/index.html

dataroaring
dataroaring approved these changes Dec 6, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Dec 6, 2024
@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions Bot commented Dec 6, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions Bot commented Dec 6, 2024

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented Dec 9, 2024

run buildall

@doris-robot
Copy link
Copy Markdown

doris-robot commented Dec 9, 2024

TeamCity be ut coverage result:
Function Coverage: 36.49% (9557/26191)
Line Coverage: 27.92% (78522/281258)
Region Coverage: 26.59% (40313/151605)
Branch Coverage: 23.35% (20423/87474)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1b3e825c0d06205d9062ca64e14cdc5b9ad9190a_1b3e825c0d06205d9062ca64e14cdc5b9ad9190a/report/index.html

@yiguolei yiguolei merged commit a8b5125 into branch-2.1 Dec 9, 2024
@github-actions github-actions Bot deleted the auto-pick-44913-branch-2.1 branch December 9, 2024 11:21
deardeng pushed a commit to deardeng/incubator-doris that referenced this pull request Dec 19, 2025
@github-actions @sollhui @hello-stephen
branch-2.1: [fix](third party) fix hang when destroy of rdkafka insta…
b86e538 
…nces apache#44913 (apache#44951)

Cherry-picked from apache#44913

Co-authored-by: hui lai <[email protected]>
Co-authored-by: Dongyang Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@doris-robot @dataroaring @hello-stephen @yiguolei @sollhui