Repository navigation
[Enhancement] (nereids)implement showStoragePolicyCommand in nereids - #44393
Merged
Merged
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40179 ms |
TPC-DS: Total hot run time: 197673 ms |
ClickBench: Total hot run time: 33.11 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39743 ms |
TPC-DS: Total hot run time: 195937 ms |
ClickBench: Total hot run time: 32.01 s |
Contributor
Author
|
run p0 |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40140 ms |
TPC-DS: Total hot run time: 196783 ms |
ClickBench: Total hot run time: 32.86 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39951 ms |
TPC-DS: Total hot run time: 197703 ms |
ClickBench: Total hot run time: 33.13 s |
Contributor
Author
|
run buildall |
Contributor
Author
|
run P0 |
Contributor
|
pls check cases failed in p0, it seems related to changed |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40149 ms |
TPC-DS: Total hot run time: 198082 ms |
ClickBench: Total hot run time: 32.89 s |
msridhar78
force-pushed
the
show_storage_policy
branch
from
December 18, 2024 17:24
0d1d9db to
bd82857
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39550 ms |
TPC-DS: Total hot run time: 196085 ms |
ClickBench: Total hot run time: 32.87 s |
TPC-DS: Total hot run time: 195122 ms |
ClickBench: Total hot run time: 31.09 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32140 ms |
TPC-DS: Total hot run time: 187200 ms |
ClickBench: Total hot run time: 30.43 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31930 ms |
TPC-DS: Total hot run time: 190534 ms |
ClickBench: Total hot run time: 31.1 s |
starocean999
previously approved these changes
Mar 4, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
LiBinfeng-01
reviewed
Mar 4, 2025
| public LogicalPlan visitShowStoragePolicy(ShowStoragePolicyContext ctx) { | ||
| String policyName = null; | ||
| if (ctx.identifierOrText() != null) { | ||
| policyName = ctx.identifierOrText().getText(); |
Contributor
There was a problem hiding this comment.
stripQuotes(ctx.identifierOrText().getText())
Contributor
There was a problem hiding this comment.
pls use stripQuotes to avoid quote affect string behavior
Contributor
Author
There was a problem hiding this comment.
done - please review
msridhar78
force-pushed
the
show_storage_policy
branch
from
March 4, 2025 17:17
18da17b to
fbf7b9a
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31872 ms |
TPC-DS: Total hot run time: 190709 ms |
ClickBench: Total hot run time: 31.34 s |
starocean999
approved these changes
Mar 5, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
LiBinfeng-01
approved these changes
Mar 5, 2025
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #42721
Problem Summary:
[Enhancement] (nereids)implement showStoragePolicyCommand in nereids
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)