Skip to content

[fix](inverted index) base compaction failed after restore indexes - #43962

Merged
yiguolei merged 1 commit into
apache:branch-2.1from
cambyzju:pick-41625-2.1
Nov 16, 2024
Merged

[fix](inverted index) base compaction failed after restore indexes#43962
yiguolei merged 1 commit into
apache:branch-2.1from
cambyzju:pick-41625-2.1

Conversation

@cambyzju

@cambyzju cambyzju commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Problem:
after restore from other cluster, then rowsets got different index_id, and make index compaction in base compaction always failed.

Fix:
On master branch, this pr: #41625 already fix it.
Here pick it to branch-2.1

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot

doris-robot commented Nov 14, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@cambyzju

cambyzju commented Nov 14, 2024

Copy link
Copy Markdown
Contributor Author

run buildall

@cambyzju cambyzju mentioned this pull request Nov 14, 2024
Closed
@github-actions

github-actions Bot commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@cambyzju

cambyzju commented Nov 14, 2024

Copy link
Copy Markdown
Contributor Author

run buildall

@github-actions

github-actions Bot commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@cambyzju

cambyzju commented Nov 14, 2024

Copy link
Copy Markdown
Contributor Author

run buildall

@github-actions

github-actions Bot commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Nov 14, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.36% (9485/26085)
Line Coverage: 27.92% (78171/280005)
Region Coverage: 26.56% (40076/150903)
Branch Coverage: 23.34% (20348/87188)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0567141184004f2f2651ad30c1ad8edc98bb82c8_0567141184004f2f2651ad30c1ad8edc98bb82c8/report/index.html

csun5285
csun5285 approved these changes Nov 15, 2024
View reviewed changes

@csun5285 csun5285 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actions Bot commented Nov 15, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguolei
yiguolei merged commit b3022df into apache:branch-2.1 Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csun5285 csun5285 csun5285 approved these changes

Assignees

No one assigned

Labels

dev/2.1.8-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cambyzju @doris-robot @csun5285 @yiguolei