Repository navigation
[fix](cloud version) fix version of information_schema table backward when query in follower node - #43451
Merged
Conversation
|
Thank you for your contribution to Apache Doris. Check List (For Author)
Check List (For Reviewer who merge this PR)
|
sollhui
changed the title
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41062 ms |
liaoxin01
reviewed
Nov 7, 2024
TPC-DS: Total hot run time: 194389 ms |
backward when query in follower node
Contributor
Author
|
run buildall |
gavinchou
approved these changes
Nov 7, 2024
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 41367 ms |
TPC-DS: Total hot run time: 192383 ms |
ClickBench: Total hot run time: 32.72 s |
sollhui
changed the title
sollhui
changed the title
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 8, 2024
… when query in follower node (#43451) Problem Summary: For the follower node in cloud mode, when querying the information_schema table, the version needs to be updated. Otherwise, the version will always be the old value unless there is a query for the table in the follower node.
gavinchou
added
cir
and removed
approved
gavinchou
pushed a commit
that referenced
this pull request
Nov 13, 2024
…ble backward when query in follower node (#43496) Cherry-picked from #43451 Co-authored-by: hui lai <[email protected]>
HappenLee
pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
… when query in follower node (apache#43451) Problem Summary: For the follower node in cloud mode, when querying the information_schema table, the version needs to be updated. Otherwise, the version will always be the old value unless there is a query for the table in the follower node.
morningman
added a commit
to hutiefang76/doris
that referenced
this pull request
Oct 31, 2026
…r UPDATE_TIME ### What problem does this PR solve? Issue Number: None Related PR: apache#67899 Problem Summary: GetTables no longer passes its first requested type to FrontendServiceImpl.listTableStatus, so a request for VIEW only now lists every object in the database and the Flight SQL helper filters the rows. On a non-master FE in cloud mode, listTableStatus refreshes each OLAP table's partition versions from the meta service before it lists the table (apache#43451), whatever columns the caller asked for. GetTables asks for TABLE_NAME and TABLE_TYPE only, and neither reads a partition version; only UPDATE_TIME does (OlapTable.getUpdateTime() takes the partitions' visible version time). So when the cached versions on the follower have expired, every GetTables request waits on meta service RPCs for each OLAP table it lists. When the meta service keeps failing, the RpcException leaves the per-table loop for the catch around the whole enumeration, which logs a warning and returns the rows collected so far: the request succeeds without that table and every object after it, views included. Fix: refresh the partition versions only when the request needs UPDATE_TIME. A request without required_columns (an older BE) still needs every column and still refreshes, and so does an information_schema.tables scan that reads UPDATE_TIME in its projection or in a predicate. ### Release note None ### Check List (For Author) - Test: Unit Test - FrontendServiceImplTest#testListTableStatusRefreshesCloudFollowerVersionsOnlyForUpdateTime: a cloud follower whose version RPC fails lists a base table and a view for TABLE_NAME and TABLE_TYPE without calling it, and still calls it for UPDATE_TIME; without the new condition the first listing calls it and loses rows - FlightSqlSchemaHelperTableTypesTest: GetTables requests exactly TABLE_NAME and TABLE_TYPE - Behavior changed: Yes. On a non-master FE in cloud mode, listing table status fetches partition versions from the meta service only when UPDATE_TIME is requested - Does this need documentation: No Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Summary:
For the follower node in cloud mode, when querying the information_schema table, the version needs to be updated.
Otherwise, the version will always be the old value unless there is a query for the table in the follower node.
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Release note
None