Repository navigation
Masking glibc symbols for better portability - #4180
Conversation
|
Good work!
|
Oops, those are redundant. I'll get rid of the FastMemcpy folder.
Not yet in this PR, but it's doable. I've done ARM-compatible stuff for ClickHouse. I'll send another PR if this one gets accepted :) |
Thanks! |
Great! |
* Masking glibc symbols for better portability * Remove redundant files
Proposed changes
In ClickHouse we have glibc symbols masked to backport down towards CentOS 5 (glibc 2.5). It's quite useful for creating portable executables. I'd love to have this capability shipped into Doris :)
This PR contains glibc related symbols extracted from https://github.com/bminor/musl/commit/593caa456309714402ca4cb77c3770f4c24da9da . It's been verified in ClickHouse and works perfectly. I've also shipped https://github.com/skywind3000/FastMemcpy together to have a hosted memcpy implementation. Otherwise it requires [email protected] which is not available on most CentOS 6 machines.
Btw, I've also disabled libssh2 and nghttp2 when building libcurl. It somehow introduces weird dependency issues on my dev machine (gentoo). Please verify if they are indeed necessary.
After this PR, palo_be only requires glibc 2.10. Related license files are attached too.
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.