Skip to content

[CodeRefactor] #4098 Make FE multi module - #4099

Merged
morningman merged 4 commits into
apache:masterfrom
morningman:maven_module
Jul 21, 2020
Merged

morningman merged 4 commits into
apache:masterfrom
morningman:maven_module

Conversation

@morningman

@morningman morningman commented Jul 14, 2020 •

Copy link
Copy Markdown
Contributor

Proposed changes

This PR change the FE code structure to maven multi module structure. See ISSUE: #4098 for more info.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Doris's issues, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related issues ID, like "Add pull request template to doris project #4071 Add pull request template to doris project"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I have updated the document
  • Any dependent changes have been merged

@morningman morningman added the kind/refactor Issues or PRs to refactor code label Jul 14, 2020
@morningman morningman self-assigned this Jul 14, 2020

@yangzhg yangzhg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangzhg yangzhg added the approved Indicates a PR has been approved by one committer. label Jul 21, 2020
@morningman
morningman merged commit ad17afe into apache:master Jul 21, 2020
luwei16 added a commit to luwei16/Doris that referenced this pull request Jun 27, 2025
luwei16 added a commit to luwei16/Doris that referenced this pull request Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/refactor Issues or PRs to refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants