Skip to content

[opt](function)avoid virtual function calls in geo functions #37003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HappenLee merged 4 commits into from
Jul 1, 2024
Merged

[opt](function)avoid virtual function calls in geo functions #37003

HappenLee merged 4 commits into from
Jul 1, 2024

Conversation

@Mryange
Copy link
Contributor

@Mryange Mryange commented Jun 28, 2024

Proposed changes

mysql [test10]>select count(st_distance_sphere(db, db, db, db)) from double_ranges;
+-------------------------------------------+
| count(st_distance_sphere(db, db, db, db)) |
+-------------------------------------------+
|                                         0 |
+-------------------------------------------+
1 row in set (1.46 sec)



mysql [test10]>select count(st_distance_sphere(db, db, db, db)) from double_ranges;
+-------------------------------------------+
| count(st_distance_sphere(db, db, db, db)) |
+-------------------------------------------+
|                                  50000000 |
+-------------------------------------------+
1 row in set (1.14 sec)

@doris-robot
Copy link

doris-robot commented Jun 28, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Mryange
Copy link
Contributor Author

Mryange commented Jun 28, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jun 28, 2024

TPC-H: Total hot run time: 40210 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9aa616031506d15ea3ffd1367aacecb4542063a7, data reload: false

------ Round 1 ----------------------------------
q1	17585	4360	4259	4259
q2	2023	190	197	190
q3	10438	1229	1072	1072
q4	10192	858	786	786
q5	7470	2651	2624	2624
q6	220	134	135	134
q7	953	592	604	592
q8	9230	2071	2062	2062
q9	9080	6516	6461	6461
q10	8961	3715	3767	3715
q11	466	236	250	236
q12	448	231	229	229
q13	17763	2974	3028	2974
q14	252	221	219	219
q15	542	469	476	469
q16	502	375	377	375
q17	953	640	656	640
q18	8033	7481	7303	7303
q19	7740	1409	1500	1409
q20	661	340	319	319
q21	4993	3806	4004	3806
q22	396	348	336	336
Total cold run time: 118901 ms
Total hot run time: 40210 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4378	4231	4222	4222
q2	375	263	273	263
q3	3070	2936	2942	2936
q4	1979	1720	1736	1720
q5	5567	5553	5444	5444
q6	225	154	128	128
q7	2287	1860	1845	1845
q8	3306	3493	3442	3442
q9	8763	8788	8827	8788
q10	4193	3674	3803	3674
q11	606	495	514	495
q12	800	656	654	654
q13	17032	3146	3176	3146
q14	298	299	265	265
q15	524	495	489	489
q16	481	443	431	431
q17	1790	1506	1494	1494
q18	8154	7838	7897	7838
q19	1869	1454	1628	1454
q20	3272	1901	1859	1859
q21	5179	4760	5025	4760
q22	629	544	540	540
Total cold run time: 74777 ms
Total hot run time: 55887 ms

@doris-robot
Copy link

doris-robot commented Jun 28, 2024

TPC-DS: Total hot run time: 174008 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9aa616031506d15ea3ffd1367aacecb4542063a7, data reload: false

query1	925	383	379	379
query2	6443	2507	2256	2256
query3	6643	208	216	208
query4	19190	17571	17394	17394
query5	3730	468	474	468
query6	272	176	175	175
query7	4586	312	298	298
query8	302	290	295	290
query9	8657	2456	2450	2450
query10	570	304	276	276
query11	10760	10107	9998	9998
query12	115	113	86	86
query13	1649	362	359	359
query14	10074	6941	7117	6941
query15	233	182	183	182
query16	7765	273	266	266
query17	1650	551	522	522
query18	1950	287	269	269
query19	196	156	151	151
query20	87	82	81	81
query21	205	134	122	122
query22	4278	4184	3970	3970
query23	33997	33798	33634	33634
query24	10960	2847	2967	2847
query25	595	384	389	384
query26	711	154	159	154
query27	2298	345	324	324
query28	5980	2205	2181	2181
query29	920	634	615	615
query30	256	157	164	157
query31	997	803	776	776
query32	87	60	65	60
query33	721	285	285	285
query34	994	482	502	482
query35	799	661	638	638
query36	1120	972	991	972
query37	150	74	73	73
query38	2999	2826	2927	2826
query39	902	849	832	832
query40	214	125	129	125
query41	62	51	52	51
query42	109	108	102	102
query43	600	563	550	550
query44	1182	770	743	743
query45	200	164	167	164
query46	1067	726	736	726
query47	1838	1769	1773	1769
query48	362	300	294	294
query49	834	408	415	408
query50	767	384	391	384
query51	6904	6720	6771	6720
query52	99	100	94	94
query53	362	291	311	291
query54	920	449	468	449
query55	78	78	75	75
query56	304	304	280	280
query57	1130	1041	1053	1041
query58	246	247	254	247
query59	3381	3276	3306	3276
query60	314	299	291	291
query61	114	111	115	111
query62	642	456	462	456
query63	326	295	299	295
query64	8635	2327	1841	1841
query65	3200	3120	3261	3120
query66	779	340	338	338
query67	15443	14886	14960	14886
query68	8234	573	586	573
query69	641	497	448	448
query70	1307	1084	1051	1051
query71	492	284	287	284
query72	8582	4965	5717	4965
query73	1218	328	321	321
query74	5926	5524	5510	5510
query75	4113	2662	2654	2654
query76	4130	988	945	945
query77	651	307	306	306
query78	10619	9806	9790	9790
query79	8701	520	528	520
query80	1391	474	471	471
query81	514	232	217	217
query82	578	108	100	100
query83	210	171	167	167
query84	271	85	88	85
query85	1000	275	276	275
query86	390	284	306	284
query87	3341	3135	3137	3135
query88	4666	2366	2355	2355
query89	557	395	382	382
query90	1877	186	191	186
query91	126	99	99	99
query92	59	49	48	48
query93	6891	529	513	513
query94	1146	190	190	190
query95	404	317	304	304
query96	600	272	268	268
query97	3215	3042	3025	3025
query98	210	194	189	189
query99	1331	862	840	840
Total cold run time: 288269 ms
Total hot run time: 174008 ms

@doris-robot
Copy link

doris-robot commented Jun 28, 2024

ClickBench: Total hot run time: 30.4 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9aa616031506d15ea3ffd1367aacecb4542063a7, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.07	0.07
query5	0.51	0.48	0.49
query6	1.14	0.74	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.05
query9	0.56	0.50	0.48
query10	0.53	0.54	0.55
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.60	0.58	0.61
query14	0.78	0.77	0.79
query15	0.84	0.83	0.81
query16	0.37	0.37	0.37
query17	1.01	1.04	1.02
query18	0.22	0.24	0.25
query19	1.92	1.82	1.69
query20	0.01	0.02	0.01
query21	15.43	0.79	0.66
query22	4.31	7.11	1.70
query23	18.28	1.43	1.30
query24	2.08	0.24	0.21
query25	0.15	0.08	0.08
query26	0.27	0.18	0.18
query27	0.07	0.07	0.08
query28	13.19	1.02	0.99
query29	12.58	3.28	3.26
query30	0.25	0.07	0.05
query31	2.87	0.41	0.39
query32	3.24	0.47	0.47
query33	2.88	2.85	3.00
query34	17.08	4.46	4.48
query35	4.46	4.51	4.51
query36	0.66	0.46	0.48
query37	0.19	0.15	0.16
query38	0.16	0.15	0.14
query39	0.04	0.03	0.03
query40	0.17	0.15	0.13
query41	0.09	0.05	0.04
query42	0.05	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.41 s
Total hot run time: 30.4 s

@Mryange
Copy link
Contributor Author

Mryange commented Jun 30, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jun 30, 2024

TPC-H: Total hot run time: 39394 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 064915e9604f2857411521f712d4131153aed2fc, data reload: false

------ Round 1 ----------------------------------
q1	17607	4340	4247	4247
q2	2014	194	188	188
q3	10467	1177	1063	1063
q4	10203	713	834	713
q5	7504	2646	2633	2633
q6	219	138	136	136
q7	936	590	609	590
q8	9217	2057	2050	2050
q9	8751	6464	6444	6444
q10	8976	3688	3660	3660
q11	452	236	245	236
q12	477	230	228	228
q13	18025	2933	2970	2933
q14	257	218	223	218
q15	515	480	485	480
q16	522	372	371	371
q17	960	586	662	586
q18	7854	7432	7364	7364
q19	6183	1534	1493	1493
q20	651	310	331	310
q21	4898	3124	3124	3124
q22	396	327	339	327
Total cold run time: 117084 ms
Total hot run time: 39394 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4379	4209	4234	4209
q2	367	278	265	265
q3	2932	2684	2933	2684
q4	1971	1740	1685	1685
q5	5592	5493	5457	5457
q6	220	130	133	130
q7	2142	1800	1883	1800
q8	3288	3395	3419	3395
q9	8691	8656	8789	8656
q10	4083	3959	3722	3722
q11	566	473	481	473
q12	790	655	647	647
q13	17000	3174	3167	3167
q14	307	304	280	280
q15	526	493	482	482
q16	489	438	435	435
q17	1800	1515	1472	1472
q18	8185	7747	7765	7747
q19	1808	1592	1696	1592
q20	2144	1883	1873	1873
q21	10039	5006	4841	4841
q22	608	550	553	550
Total cold run time: 77927 ms
Total hot run time: 55562 ms

@doris-robot
Copy link

doris-robot commented Jun 30, 2024

TPC-DS: Total hot run time: 175346 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 064915e9604f2857411521f712d4131153aed2fc, data reload: false

query1	902	380	377	377
query2	6588	2358	2189	2189
query3	6619	208	217	208
query4	19036	17475	17433	17433
query5	3631	482	460	460
query6	245	173	172	172
query7	4584	292	286	286
query8	297	288	302	288
query9	8655	2434	2427	2427
query10	593	303	295	295
query11	10652	10075	10156	10075
query12	117	84	81	81
query13	1643	371	366	366
query14	10268	7729	7661	7661
query15	277	194	196	194
query16	7959	272	271	271
query17	1897	565	550	550
query18	1917	280	278	278
query19	194	151	159	151
query20	90	83	84	83
query21	207	132	125	125
query22	4487	4240	4170	4170
query23	33958	33785	33594	33594
query24	10715	3026	3019	3019
query25	602	399	396	396
query26	703	166	164	164
query27	2200	324	333	324
query28	6301	2172	2165	2165
query29	934	636	654	636
query30	257	155	159	155
query31	998	773	751	751
query32	96	56	57	56
query33	674	312	298	298
query34	876	483	488	483
query35	760	649	635	635
query36	1197	1009	937	937
query37	147	75	72	72
query38	2965	2886	2824	2824
query39	913	849	845	845
query40	211	132	132	132
query41	55	54	56	54
query42	123	101	104	101
query43	591	552	556	552
query44	1064	758	745	745
query45	193	169	172	169
query46	1075	748	744	744
query47	1868	1795	1848	1795
query48	366	303	290	290
query49	837	415	409	409
query50	767	375	383	375
query51	6879	6721	6723	6721
query52	97	93	104	93
query53	366	301	288	288
query54	884	443	434	434
query55	73	73	71	71
query56	269	248	256	248
query57	1153	1089	1029	1029
query58	260	244	234	234
query59	3419	3155	3120	3120
query60	294	281	301	281
query61	92	92	88	88
query62	613	431	444	431
query63	316	289	285	285
query64	8715	2283	1752	1752
query65	3197	3127	3090	3090
query66	745	328	334	328
query67	15584	14980	15156	14980
query68	8302	551	557	551
query69	666	532	460	460
query70	1234	1093	1110	1093
query71	497	276	274	274
query72	9244	5553	5529	5529
query73	1228	327	315	315
query74	5857	5480	5506	5480
query75	4686	2699	2629	2629
query76	4807	1028	969	969
query77	776	302	296	296
query78	10432	9810	9825	9810
query79	8570	525	521	521
query80	1036	473	465	465
query81	559	224	228	224
query82	760	107	107	107
query83	339	170	166	166
query84	275	85	83	83
query85	1273	278	263	263
query86	404	311	301	301
query87	3322	3133	3092	3092
query88	4832	2347	2391	2347
query89	548	387	380	380
query90	1831	183	190	183
query91	166	97	97	97
query92	61	48	48	48
query93	6182	518	510	510
query94	1109	188	182	182
query95	401	309	316	309
query96	617	275	261	261
query97	3251	3031	3043	3031
query98	215	200	193	193
query99	1192	850	844	844
Total cold run time: 289932 ms
Total hot run time: 175346 ms

@doris-robot
Copy link

doris-robot commented Jun 30, 2024

ClickBench: Total hot run time: 30.82 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 064915e9604f2857411521f712d4131153aed2fc, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.23	0.06	0.06
query4	1.68	0.09	0.08
query5	0.50	0.49	0.48
query6	1.14	0.73	0.72
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.56	0.49	0.49
query10	0.54	0.55	0.54
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.59	0.59	0.61
query14	0.76	0.79	0.77
query15	0.85	0.82	0.81
query16	0.37	0.38	0.35
query17	1.00	0.99	0.96
query18	0.25	0.25	0.20
query19	1.80	1.69	1.67
query20	0.02	0.01	0.00
query21	15.43	0.75	0.66
query22	4.06	7.42	2.30
query23	18.30	1.40	1.24
query24	2.21	0.23	0.22
query25	0.16	0.08	0.09
query26	0.27	0.18	0.17
query27	0.08	0.07	0.08
query28	13.18	1.01	0.99
query29	12.61	3.39	3.36
query30	0.25	0.07	0.05
query31	2.90	0.39	0.39
query32	3.25	0.47	0.48
query33	2.86	2.86	2.90
query34	17.12	4.44	4.43
query35	4.49	4.47	4.41
query36	0.65	0.46	0.47
query37	0.18	0.16	0.15
query38	0.16	0.15	0.14
query39	0.04	0.03	0.04
query40	0.17	0.14	0.14
query41	0.09	0.05	0.05
query42	0.06	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.35 s
Total hot run time: 30.82 s

@Mryange
Copy link
Contributor Author

Mryange commented Jun 30, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jun 30, 2024

TPC-H: Total hot run time: 40114 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 197469204ed77f70569085ea9093a893c1fa0dc0, data reload: false

------ Round 1 ----------------------------------
q1	18162	4434	4366	4366
q2	2714	206	201	201
q3	10979	1265	1191	1191
q4	11141	860	749	749
q5	7643	2691	2689	2689
q6	226	141	139	139
q7	974	610	619	610
q8	9607	2077	2076	2076
q9	8873	6477	6441	6441
q10	9073	3720	3758	3720
q11	452	247	246	246
q12	408	237	234	234
q13	17782	2955	2993	2955
q14	259	221	225	221
q15	511	479	473	473
q16	520	386	384	384
q17	964	681	682	681
q18	8024	7520	7369	7369
q19	5473	1358	1423	1358
q20	671	340	339	339
q21	5017	3334	3893	3334
q22	391	338	346	338
Total cold run time: 119864 ms
Total hot run time: 40114 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4460	4275	4225	4225
q2	367	260	271	260
q3	2978	2782	2775	2775
q4	1893	1613	1663	1613
q5	5259	5316	5308	5308
q6	218	130	132	130
q7	2147	1777	1700	1700
q8	3186	3348	3309	3309
q9	8373	8345	8366	8345
q10	3896	3747	3712	3712
q11	582	498	509	498
q12	806	618	600	600
q13	16481	3005	2985	2985
q14	298	270	256	256
q15	524	482	480	480
q16	459	415	423	415
q17	1773	1499	1443	1443
q18	7690	7527	7381	7381
q19	1733	1688	1563	1563
q20	2005	1786	1755	1755
q21	4955	4883	4750	4750
q22	646	561	563	561
Total cold run time: 70729 ms
Total hot run time: 54064 ms

@doris-robot
Copy link

doris-robot commented Jun 30, 2024

TPC-DS: Total hot run time: 169963 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 197469204ed77f70569085ea9093a893c1fa0dc0, data reload: false

query1	925	393	370	370
query2	6468	2349	2340	2340
query3	6656	211	226	211
query4	19333	17294	17052	17052
query5	4191	520	510	510
query6	300	188	180	180
query7	4598	295	301	295
query8	306	289	284	284
query9	8784	2447	2412	2412
query10	586	294	294	294
query11	10549	10108	9928	9928
query12	138	93	85	85
query13	1647	376	376	376
query14	10401	7753	6427	6427
query15	246	193	192	192
query16	8072	270	265	265
query17	1900	553	549	549
query18	2085	281	282	281
query19	203	166	163	163
query20	92	93	90	90
query21	212	136	133	133
query22	4227	3969	3941	3941
query23	33793	33078	33183	33078
query24	11238	2901	2866	2866
query25	649	387	402	387
query26	1597	157	158	157
query27	2953	322	319	319
query28	7586	2089	2086	2086
query29	1001	657	631	631
query30	289	160	163	160
query31	974	752	758	752
query32	103	57	58	57
query33	794	304	313	304
query34	904	472	498	472
query35	777	643	631	631
query36	1071	945	933	933
query37	161	74	72	72
query38	2936	2771	2780	2771
query39	849	798	801	798
query40	281	136	132	132
query41	58	55	53	53
query42	131	103	106	103
query43	602	523	554	523
query44	1295	743	742	742
query45	197	167	166	166
query46	1088	735	764	735
query47	1838	1744	1776	1744
query48	389	303	301	301
query49	1201	441	431	431
query50	777	393	404	393
query51	6832	6777	6836	6777
query52	115	98	98	98
query53	358	304	308	304
query54	1007	472	546	472
query55	75	73	77	73
query56	297	260	270	260
query57	1146	1077	1032	1032
query58	267	261	247	247
query59	3348	3005	3131	3005
query60	312	276	280	276
query61	93	94	93	93
query62	686	449	451	449
query63	324	301	303	301
query64	9911	2254	1733	1733
query65	3168	3108	3116	3108
query66	1351	361	348	348
query67	15525	14833	14846	14833
query68	8757	572	581	572
query69	714	489	403	403
query70	1335	1094	1123	1094
query71	512	281	274	274
query72	8555	4016	2600	2600
query73	1992	327	328	327
query74	5968	5572	5556	5556
query75	5210	2714	2695	2695
query76	5022	1071	926	926
query77	773	310	318	310
query78	10772	9982	9886	9886
query79	7018	536	535	535
query80	950	488	496	488
query81	550	220	226	220
query82	773	109	108	108
query83	351	176	172	172
query84	270	86	92	86
query85	1296	293	310	293
query86	418	308	313	308
query87	3282	3056	3076	3056
query88	4432	2371	2376	2371
query89	522	402	395	395
query90	2015	197	193	193
query91	129	100	106	100
query92	61	51	49	49
query93	5395	536	528	528
query94	1226	200	198	198
query95	407	320	327	320
query96	645	269	268	268
query97	3227	3090	3021	3021
query98	219	198	191	191
query99	1205	849	836	836
Total cold run time: 296267 ms
Total hot run time: 169963 ms

@doris-robot
Copy link

doris-robot commented Jun 30, 2024

ClickBench: Total hot run time: 30.49 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 197469204ed77f70569085ea9093a893c1fa0dc0, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.22	0.06	0.05
query4	1.65	0.09	0.08
query5	0.49	0.48	0.48
query6	1.14	0.71	0.73
query7	0.02	0.02	0.01
query8	0.05	0.05	0.05
query9	0.56	0.49	0.50
query10	0.55	0.53	0.53
query11	0.15	0.11	0.12
query12	0.14	0.12	0.13
query13	0.59	0.58	0.60
query14	0.78	0.80	0.77
query15	0.84	0.82	0.80
query16	0.35	0.36	0.37
query17	1.02	1.02	0.98
query18	0.21	0.26	0.24
query19	1.90	1.76	1.69
query20	0.02	0.01	0.01
query21	15.44	0.76	0.65
query22	4.11	7.76	1.88
query23	18.29	1.35	1.27
query24	2.06	0.23	0.22
query25	0.16	0.09	0.09
query26	0.25	0.17	0.17
query27	0.08	0.08	0.08
query28	13.22	1.03	1.00
query29	12.56	3.29	3.26
query30	0.26	0.06	0.06
query31	2.88	0.39	0.39
query32	3.25	0.47	0.47
query33	2.89	2.88	2.96
query34	17.14	4.44	4.38
query35	4.52	4.51	4.51
query36	0.66	0.46	0.49
query37	0.18	0.15	0.16
query38	0.15	0.14	0.14
query39	0.04	0.03	0.04
query40	0.17	0.14	0.13
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.31 s
Total hot run time: 30.49 s

@Mryange
Copy link
Contributor Author

Mryange commented Jun 30, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Jun 30, 2024

TPC-H: Total hot run time: 40102 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 34cfaf7c44305fec2b8e9237913b2422e5e821dd, data reload: false

------ Round 1 ----------------------------------
q1	17615	4350	4312	4312
q2	2015	203	198	198
q3	10958	1384	1172	1172
q4	10554	767	829	767
q5	7931	2665	2777	2665
q6	225	141	140	140
q7	964	617	629	617
q8	9522	2091	2098	2091
q9	8982	6620	6572	6572
q10	9250	3683	3721	3683
q11	465	233	240	233
q12	515	240	233	233
q13	18784	2988	2992	2988
q14	266	218	231	218
q15	526	486	488	486
q16	521	382	381	381
q17	959	667	630	630
q18	7966	7557	7407	7407
q19	3779	1412	1439	1412
q20	658	327	323	323
q21	4998	3236	3845	3236
q22	406	338	348	338
Total cold run time: 117859 ms
Total hot run time: 40102 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4414	4393	4221	4221
q2	383	269	277	269
q3	3017	2784	2938	2784
q4	1971	1799	1737	1737
q5	5530	5553	5484	5484
q6	235	134	135	134
q7	2227	1863	1837	1837
q8	3295	3463	3481	3463
q9	8752	8628	8749	8628
q10	4100	3878	3786	3786
q11	588	516	505	505
q12	818	627	626	626
q13	17606	3180	3230	3180
q14	323	267	276	267
q15	538	478	495	478
q16	518	437	456	437
q17	1833	1538	1527	1527
q18	8157	7985	7785	7785
q19	1802	1671	1631	1631
q20	2114	1804	1793	1793
q21	5064	4941	4948	4941
q22	641	553	584	553
Total cold run time: 73926 ms
Total hot run time: 56066 ms

@doris-robot
Copy link

doris-robot commented Jun 30, 2024

TPC-DS: Total hot run time: 174040 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 34cfaf7c44305fec2b8e9237913b2422e5e821dd, data reload: false

query1	936	386	382	382
query2	6354	2564	2500	2500
query3	6639	204	213	204
query4	18785	17646	17228	17228
query5	3698	494	481	481
query6	256	167	171	167
query7	4701	296	302	296
query8	321	286	297	286
query9	8752	2415	2392	2392
query10	572	315	291	291
query11	10481	10086	10027	10027
query12	136	93	84	84
query13	1645	370	373	370
query14	10064	7017	6897	6897
query15	221	187	194	187
query16	7765	275	265	265
query17	1748	537	541	537
query18	1945	274	276	274
query19	190	149	166	149
query20	96	82	88	82
query21	213	125	124	124
query22	4357	4076	3957	3957
query23	33826	33653	33576	33576
query24	11965	3053	2927	2927
query25	688	386	378	378
query26	1823	157	163	157
query27	2996	335	325	325
query28	7627	2149	2142	2142
query29	1118	628	646	628
query30	271	160	153	153
query31	936	747	734	734
query32	90	54	57	54
query33	755	298	290	290
query34	1009	475	500	475
query35	760	643	644	643
query36	1143	965	990	965
query37	296	84	71	71
query38	2924	2832	2817	2817
query39	900	859	837	837
query40	262	131	129	129
query41	60	54	52	52
query42	115	105	101	101
query43	622	566	576	566
query44	1204	726	751	726
query45	190	162	165	162
query46	1081	760	723	723
query47	1842	1778	1767	1767
query48	380	305	327	305
query49	947	409	413	409
query50	776	392	393	392
query51	6866	6813	6819	6813
query52	102	99	95	95
query53	374	302	293	293
query54	886	452	447	447
query55	74	75	75	75
query56	286	261	266	261
query57	1131	1020	1026	1020
query58	260	239	249	239
query59	3770	3334	3416	3334
query60	311	288	291	288
query61	94	92	92	92
query62	595	447	437	437
query63	324	299	295	295
query64	9727	2314	1767	1767
query65	3174	3097	3106	3097
query66	1262	325	321	321
query67	15457	15185	14823	14823
query68	6059	544	565	544
query69	597	428	396	396
query70	1184	1062	1149	1062
query71	459	282	277	277
query72	7515	5301	5791	5301
query73	781	325	326	325
query74	5989	5597	5471	5471
query75	3827	2643	2646	2643
query76	3793	1016	976	976
query77	584	320	306	306
query78	10526	10036	9740	9740
query79	2119	516	528	516
query80	809	489	479	479
query81	592	226	222	222
query82	1440	108	109	108
query83	264	171	173	171
query84	244	88	84	84
query85	1427	285	274	274
query86	473	310	300	300
query87	3270	3047	3066	3047
query88	4034	2372	2352	2352
query89	486	397	390	390
query90	1778	190	189	189
query91	133	103	100	100
query92	67	53	52	52
query93	2187	526	526	526
query94	1116	194	190	190
query95	407	323	315	315
query96	592	278	265	265
query97	3260	3029	3032	3029
query98	213	210	194	194
query99	1099	849	815	815
Total cold run time: 278498 ms
Total hot run time: 174040 ms

@doris-robot
Copy link

doris-robot commented Jun 30, 2024

ClickBench: Total hot run time: 31.1 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 34cfaf7c44305fec2b8e9237913b2422e5e821dd, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.05	0.04
query3	0.22	0.05	0.05
query4	1.68	0.08	0.08
query5	0.50	0.49	0.50
query6	1.14	0.72	0.72
query7	0.02	0.02	0.02
query8	0.05	0.05	0.05
query9	0.55	0.50	0.49
query10	0.54	0.55	0.54
query11	0.15	0.12	0.12
query12	0.15	0.12	0.12
query13	0.60	0.59	0.60
query14	0.79	0.78	0.80
query15	0.85	0.83	0.81
query16	0.36	0.34	0.38
query17	1.00	0.94	1.01
query18	0.21	0.25	0.23
query19	1.77	1.72	1.69
query20	0.01	0.00	0.00
query21	15.46	0.76	0.65
query22	4.42	7.28	2.29
query23	19.21	1.44	1.28
query24	2.17	0.23	0.22
query25	0.16	0.08	0.09
query26	0.26	0.18	0.18
query27	0.07	0.07	0.09
query28	13.24	1.02	1.00
query29	12.67	3.37	3.35
query30	0.26	0.07	0.06
query31	2.86	0.38	0.39
query32	3.28	0.48	0.48
query33	2.91	2.95	2.94
query34	17.01	4.45	4.46
query35	4.52	4.46	4.45
query36	0.64	0.50	0.49
query37	0.18	0.16	0.16
query38	0.16	0.14	0.16
query39	0.05	0.03	0.04
query40	0.18	0.14	0.14
query41	0.08	0.05	0.05
query42	0.05	0.05	0.04
query43	0.05	0.04	0.05
Total cold run time: 110.6 s
Total hot run time: 31.1 s

@Mryange
Copy link
Contributor Author

Mryange commented Jun 30, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jun 30, 2024

TPC-H: Total hot run time: 39905 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7d87f9c2a929422d623a238213d68e82cb3dc13e, data reload: false

------ Round 1 ----------------------------------
q1	17617	4320	4338	4320
q2	2025	200	205	200
q3	10433	1143	1104	1104
q4	10185	819	873	819
q5	7482	2675	2662	2662
q6	226	139	143	139
q7	954	612	620	612
q8	9237	2078	2063	2063
q9	9117	6482	6488	6482
q10	8931	3711	3701	3701
q11	455	240	237	237
q12	447	237	243	237
q13	18000	2964	2980	2964
q14	259	226	235	226
q15	530	481	488	481
q16	523	369	372	369
q17	961	630	661	630
q18	8042	7407	7447	7407
q19	4384	1553	1439	1439
q20	665	332	338	332
q21	4861	3147	3344	3147
q22	394	338	334	334
Total cold run time: 115728 ms
Total hot run time: 39905 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4407	4237	4189	4189
q2	373	284	262	262
q3	2953	2777	2869	2777
q4	1980	1668	1637	1637
q5	5557	5587	5478	5478
q6	228	142	141	141
q7	2222	1825	1904	1825
q8	3269	3390	3391	3390
q9	8768	8647	8805	8647
q10	4066	3952	3789	3789
q11	580	492	491	491
q12	836	698	664	664
q13	16124	3158	3193	3158
q14	298	283	295	283
q15	531	481	492	481
q16	496	462	438	438
q17	1829	1509	1505	1505
q18	8188	8083	7773	7773
q19	1786	1673	1628	1628
q20	2179	1920	1858	1858
q21	12600	4879	4860	4860
q22	644	563	554	554
Total cold run time: 79914 ms
Total hot run time: 55828 ms

@doris-robot
Copy link

doris-robot commented Jun 30, 2024

TPC-DS: Total hot run time: 173006 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7d87f9c2a929422d623a238213d68e82cb3dc13e, data reload: false

query1	917	387	375	375
query2	6459	2405	2424	2405
query3	6640	207	218	207
query4	19500	17535	17421	17421
query5	3613	487	477	477
query6	249	169	192	169
query7	4585	284	281	281
query8	292	293	286	286
query9	8560	2373	2361	2361
query10	570	303	270	270
query11	10527	10015	10066	10015
query12	119	92	82	82
query13	1647	362	359	359
query14	10161	6265	6934	6265
query15	239	190	191	190
query16	7141	269	273	269
query17	1004	568	545	545
query18	1935	281	274	274
query19	200	157	152	152
query20	87	82	82	82
query21	214	134	128	128
query22	4559	4051	4049	4049
query23	33832	33641	33532	33532
query24	11093	2857	2876	2857
query25	641	410	407	407
query26	716	159	158	158
query27	2368	322	348	322
query28	6071	2157	2123	2123
query29	920	673	675	673
query30	270	166	157	157
query31	1016	779	767	767
query32	107	56	61	56
query33	686	311	301	301
query34	860	488	483	483
query35	823	647	648	647
query36	1127	962	975	962
query37	135	75	82	75
query38	2912	2800	2821	2800
query39	931	822	856	822
query40	209	128	130	128
query41	54	55	55	55
query42	121	100	103	100
query43	615	572	561	561
query44	1095	746	721	721
query45	186	162	166	162
query46	1063	735	696	696
query47	1839	1755	1777	1755
query48	368	319	311	311
query49	854	408	401	401
query50	760	379	374	374
query51	6841	6737	6731	6731
query52	104	91	97	91
query53	349	291	291	291
query54	876	436	438	436
query55	73	72	72	72
query56	278	256	258	256
query57	1083	1022	1049	1022
query58	240	253	244	244
query59	3325	3168	3251	3168
query60	315	265	279	265
query61	91	86	88	86
query62	599	453	424	424
query63	317	286	292	286
query64	8492	2266	1727	1727
query65	3129	3085	3114	3085
query66	846	327	326	326
query67	15522	14870	14897	14870
query68	6532	545	532	532
query69	716	428	328	328
query70	1104	1110	1141	1110
query71	473	275	275	275
query72	8788	5334	5404	5334
query73	810	325	320	320
query74	5893	5581	5457	5457
query75	4724	2651	2650	2650
query76	4389	924	936	924
query77	792	302	299	299
query78	10566	10022	9765	9765
query79	4300	525	506	506
query80	2256	467	469	467
query81	550	219	222	219
query82	804	111	110	110
query83	282	171	176	171
query84	270	93	81	81
query85	1280	287	267	267
query86	452	312	365	312
query87	3258	3068	3055	3055
query88	4792	2371	2368	2368
query89	492	372	384	372
query90	1871	185	188	185
query91	136	99	107	99
query92	60	50	52	50
query93	5437	505	511	505
query94	1224	185	194	185
query95	399	321	316	316
query96	617	269	268	268
query97	3235	3027	2993	2993
query98	220	200	199	199
query99	1162	841	836	836
Total cold run time: 281254 ms
Total hot run time: 173006 ms

@doris-robot
Copy link

doris-robot commented Jun 30, 2024

ClickBench: Total hot run time: 30.88 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7d87f9c2a929422d623a238213d68e82cb3dc13e, data reload: false

query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.07	0.08
query5	0.51	0.49	0.48
query6	1.14	0.72	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.57	0.51	0.50
query10	0.54	0.54	0.53
query11	0.16	0.12	0.12
query12	0.15	0.11	0.12
query13	0.59	0.59	0.60
query14	0.77	0.79	0.79
query15	0.85	0.81	0.80
query16	0.37	0.35	0.37
query17	1.03	1.04	1.02
query18	0.23	0.24	0.25
query19	1.82	1.71	1.67
query20	0.01	0.01	0.01
query21	15.43	0.75	0.66
query22	4.03	7.20	2.26
query23	18.23	1.37	1.20
query24	2.08	0.23	0.22
query25	0.17	0.08	0.09
query26	0.27	0.17	0.18
query27	0.08	0.08	0.09
query28	13.24	1.01	1.00
query29	12.65	3.40	3.38
query30	0.25	0.07	0.06
query31	2.86	0.39	0.38
query32	3.29	0.47	0.47
query33	2.89	2.95	2.91
query34	16.83	4.34	4.41
query35	4.49	4.51	4.46
query36	0.66	0.47	0.46
query37	0.18	0.16	0.15
query38	0.15	0.15	0.14
query39	0.04	0.03	0.04
query40	0.17	0.14	0.14
query41	0.09	0.05	0.04
query42	0.06	0.04	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.01 s
Total hot run time: 30.88 s

HappenLee
HappenLee approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 1, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024

PR approved by anyone and no changes requested.

@HappenLee HappenLee merged commit 444f96a into apache:master Jul 1, 2024
dataroaring pushed a commit that referenced this pull request Jul 2, 2024
@Mryange @dataroaring
[opt](function)avoid virtual function calls in geo functions (#37003)
9d61beb
linrrzqqq pushed a commit to linrrzqqq/doris that referenced this pull request Apr 15, 2025
@Mryange @linrrzqqq
[opt](function)avoid virtual function calls in geo functions (apache#…
2197142 
…37003)
@linrrzqqq linrrzqqq mentioned this pull request Apr 15, 2025
Merged
linrrzqqq pushed a commit to linrrzqqq/doris that referenced this pull request Apr 16, 2025
@Mryange @linrrzqqq
[opt](function)avoid virtual function calls in geo functions (apache#…
90464b6 
…37003)
yiguolei pushed a commit that referenced this pull request Apr 17, 2025
@linrrzqqq @Mryange @koi2000
branch-2.1: [Enhancement](GEO) Support Multipolygon and some spatial …
ea29bc5 
…functions (#50073)

pick: #37003,
#48695 and
#49665

---------

Co-authored-by: Mryange <[email protected]>
Co-authored-by: koi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

@zhangstar333 zhangstar333 zhangstar333 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.10-merged dev/3.0.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Mryange @doris-robot @HappenLee @zhangstar333 @yiguolei @dataroaring