Skip to content

[feature](insert)support external hive truncate table DDL - #36801

Merged
morningman merged 6 commits into
apache:masterfrom
wsjz:hive_truncate
Jun 28, 2024
Merged

[feature](insert)support external hive truncate table DDL#36801
morningman merged 6 commits into
apache:masterfrom
wsjz:hive_truncate

Conversation

@wsjz

@wsjz wsjz commented Jun 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: #31442

  1. support hive3 'truncate table'
  2. forbiden hive2 'truncate table' because of it is not supported by HMS Client API on hive2

@doris-robot

doris-robot commented Jun 25, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@wsjz
wsjz marked this pull request as ready for review June 25, 2024 12:37
@wsjz

wsjz commented Jun 25, 2024

Copy link
Copy Markdown
Contributor Author

run buildall

1 similar comment
@wsjz

wsjz commented Jun 25, 2024

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

doris-robot commented Jun 25, 2024

Copy link
Copy Markdown
TPC-H: Total hot run time: 40202 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fc9d461a4d5e012c09b00b71906d2bb7de8bc361, data reload: false

------ Round 1 ----------------------------------
q1	18058	4479	4393	4393
q2	2557	193	192	192
q3	11062	1159	1160	1159
q4	10588	806	816	806
q5	7824	2715	2677	2677
q6	219	133	133	133
q7	950	610	604	604
q8	9319	2115	2102	2102
q9	8884	6494	6454	6454
q10	8997	3735	3689	3689
q11	470	236	233	233
q12	394	230	223	223
q13	17756	2983	2999	2983
q14	263	218	228	218
q15	512	482	477	477
q16	512	367	380	367
q17	956	663	697	663
q18	8056	7528	7506	7506
q19	4745	1482	1478	1478
q20	655	311	304	304
q21	4903	3202	3926	3202
q22	407	339	346	339
Total cold run time: 118087 ms
Total hot run time: 40202 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4363	4262	4210	4210
q2	377	255	263	255
q3	2969	2793	2750	2750
q4	1884	1592	1603	1592
q5	5245	5275	5272	5272
q6	216	124	125	124
q7	2153	1701	1767	1701
q8	3178	3333	3328	3328
q9	8327	8360	8330	8330
q10	3831	3647	3657	3647
q11	582	506	490	490
q12	778	609	623	609
q13	16591	2992	2993	2992
q14	280	268	260	260
q15	518	485	489	485
q16	461	416	410	410
q17	1759	1458	1448	1448
q18	7604	7649	7360	7360
q19	1712	1561	1655	1561
q20	1981	1780	1788	1780
q21	4755	4651	4701	4651
q22	646	583	533	533
Total cold run time: 70210 ms
Total hot run time: 53788 ms

@doris-robot

doris-robot commented Jun 25, 2024

Copy link
Copy Markdown
TPC-DS: Total hot run time: 173348 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fc9d461a4d5e012c09b00b71906d2bb7de8bc361, data reload: false

query1	923	368	381	368
query2	6434	2371	2444	2371
query3	6640	205	210	205
query4	18879	17424	17343	17343
query5	4123	470	486	470
query6	247	164	180	164
query7	4589	307	287	287
query8	314	289	288	288
query9	8572	2400	2402	2400
query10	592	307	268	268
query11	10577	10072	10093	10072
query12	136	85	82	82
query13	1631	377	363	363
query14	10257	7408	7776	7408
query15	275	190	195	190
query16	8131	269	271	269
query17	1914	526	535	526
query18	2046	277	275	275
query19	197	154	156	154
query20	88	82	80	80
query21	208	126	124	124
query22	4287	4270	3897	3897
query23	33688	33085	33135	33085
query24	12004	2881	2875	2875
query25	632	360	352	352
query26	1690	151	150	150
query27	3002	317	312	312
query28	7489	2105	2102	2102
query29	1032	604	608	604
query30	289	153	154	153
query31	965	719	795	719
query32	99	55	56	55
query33	772	278	287	278
query34	982	460	488	460
query35	736	602	594	594
query36	1110	925	936	925
query37	210	74	73	73
query38	2849	2790	2733	2733
query39	840	803	806	803
query40	281	133	127	127
query41	60	53	54	53
query42	124	98	108	98
query43	574	559	563	559
query44	1213	737	766	737
query45	199	169	168	168
query46	1074	713	731	713
query47	1889	1813	1745	1745
query48	363	298	302	298
query49	1213	413	409	409
query50	775	393	385	385
query51	6919	6693	6788	6693
query52	109	90	97	90
query53	357	283	288	283
query54	1111	463	440	440
query55	74	74	76	74
query56	292	265	280	265
query57	1133	1063	1076	1063
query58	250	285	279	279
query59	3385	3218	3235	3218
query60	310	291	285	285
query61	93	90	94	90
query62	630	460	455	455
query63	325	290	288	288
query64	9867	2284	1780	1780
query65	3152	3129	3131	3129
query66	1358	349	333	333
query67	15325	14927	14765	14765
query68	4674	541	534	534
query69	526	418	399	399
query70	1176	1056	1177	1056
query71	396	284	286	284
query72	7188	5808	5306	5306
query73	776	326	327	326
query74	5904	5470	5443	5443
query75	3393	2702	2650	2650
query76	2835	978	953	953
query77	462	302	308	302
query78	10387	9812	9751	9751
query79	2416	529	512	512
query80	855	519	472	472
query81	578	225	224	224
query82	877	106	108	106
query83	263	172	178	172
query84	229	84	86	84
query85	1562	286	270	270
query86	481	314	314	314
query87	3250	3072	3050	3050
query88	4333	2362	2355	2355
query89	461	376	377	376
query90	1801	191	192	191
query91	127	98	103	98
query92	64	51	49	49
query93	1958	517	517	517
query94	1203	189	192	189
query95	404	325	314	314
query96	582	270	277	270
query97	3283	3039	3054	3039
query98	225	207	200	200
query99	1306	855	843	843
Total cold run time: 275879 ms
Total hot run time: 173348 ms

@doris-robot

doris-robot commented Jun 25, 2024

Copy link
Copy Markdown
ClickBench: Total hot run time: 30.98 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fc9d461a4d5e012c09b00b71906d2bb7de8bc361, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.08	0.08
query5	0.49	0.50	0.49
query6	1.15	0.73	0.73
query7	0.01	0.01	0.01
query8	0.04	0.04	0.04
query9	0.55	0.49	0.49
query10	0.53	0.53	0.55
query11	0.16	0.11	0.12
query12	0.14	0.11	0.13
query13	0.59	0.59	0.59
query14	0.78	0.77	0.78
query15	0.83	0.81	0.82
query16	0.37	0.37	0.37
query17	1.03	1.02	0.98
query18	0.22	0.25	0.22
query19	1.84	1.74	1.81
query20	0.01	0.02	0.01
query21	15.44	0.66	0.65
query22	4.25	6.54	2.31
query23	18.28	1.31	1.30
query24	2.08	0.23	0.22
query25	0.17	0.09	0.08
query26	0.25	0.18	0.17
query27	0.07	0.08	0.08
query28	13.24	1.01	1.03
query29	12.63	3.28	3.29
query30	0.26	0.06	0.06
query31	2.88	0.39	0.39
query32	3.26	0.47	0.47
query33	2.94	2.89	2.92
query34	17.20	4.38	4.42
query35	4.53	4.46	4.44
query36	0.65	0.47	0.47
query37	0.18	0.15	0.15
query38	0.15	0.15	0.14
query39	0.05	0.03	0.04
query40	0.18	0.14	0.15
query41	0.11	0.04	0.05
query42	0.06	0.04	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.66 s
Total hot run time: 30.98 s

@wsjz

wsjz commented Jun 25, 2024

Copy link
Copy Markdown
Contributor Author

run external

@wsjz

wsjz commented Jun 26, 2024

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

doris-robot commented Jun 26, 2024

Copy link
Copy Markdown
TPC-H: Total hot run time: 39452 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9523de300a36c088e1804f9d6779942c0c11cdee, data reload: false

------ Round 1 ----------------------------------
q1	17593	4402	4227	4227
q2	2008	186	182	182
q3	10476	1125	1065	1065
q4	10185	815	785	785
q5	7420	2660	2580	2580
q6	214	132	135	132
q7	956	582	618	582
q8	9227	2044	2034	2034
q9	8860	6487	6448	6448
q10	8960	3724	3697	3697
q11	490	240	238	238
q12	442	240	233	233
q13	17766	2954	2977	2954
q14	263	227	217	217
q15	535	467	494	467
q16	521	378	374	374
q17	958	681	676	676
q18	7928	7369	7470	7369
q19	4827	1489	1442	1442
q20	668	318	348	318
q21	4835	3095	3918	3095
q22	404	339	337	337
Total cold run time: 115536 ms
Total hot run time: 39452 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4421	4202	4269	4202
q2	356	270	267	267
q3	3029	2738	2906	2738
q4	1963	1690	1641	1641
q5	5584	5518	5552	5518
q6	223	130	130	130
q7	2221	1878	1901	1878
q8	3285	3401	3365	3365
q9	8755	8652	8851	8652
q10	4034	3926	3684	3684
q11	620	515	510	510
q12	840	681	640	640
q13	17413	3162	3178	3162
q14	305	283	274	274
q15	540	486	491	486
q16	502	430	454	430
q17	1798	1493	1493	1493
q18	8078	8278	8053	8053
q19	2429	1536	1640	1536
q20	2192	1895	1895	1895
q21	5171	4599	4933	4599
q22	639	546	578	546
Total cold run time: 74398 ms
Total hot run time: 55699 ms

@doris-robot

doris-robot commented Jun 26, 2024

Copy link
Copy Markdown
TPC-DS: Total hot run time: 174348 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9523de300a36c088e1804f9d6779942c0c11cdee, data reload: false

query1	927	396	374	374
query2	6383	2435	2282	2282
query3	6631	204	223	204
query4	19927	17252	17256	17252
query5	3595	473	480	473
query6	243	165	162	162
query7	4583	301	292	292
query8	309	306	294	294
query9	8616	2408	2398	2398
query10	565	296	274	274
query11	10500	10107	10038	10038
query12	114	88	83	83
query13	1636	383	380	380
query14	10157	6986	7389	6986
query15	232	187	187	187
query16	7765	279	275	275
query17	1886	551	531	531
query18	1966	296	283	283
query19	205	160	164	160
query20	96	86	84	84
query21	206	127	125	125
query22	4453	4237	4024	4024
query23	33928	33693	33622	33622
query24	11070	2933	3008	2933
query25	648	417	401	401
query26	1053	165	161	161
query27	2299	344	327	327
query28	7029	2163	2173	2163
query29	923	668	658	658
query30	268	161	163	161
query31	957	813	759	759
query32	94	57	58	57
query33	785	325	334	325
query34	955	481	474	474
query35	787	649	655	649
query36	1094	989	986	986
query37	149	79	80	79
query38	2991	2803	2824	2803
query39	912	870	881	870
query40	210	128	128	128
query41	57	60	53	53
query42	124	101	105	101
query43	601	557	522	522
query44	1219	750	738	738
query45	199	172	169	169
query46	1084	733	742	733
query47	1876	1762	1762	1762
query48	378	306	298	298
query49	856	432	501	432
query50	772	382	379	379
query51	6964	6788	6798	6788
query52	110	87	98	87
query53	358	289	287	287
query54	916	454	437	437
query55	75	76	74	74
query56	278	276	253	253
query57	1097	1060	1066	1060
query58	258	263	249	249
query59	3244	3211	3188	3188
query60	287	276	270	270
query61	91	90	92	90
query62	591	441	445	441
query63	313	291	302	291
query64	8818	2257	1736	1736
query65	3158	3112	3091	3091
query66	782	356	327	327
query67	15708	14884	14934	14884
query68	6826	567	558	558
query69	691	466	395	395
query70	1216	1169	1100	1100
query71	506	283	279	279
query72	8991	5574	5531	5531
query73	811	319	322	319
query74	5952	5484	5503	5484
query75	4811	2669	2727	2669
query76	4410	988	928	928
query77	773	307	305	305
query78	10526	9991	9727	9727
query79	6339	521	525	521
query80	2474	471	473	471
query81	561	223	220	220
query82	797	108	106	106
query83	301	175	173	173
query84	272	88	91	88
query85	1366	271	267	267
query86	448	316	317	316
query87	3362	3048	3107	3048
query88	4676	2424	2362	2362
query89	500	393	384	384
query90	1874	189	193	189
query91	130	102	100	100
query92	63	50	52	50
query93	5366	534	523	523
query94	1176	189	188	188
query95	402	312	314	312
query96	614	265	281	265
query97	3257	3025	2977	2977
query98	224	197	197	197
query99	1125	842	839	839
Total cold run time: 288201 ms
Total hot run time: 174348 ms

@doris-robot

doris-robot commented Jun 26, 2024

Copy link
Copy Markdown
ClickBench: Total hot run time: 31.01 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9523de300a36c088e1804f9d6779942c0c11cdee, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.22	0.06	0.06
query4	1.66	0.08	0.09
query5	0.52	0.48	0.49
query6	1.14	0.72	0.72
query7	0.02	0.02	0.01
query8	0.04	0.04	0.04
query9	0.55	0.48	0.50
query10	0.54	0.54	0.53
query11	0.15	0.11	0.12
query12	0.14	0.12	0.12
query13	0.58	0.58	0.58
query14	0.74	0.79	0.81
query15	0.83	0.80	0.81
query16	0.37	0.37	0.36
query17	1.00	0.98	1.03
query18	0.24	0.25	0.20
query19	1.77	1.78	1.84
query20	0.01	0.01	0.01
query21	15.44	0.64	0.64
query22	3.84	6.53	2.48
query23	18.26	1.44	1.22
query24	2.08	0.24	0.22
query25	0.15	0.09	0.08
query26	0.27	0.18	0.18
query27	0.07	0.08	0.08
query28	13.21	1.04	0.99
query29	12.63	3.29	3.26
query30	0.26	0.06	0.06
query31	2.88	0.40	0.38
query32	3.26	0.48	0.48
query33	2.87	2.89	2.86
query34	17.34	4.38	4.43
query35	4.47	4.44	4.54
query36	0.65	0.49	0.45
query37	0.18	0.16	0.15
query38	0.15	0.15	0.15
query39	0.04	0.03	0.04
query40	0.17	0.14	0.14
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.06 s
Total hot run time: 31.01 s

@wsjz

wsjz commented Jun 27, 2024

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

doris-robot commented Jun 27, 2024

Copy link
Copy Markdown
TPC-H: Total hot run time: 39519 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 159d7ef3ae18386414b1abbd9bfbf1efb1cff0ce, data reload: false

------ Round 1 ----------------------------------
q1	17636	4331	4259	4259
q2	2009	204	202	202
q3	10431	1187	1044	1044
q4	10199	841	814	814
q5	7471	2608	2606	2606
q6	215	134	137	134
q7	931	589	591	589
q8	9222	2054	2046	2046
q9	8990	6505	6439	6439
q10	9035	3671	3713	3671
q11	470	232	238	232
q12	408	232	222	222
q13	17761	3006	3013	3006
q14	267	228	232	228
q15	521	491	470	470
q16	532	377	367	367
q17	948	636	684	636
q18	8025	7389	7371	7371
q19	7262	1388	1463	1388
q20	632	312	319	312
q21	4854	3139	4005	3139
q22	379	344	346	344
Total cold run time: 118198 ms
Total hot run time: 39519 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4512	4215	4214	4214
q2	365	270	257	257
q3	2984	2903	2910	2903
q4	2032	1744	1735	1735
q5	5535	5472	5446	5446
q6	217	128	130	128
q7	2186	1862	1814	1814
q8	3263	3395	3476	3395
q9	8721	8710	8725	8710
q10	4085	3848	3702	3702
q11	609	498	502	498
q12	830	637	643	637
q13	17195	3259	3178	3178
q14	310	292	277	277
q15	581	489	478	478
q16	499	434	485	434
q17	1821	1483	1490	1483
q18	7988	7920	7715	7715
q19	1811	1613	1623	1613
q20	3168	1883	1863	1863
q21	5111	5006	4864	4864
q22	614	579	548	548
Total cold run time: 74437 ms
Total hot run time: 55892 ms

@doris-robot

doris-robot commented Jun 27, 2024

Copy link
Copy Markdown
TPC-DS: Total hot run time: 173415 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 159d7ef3ae18386414b1abbd9bfbf1efb1cff0ce, data reload: false

query1	911	380	369	369
query2	6436	2384	2371	2371
query3	6636	203	213	203
query4	19266	17719	17136	17136
query5	3685	476	479	476
query6	261	171	173	171
query7	4600	296	291	291
query8	294	285	284	284
query9	8529	2434	2410	2410
query10	584	318	283	283
query11	10598	9905	10062	9905
query12	113	86	83	83
query13	1670	381	379	379
query14	10244	7114	6732	6732
query15	240	184	196	184
query16	7735	271	271	271
query17	1637	556	542	542
query18	1919	285	283	283
query19	207	154	159	154
query20	87	85	82	82
query21	219	152	131	131
query22	4514	4003	4031	4003
query23	33850	33730	33462	33462
query24	11259	2896	2927	2896
query25	616	394	411	394
query26	745	164	169	164
query27	2338	330	338	330
query28	6055	2178	2155	2155
query29	913	652	663	652
query30	278	159	175	159
query31	993	787	773	773
query32	102	55	58	55
query33	773	302	308	302
query34	957	487	490	487
query35	793	665	628	628
query36	1154	981	986	981
query37	146	79	75	75
query38	2934	2882	2806	2806
query39	901	835	849	835
query40	211	151	137	137
query41	56	55	52	52
query42	114	102	105	102
query43	597	545	510	510
query44	1210	755	737	737
query45	197	172	164	164
query46	1080	723	728	723
query47	1834	1774	1760	1760
query48	384	309	306	306
query49	843	416	429	416
query50	764	385	387	385
query51	6905	6774	6776	6774
query52	104	95	91	91
query53	359	289	281	281
query54	864	443	447	443
query55	74	76	77	76
query56	276	253	292	253
query57	1160	1075	1078	1075
query58	255	239	250	239
query59	3442	3169	3179	3169
query60	306	276	280	276
query61	96	97	110	97
query62	609	437	450	437
query63	330	287	288	287
query64	8514	2223	1767	1767
query65	3134	3093	3104	3093
query66	736	328	332	328
query67	15815	14884	14896	14884
query68	7680	541	547	541
query69	694	452	428	428
query70	1165	1164	1137	1137
query71	521	278	279	278
query72	8790	5186	5444	5186
query73	817	333	328	328
query74	6024	5521	5512	5512
query75	5334	2649	2714	2649
query76	4494	952	946	946
query77	791	308	309	308
query78	10435	9863	9740	9740
query79	8089	511	519	511
query80	1021	465	472	465
query81	564	223	224	223
query82	783	104	106	104
query83	355	173	172	172
query84	272	84	88	84
query85	1301	289	269	269
query86	437	274	297	274
query87	3292	3099	3127	3099
query88	5043	2379	2372	2372
query89	542	373	404	373
query90	1927	195	195	195
query91	131	100	100	100
query92	66	50	49	49
query93	6372	517	515	515
query94	1149	187	188	187
query95	399	320	312	312
query96	613	270	268	268
query97	3233	2995	3025	2995
query98	226	205	228	205
query99	1165	860	831	831
Total cold run time: 289186 ms
Total hot run time: 173415 ms

@doris-robot

doris-robot commented Jun 27, 2024

Copy link
Copy Markdown
ClickBench: Total hot run time: 31.65 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 159d7ef3ae18386414b1abbd9bfbf1efb1cff0ce, data reload: false

query1	0.04	0.05	0.03
query2	0.08	0.05	0.04
query3	0.22	0.05	0.05
query4	1.68	0.09	0.10
query5	0.52	0.52	0.48
query6	1.14	0.73	0.74
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.56	0.51	0.51
query10	0.54	0.55	0.55
query11	0.15	0.11	0.11
query12	0.15	0.12	0.13
query13	0.60	0.58	0.60
query14	0.78	0.77	0.80
query15	0.84	0.82	0.81
query16	0.36	0.37	0.37
query17	1.05	1.04	1.05
query18	0.23	0.24	0.27
query19	1.92	1.75	1.68
query20	0.02	0.01	0.01
query21	15.72	0.75	0.66
query22	4.12	6.73	2.81
query23	18.23	1.44	1.27
query24	2.15	0.23	0.22
query25	0.16	0.08	0.09
query26	0.27	0.17	0.18
query27	0.07	0.08	0.08
query28	13.21	1.01	1.00
query29	12.59	3.33	3.32
query30	0.25	0.06	0.05
query31	2.87	0.38	0.38
query32	3.27	0.46	0.46
query33	2.86	2.97	2.93
query34	17.16	4.44	4.40
query35	4.44	4.58	4.51
query36	0.66	0.47	0.47
query37	0.18	0.15	0.15
query38	0.15	0.15	0.14
query39	0.05	0.03	0.03
query40	0.17	0.14	0.15
query41	0.09	0.05	0.05
query42	0.06	0.04	0.05
query43	0.04	0.04	0.03
Total cold run time: 109.72 s
Total hot run time: 31.65 s

morningman
morningman approved these changes Jun 28, 2024
View reviewed changes

@morningman morningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actions Bot commented Jun 28, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Jun 28, 2024
@github-actions

github-actions Bot commented Jun 28, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morningman
morningman merged commit f4a6434 into apache:master Jun 28, 2024
dataroaring pushed a commit that referenced this pull request Jun 30, 2024
@wsjz @dataroaring
[feature](insert)support external hive truncate table DDL (#36801)
018ff0a 
## Proposed changes

Issue Number: #31442

1. support hive3 'truncate table'
2. forbiden hive2 'truncate table' because of it is not supported by HMS
Client API on hive2
@wsjz
wsjz deleted the hive_truncate branch July 4, 2024 08:35
@wsjz wsjz mentioned this pull request Jul 11, 2024
Merged
morningman pushed a commit that referenced this pull request Jul 12, 2024
@wsjz
[feature](insert)support external hive truncate table DDL (#37659)
f2556ba 
pick: #36801
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@wsjz @HappenLee
[feature](insert)support external hive truncate table DDL (apache#36801)
a5ac554 
## Proposed changes

Issue Number: apache#31442

1. support hive3 'truncate table'
2. forbiden hive2 'truncate table' because of it is not supported by HMS
Client API on hive2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes
@wuwenchi wuwenchi wuwenchi approved these changes
@dataroaring dataroaring Awaiting requested review from dataroaring dataroaring is a code owner
@CalvinKirs CalvinKirs Awaiting requested review from CalvinKirs CalvinKirs is a code owner

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.5-merged dev/3.0.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wsjz @doris-robot @morningman @wuwenchi @dataroaring