Repository navigation
[Feature](iceberg-writer) Implements iceberg sink basic functionality for inserting into table. - #35587
Conversation
… for inserting into table.
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| namespace doris { | ||
|
|
||
| namespace pipeline { |
There was a problem hiding this comment.
warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]
| namespace doris { | |
| namespace pipeline { | |
| namespace doris::pipeline { |
be/src/pipeline/exec/iceberg_table_sink_operator.h:113:
- } // namespace pipeline
- } // namespace doris
+ } // namespace doris| namespace doris { | ||
| namespace iceberg { |
There was a problem hiding this comment.
warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]
| namespace doris { | |
| namespace iceberg { | |
| namespace doris::iceberg { |
be/src/vec/exec/format/table/iceberg/partition_spec.cpp:69:
- } // namespace iceberg
- } // namespace doris
+ } // namespace doris| namespace doris { | ||
| namespace iceberg { |
There was a problem hiding this comment.
warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]
| namespace doris { | |
| namespace iceberg { | |
| namespace doris::iceberg { |
be/src/vec/exec/format/table/iceberg/partition_spec.h:94:
- } // namespace iceberg
- } // namespace doris
+ } // namespace doris| private: | ||
| int next_field_id() { return ++_last_assigned_field_id; } | ||
|
|
||
| private: |
There was a problem hiding this comment.
warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers]
| private: | |
Additional context
be/src/vec/exec/format/table/iceberg/partition_spec.h:64: previously declared here
private:
^|
|
||
| const Schema& schema() const { return *_schema; } | ||
|
|
||
| int spec_id() { return _spec_id; } |
There was a problem hiding this comment.
warning: method 'spec_id' can be made const [readability-make-member-function-const]
| int spec_id() { return _spec_id; } | |
| int spec_id() const { return _spec_id; } |
|
|
||
| virtual int field_count() const override { return 2; } | ||
|
|
||
| virtual Type* field_type(const std::string& field_name) override; |
There was a problem hiding this comment.
warning: 'virtual' is redundant since the function is already declared 'override' [modernize-use-override]
| virtual Type* field_type(const std::string& field_name) override; | |
| Type* field_type(const std::string& field_name) override; |
|
|
||
| virtual Type* field_type(const std::string& field_name) override; | ||
|
|
||
| virtual const NestedField* field(int field_id) override; |
There was a problem hiding this comment.
warning: 'virtual' is redundant since the function is already declared 'override' [modernize-use-override]
| virtual const NestedField* field(int field_id) override; | |
| const NestedField* field(int field_id) override; |
|
|
||
| class ListType : public NestedType { | ||
| public: | ||
| ~ListType() = default; |
There was a problem hiding this comment.
warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
| ~ListType() = default; | |
| ~ListType() override = default; |
| static std::unique_ptr<ListType> of_required(int element_id, | ||
| std::unique_ptr<Type> element_type); | ||
|
|
||
| virtual TypeID type_id() const override { return TypeID::LIST; } |
There was a problem hiding this comment.
warning: 'virtual' is redundant since the function is already declared 'override' [modernize-use-override]
| virtual TypeID type_id() const override { return TypeID::LIST; } | |
| TypeID type_id() const override { return TypeID::LIST; } |
|
|
||
| const NestedField& element_field() const { return _element_field; } | ||
|
|
||
| virtual std::string to_string() const override; |
There was a problem hiding this comment.
warning: 'virtual' is redundant since the function is already declared 'override' [modernize-use-override]
| virtual std::string to_string() const override; | |
| std::string to_string() const override; |
Proposed changes
backport #34929
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...