Repository navigation
[Fix](hive-writer) Fix s3 file commiter not working. - #35502
Merged
Merged
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
morningman
force-pushed
the
fix_s3_committer
branch
from
May 28, 2024 08:21
fa48db1 to
d43df71
Compare
Contributor
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 41380 ms |
TPC-DS: Total hot run time: 172652 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 30.37 s |
wuwenchi
approved these changes
May 29, 2024
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
May 29, 2024
### Issue `The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed. (Service: S3, Status Code: 404, Request ID: 66557027E897233333FFC198)` ### Root cause apache#35311 adjusted the order of building hive partition update information. This change caused the update id to be unable to be obtained, causing the s3 file committer to not work properly. ### Solution Because uploading to s3 occurs after s3 file writer close(), close() must be called first, and then the build hive partiton update information is called.
morningman
added a commit
that referenced
this pull request
May 29, 2024
bp #35502 Co-authored-by: Qi Chen <[email protected]>
dataroaring
pushed a commit
that referenced
this pull request
May 31, 2024
### Issue `The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed. (Service: S3, Status Code: 404, Request ID: 66557027E897233333FFC198)` ### Root cause #35311 adjusted the order of building hive partition update information. This change caused the update id to be unable to be obtained, causing the s3 file committer to not work properly. ### Solution Because uploading to s3 occurs after s3 file writer close(), close() must be called first, and then the build hive partiton update information is called.
HappenLee
pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
### Issue `The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed. (Service: S3, Status Code: 404, Request ID: 66557027E897233333FFC198)` ### Root cause apache#35311 adjusted the order of building hive partition update information. This change caused the update id to be unable to be obtained, causing the s3 file committer to not work properly. ### Solution Because uploading to s3 occurs after s3 file writer close(), close() must be called first, and then the build hive partiton update information is called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue
The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed. (Service: S3, Status Code: 404, Request ID: 66557027E897233333FFC198)Root cause
#35311 adjusted the order of building hive partition update information. This change caused the update id to be unable to be obtained, causing the s3 file committer to not work properly.
Solution
Because uploading to s3 occurs after s3 file writer close(), close() must be called first, and then the build hive partiton update information is called.
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...