Skip to content

[feature](insert)add hive table sink thrift - #32274

Merged
morningman merged 1 commit into
apache:masterfrom
wsjz:hive_sink_thrift
Mar 15, 2024
Merged

morningman merged 1 commit into
apache:masterfrom
wsjz:hive_sink_thrift

Conversation

@wsjz

@wsjz wsjz commented Mar 15, 2024 •

Copy link
Copy Markdown
Contributor

Proposed changes

add hive table sink thrift
add partition type
add new compress type

issue: #31442

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@wsjz

wsjz commented Mar 15, 2024

Copy link
Copy Markdown
Contributor Author

run buildall

@wsjz

wsjz commented Mar 15, 2024

Copy link
Copy Markdown
Contributor Author

#31442

@morningman morningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Mar 15, 2024
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@kaka11chen kaka11chen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wsjz wsjz changed the title [feature][insert]add hive table sink thrift [feature](insert)add hive table sink thrift Mar 15, 2024
@doris-robot

Copy link
Copy Markdown
TPC-H: Total hot run time: 38459 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fc3fcf04b67ac5c3759deaa474487bfac1b5bc59, data reload: false

------ Round 1 ----------------------------------
q1	17626	4447	4177	4177
q2	2020	147	151	147
q3	10592	1160	915	915
q4	4654	742	710	710
q5	7438	2794	2723	2723
q6	185	122	125	122
q7	1183	839	809	809
q8	9331	2020	1981	1981
q9	7202	6493	6437	6437
q10	8525	3496	3622	3496
q11	434	226	219	219
q12	794	310	305	305
q13	17812	2901	2842	2842
q14	269	246	266	246
q15	501	449	453	449
q16	510	387	397	387
q17	975	527	630	527
q18	7181	6611	6358	6358
q19	1644	1461	1500	1461
q20	546	292	291	291
q21	7227	3566	3646	3566
q22	357	291	299	291
Total cold run time: 107006 ms
Total hot run time: 38459 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4130	4104	4091	4091
q2	315	217	230	217
q3	2986	2830	2841	2830
q4	1878	1617	1543	1543
q5	5218	5287	5259	5259
q6	192	122	121	121
q7	2248	1831	1847	1831
q8	3415	3320	3329	3320
q9	8579	8593	8548	8548
q10	3675	3686	3717	3686
q11	541	452	441	441
q12	720	542	566	542
q13	16928	2859	2863	2859
q14	271	249	246	246
q15	492	456	448	448
q16	459	409	415	409
q17	1770	1503	1495	1495
q18	7420	7163	7038	7038
q19	1644	1506	1513	1506
q20	1918	1727	1747	1727
q21	4902	4781	4682	4682
q22	548	466	442	442
Total cold run time: 70249 ms
Total hot run time: 53281 ms

@morningman
morningman merged commit 84572d7 into apache:master Mar 15, 2024
morningman pushed a commit to morningman/doris that referenced this pull request Mar 18, 2024
add hive table sink thrift
add partition type
add new compress type

issue: apache#31442
@wsjz
wsjz deleted the hive_sink_thrift branch March 22, 2024 07:42
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
add hive table sink thrift
add partition type
add new compress type

issue: apache#31442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.1-merged meta-change reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants