Repository navigation
[enhancement](plsql) Support show procedure and show create procedure… - #31763
Merged
Merged
Conversation
|
Thank you for your contribution to Apache Doris. |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Vallishp
force-pushed
the
plsql_show_proc
branch
2 times, most recently
from
March 4, 2024 17:33
0bcc25c to
c9efbd0
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 37905 ms |
TPC-DS: Total hot run time: 178274 ms |
ClickBench: Total hot run time: 30.4 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
xinyiZzz
reviewed
Mar 6, 2024
|
|
||
| @Override | ||
| public void showCreateProcedure(FuncNameInfo procedureName, List<List<String>> columns) { | ||
| Map<PlsqlProcedureKey, PlsqlStoredProcedure> allProc = client.getAllPlsqlStoredProcedures(); |
Contributor
There was a problem hiding this comment.
use client.getPlsqlStoredProcedure(procedureName.getName(), procedureName.getCtlId(), procedureName.getDbId()) instead of getAllPlsqlStoredProcedures
do not get all then check procedureName
| try { | ||
| SimpleDateFormat f = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss"); | ||
| String createTime = f.format(Calendar.getInstance().getTime()); | ||
| String modifyTime = f.format(Calendar.getInstance().getTime()); |
Contributor
There was a problem hiding this comment.
createTime and modifyTime may not be equal because get the current time separately
String modifyTime=createTime seems better
Contributor
|
run buildall |
Vallishp
changed the title
Vallishp
force-pushed
the
plsql_show_proc
branch
from
March 6, 2024 17:29
3a0dc84 to
810d546
Compare
Contributor
Author
|
run buildall |
Contributor
|
run p0 |
Contributor
|
run buildall |
2 similar comments
Contributor
|
run buildall |
Contributor
|
run buildall |
Vallishp
force-pushed
the
plsql_show_proc
branch
from
March 7, 2024 12:56
b50acfc to
1ab962e
Compare
Contributor
Author
|
run buildall |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
Bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
yiguolei
approved these changes
Mar 8, 2024
yiguolei
pushed a commit
that referenced
this pull request
Mar 9, 2024
HappenLee
pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… (#31297)
Proposed changes
Issue Number: close #31297
Support Plsql framework commands.
Further comments
MySQL [(none)]> use mydb;
Database changed
MySQL [mydb]> show procedure status;
+------------------+-----------+-------+-------------+-----------+---------------------+---------------------+
| ProcedureName | CatalogId | DbId | PackageName | OwnerName | CreateTime | ModifyTime |
+------------------+-----------+-------+-------------+-----------+---------------------+---------------------+
| PROCEDURE_SELECT | 0 | 42013 | | root | 2024-03-04 11:58:55 | 2024-03-04 12:01:16 |
+------------------+-----------+-------+-------------+-----------+---------------------+---------------------+
1 row in set (0.15 sec)
MySQL [mydb]> show create procedure procedure_select;
+------------------+---------------------------------------------------------------------------------------------------------------+
| Procedure | Create Procedure |
+------------------+---------------------------------------------------------------------------------------------------------------+
| PROCEDURE_SELECT | CREATE OR REPLACE PROCEDURE procedure_select( IN id_n INT)
BEGIN
select * from plsql_tbl where id = id_n;
END |
+------------------+---------------------------------------------------------------------------------------------------------------+
1 row in set (0.00 sec)
MySQL [mydb]>
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...