Skip to content

[fix](fe)support multi distinct group_concat - #17237

Merged
starocean999 merged 2 commits into
apache:masterfrom
starocean999:nereids_0228
Mar 2, 2023
Merged

[fix](fe)support multi distinct group_concat#17237
starocean999 merged 2 commits into
apache:masterfrom
starocean999:nereids_0228

Conversation

@starocean999

@starocean999 starocean999 commented Feb 28, 2023

Copy link
Copy Markdown
Contributor

Proposed changes

  1. group_concat(distinct x, order by y) is not correctly implemented, return an error message "not support" for now
  2. support multi distinct group_concat to allow select group_concat(distinct a), group_concat(disinct b) from t;

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions Bot added area/nereids area/planner Issues or PRs related to the query planner area/vectorization kind/test labels Feb 28, 2023
@github-actions

github-actions Bot commented Feb 28, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@starocean999

starocean999 commented Feb 28, 2023

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

hello-stephen commented Feb 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 32.9 seconds
stream load tsv: 481 seconds loaded 74807831229 Bytes, about 148 MB/s
stream load json: 38 seconds loaded 2358488459 Bytes, about 59 MB/s
stream load orc: 69 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 28 seconds loaded 861443392 Bytes, about 29 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230228141350_clickbench_pr_105815.html

@starocean999

starocean999 commented Feb 28, 2023

Copy link
Copy Markdown
Contributor Author

run buildall

@github-actions

github-actions Bot commented Feb 28, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Mar 2, 2023
@github-actions

github-actions Bot commented Mar 2, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actions Bot commented Mar 2, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@starocean999
starocean999 merged commit 27352af into apache:master Mar 2, 2023
@starocean999 starocean999 mentioned this pull request Mar 2, 2023
Merged
5 tasks
morrySnow pushed a commit that referenced this pull request Mar 3, 2023
@starocean999
[fix](planner) support multi distinct group_concat (#17364)
6454d96 
pick from master #17237
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 9, 2023
@starocean999 @yagagagaga
[fix](fe)support multi distinct group_concat (apache#17237)
cc3f4d3 
* [fix](fe)support multi distinct group_concat

* update based on comments
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
@starocean999 @gnehil
[fix](fe)support multi distinct group_concat (apache#17237)
197d2f9 
* [fix](fe)support multi distinct group_concat

* update based on comments
@BiteTheDDDDt BiteTheDDDDt mentioned this pull request Jul 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. area/nereids area/planner Issues or PRs related to the query planner area/vectorization kind/test reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@starocean999 @hello-stephen @morrySnow