Skip to content

[Function](vec) use const column to opt function current_time() - #16953

Merged
HappenLee merged 1 commit into
apache:masterfrom
HappenLee:bug-fix
Feb 21, 2023
Merged

[Function](vec) use const column to opt function current_time()#16953
HappenLee merged 1 commit into
apache:masterfrom
HappenLee:bug-fix

Conversation

@HappenLee

@HappenLee HappenLee commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

Proposed changes

Before：

mysql> select count(current_time()) from hits;
+-----------------------+
| count(current_time()) |
+-----------------------+
|              99997497 |
+-----------------------+
1 row in set (0.52 sec)

After:

mysql> select count(current_time()) from hits;
+-----------------------+
| count(current_time()) |
+-----------------------+
|              99997497 |
+-----------------------+
1 row in set (0.36 sec)

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@HappenLee
HappenLee marked this pull request as ready for review February 20, 2023 13:03
@github-actions github-actions Bot added area/sql/function Issues or PRs related to the SQL functions area/vectorization labels Feb 20, 2023
@github-actions

github-actions Bot commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

zhangstar333
zhangstar333 previously approved these changes Feb 20, 2023
View reviewed changes
@github-actions

github-actions Bot commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@github-actions

github-actions Bot commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen

hello-stephen commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35 seconds
stream load tsv: 468 seconds loaded 74807831229 Bytes, about 152 MB/s
stream load json: 38 seconds loaded 2358488459 Bytes, about 59 MB/s
stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 28 seconds loaded 861443392 Bytes, about 29 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230220154003_clickbench_pr_100436.html

@HappenLee

HappenLee commented Feb 21, 2023

Copy link
Copy Markdown
Contributor Author

run buildall

1 similar comment
@HappenLee

HappenLee commented Feb 21, 2023

Copy link
Copy Markdown
Contributor Author

run buildall

BiteTheDDDDt
BiteTheDDDDt approved these changes Feb 21, 2023
View reviewed changes

@BiteTheDDDDt BiteTheDDDDt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actions Bot commented Feb 21, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Feb 21, 2023
@HappenLee
HappenLee merged commit f37da6e into apache:master Feb 21, 2023
@zclllyybb zclllyybb mentioned this pull request Mar 2, 2023
Merged
1 of 5 tasks
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 9, 2023
@HappenLee @yagagagaga
[Function](vec) use const column to opt function current_time() (apac…
344d738 
…he#16953)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes
@zhangstar333 zhangstar333 zhangstar333 left review comments

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. area/sql/function Issues or PRs related to the SQL functions area/vectorization reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HappenLee @hello-stephen @BiteTheDDDDt @zhangstar333