Repository navigation
[enhancement](memtracker) Optimize readability of mem exceed limit error message - #11877
Merged
Merged
Conversation
xinyiZzz
force-pushed
the
mem_tracker_factor_v2_fix9
branch
from
August 17, 2022 14:22
aad9df6 to
87a3013
Compare
yiguolei
reviewed
Aug 18, 2022
| // this will cause coredump for ASAN build when running regression test, | ||
| // disable temporarily. | ||
| doris::ExecEnv::GetInstance()->task_pool_mem_tracker_registry()->logout_task_mem_tracker(); | ||
| doris::ExecEnv::GetInstance()->process_mem_tracker()->enable_print_log_usage(); |
Contributor
There was a problem hiding this comment.
If this method has to be called and it only set a property value. I think the property value should be a config.
Contributor
Author
There was a problem hiding this comment.
enable_print_log_usage is reset to true every 1s, this is to avoid frequent log printing when process mem tracker exceeds mem limit.
5 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #11876
Problem summary
consume_local, which has better applicability.Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...