Repository navigation
[fix](planner)push constant expr in predicate to outer join's other conjuncts by mistake - #11527
Merged
Merged
Conversation
github-actions
Bot
added
area/planner
Gabriel39
reviewed
Aug 6, 2022
| """ | ||
|
|
||
| order_qt_select """ | ||
| select t.* from (select * from wftest1 t1 left join wftest2 t2 on t1.aa=t2.cc) t where dayofweek(current_date())=8; |
Contributor
There was a problem hiding this comment.
What should be returned for query select * from wftest1 t1 left join wftest2 t2 on t1.aa=t2.cc and dayofweek(current_date())=8 ?
Contributor
Author
There was a problem hiding this comment.
all rows of left table with all columns of right table filled by null.
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
yiguolei
pushed a commit
that referenced
this pull request
Aug 9, 2022
…onjuncts by mistake (#11527) constant expr in predicate should not be pushed to outer join's other conjuncts
Henry2SS
pushed a commit
to Henry2SS/incubator-doris
that referenced
this pull request
Sep 14, 2022
…onjuncts by mistake (apache#11527) constant expr in predicate should not be pushed to outer join's other conjuncts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #11526
Problem summary
constant expr in predicate should not be pushed to outer join's other conjuncts
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...