Skip to content

[Enhancement] Remove wrong usage of const_cast #55057

New issue
New issue
Closed
Closed
[Enhancement] Remove wrong usage of const_cast#55057
Assignees
wumeibanfa
Labels
difficulty/mediumdoris-futuregood first issue

Description

@zclllyybb
zclllyybb
opened on Aug 20, 2025

Search before asking

  • I had searched in the issues and found no similar issues.

Description

now in Doris we have some nonsense use of const_cast to remove the const-cv qualifier. like

doris/be/src/vec/data_types/serde/data_type_string_serde.h

Line 43 in 117b2e3

char* dest_ptr = const_cast<char*>(src);

since we plan to write to the memory of src, it makes no sense to make it const char* and remove it in the function. it lead to some wrong use like

doris/be/test/vec/data_types/data_type_string_test.cpp

Line 345 in 117b2e3

escape_string(test_str, &len, '\\');
, where we tried to write to a static memory region. it's a critical bug.

Solution

you should go through our whole be/ and find all const_cast. check if they make sense. (which I think most of them don't. for wrong usage, remove it. and leave a comment to others to explain why it's necessary.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Activity

  1. zclllyybb
    added
    good first issue
    doris-future
    difficulty/easy
    on Aug 20, 2025

  2. wumeibanfa commented on Aug 20, 2025

    @wumeibanfa
    wumeibanfa
    on Aug 20, 2025
    Contributor

    please assign it to me

  3. zclllyybb
    assigned
    wumeibanfa
    on Aug 20, 2025

  4. zclllyybb commented on Aug 20, 2025

    @zclllyybb
    zclllyybb
    on Aug 20, 2025
    ContributorAuthor

    please assign it to me

    good! assigned~

  5. zclllyybb
    linked a pull request that will close this issue[fix] remove useless const_cast and explain const_cast #55719on Sep 6, 2025
  6. BiteTheDDDDt
    added a commit that references this issue on Sep 30, 2025

    [fix] remove useless const_cast and explain const_cast for vec (1) (#…

    0ea052c
  7. github-actions
    added a commit that references this issue on Sep 30, 2025

    [fix] remove useless const_cast and explain const_cast for vec (1) (#…

    95bb67c
  8. dwdwqfwe
    added a commit that references this issue on Oct 4, 2025

    [fix] remove useless const_cast and explain const_cast for vec (1) (a…

    7cf0726
  9. yiguolei
    added a commit that references this issue on Oct 10, 2025

    [fix] remove useless const_cast and explain const_cast for vec (3) (#…

    066fb58
  10. github-actions
    added a commit that references this issue on Oct 10, 2025

    [fix] remove useless const_cast and explain const_cast for vec (3) (#…

    5933286
  11. zclllyybb
    added 3 commits that reference this issue on Oct 10, 2025

    [fix] remove useless const_cast and explain const_cast for vec (5) (#…

    bbd7d55

    [fix] remove useless const_cast and explain const_cast for vec (6) (#…

    713108d

    [fix] remove useless const_cast and explain const_cast for vec (4) (#…

    67e2a40

  12. 2 remaining items

  13. zclllyybb
    added
    difficulty/medium
    on Oct 26, 2025
  14. zclllyybb
    added a commit that references this issue on Oct 26, 2025

    [fix] remove parse_id (#57240)

    d9f3044
  15. github-actions
    added a commit that references this issue on Oct 26, 2025

    [fix] remove parse_id (#57240)

    ff7c109
  16. yiguolei
    added a commit that references this issue on Oct 26, 2025

    [fix] remove useless const_cast and explain const_cast(3) (#56441)

    955d04d
  17. github-actions
    added a commit that references this issue on Oct 26, 2025

    [fix] remove useless const_cast and explain const_cast(3) (#56441)

    d9c48c4
  18. dwdwqfwe
    added 2 commits that reference this issue on Oct 31, 2025

    [fix] remove parse_id (apache#57240)

    c6b1db9

    [fix] remove useless const_cast and explain const_cast(3) (apache#56441)

    23cfd47
  19. yiguolei
    added a commit that references this issue on Nov 18, 2025

    [fix] remove useless const_cast and explain const_cast(1) (#55943)

    48fcb2a
  20. github-actions
    added a commit that references this issue on Nov 18, 2025

    [fix] remove useless const_cast and explain const_cast(1) (#55943)

    d154f4f

  21. zclllyybb commented on Nov 18, 2025

    @zclllyybb
    zclllyybb
    on Nov 18, 2025
    ContributorAuthor

    finally finished!

  22. zclllyybb
    closed this as completedon Nov 18, 2025
  23. nagisa-kunhah
    added a commit that references this issue on Dec 14, 2025

    [fix] remove useless const_cast and explain const_cast(1) (apache#55943)

    71aa858
  24. morningman
    added a commit that references this issue on Mar 18, 2026

    [fix] remove useless const_cast and explain const_cast for vec (4) (a…

    e4adef1
  25. xylaaaaa
    added 2 commits that reference this issue on Mar 18, 2026

    [fix] remove useless const_cast and explain const_cast for vec (4) (a…

    1169f85

    [fix] remove useless const_cast and explain const_cast for vec (4) (a…

    1cb85f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

difficulty/mediumdoris-futuregood first issue

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions