You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
V2 segment file should contain no more than INT32_MAX rows #1647
Current V2 segment file allows more than INT32_MAX rows, it uses uint64_t to represent row count both in segment_v2::SegmentWriter and SegmentFooterPB. However bitmap implementations usually only support 32 bits integer, thus in order to support bitmap index later, we should limit row count in each segment to INT32_MAX.
Note that I deliberately choose INT32_MAX instead of UINT32_MAX to avoid overflow issue when casting from uint32_t to signed int.
Activity
V2 segment file should contain no more than INT32_MAX rows apache#1647
Limit V2 segment file row count (#1647) (#1705)
gaodayue commentedon Sep 4, 2019
fixed by #1705
Fix BE UT failure introduced by apache#1526 in TabletSchemaCache (apa…
Fix BE UT failure introduced by apache#1526 in TabletSchemaCache (apa…
Pick fix BE UT failure from apache#1661 apache#1678 (apache#1683)