Repository navigation
Commit ff7c109
[fix] remove parse_id (#57240)
Related PR: #55057
Problem Summary:
Remove `parse_id`, as this method modifies the string. When using the
same string, a second call to this method will fail.
Following testing, from_hex and parse_id demonstrate identical
behaviour.
```c++
parse_id(abcd-1234) = (from_hex(abcd), from_hex(1234)) = (0xabcd, 0x1234)
parse_id(0123456789abcdef-0123456789abcdef) = (from_hex(0123456789abcdef), from_hex(0123456789abcdef)) = (0x0123456789abcdef, 0x0123456789abcdef)
```1 parent eb3e21d commit ff7c109
3 files changed
Lines changed: 7 additions & 29 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
52 | 57 | | |
53 | | - | |
| 58 | + | |
| 59 | + | |
54 | 60 | | |
55 | 61 | | |
56 | 62 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | 62 | | |
86 | 63 | | |
87 | 64 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
172 | 172 | | |
173 | 173 | | |
174 | 174 | | |
175 | | - | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | | - | |
180 | 175 | | |
181 | 176 | | |
182 | 177 | | |
| |||
0 commit comments