You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit f8f8121
Browse filesBrowse the repository at this point in the historyBrowse files
[fix](be) Restore file-level cache metadata loading during startup
Related PR: #57072, #65658
Problem Summary: During BE startup, get_or_set, the fully-covered lookup, and probe attempt to restore an absent file before background metadata loading completes. Their FileCacheKey leaves offset uninitialized, while the storage implementation now performs an exact RocksDB lookup for one block. A file with multiple persisted blocks can therefore miss existing cache data or restore only one block. Query metadata by tablet and file hash prefix, restore all blocks, and assert that the file hash is absent when entering synchronous restoration. Keep caller trigger conditions, key encoding, and existing tablet-range queries unchanged.
Fix reuse of persistent file cache blocks while BE startup metadata loading is in progress.
- Test: Unit Test via run-be-ut.sh with ASAN and GLIBC_COMPATIBILITY=OFF: 38 related tests passed; 9 focused tests passed again after final cleanup. The 5 startup regression cases failed before the fix and passed afterward. clang-format v16, build hygiene, git diff checks, and clang-tidy on changed lines passed.
- Behavior changed: Yes, startup lookups restore all persisted blocks for an absent file instead of querying one uninitialized offset.
- Does this need documentation: No
0 commit comments