3333import org .lance .namespace .model .DescribeTableResponse ;
3434import org .lance .namespace .model .DropNamespaceRequest ;
3535import org .lance .namespace .model .DropTableRequest ;
36- import org .lance .namespace .model .ListNamespacesRequest ;
37- import org .lance .namespace .model .ListNamespacesResponse ;
38- import org .lance .namespace .model .ListTablesRequest ;
39- import org .lance .namespace .model .ListTablesResponse ;
4036import org .lance .namespace .model .RegisterTableRequest ;
4137import org .lance .namespace .model .TableExistsRequest ;
4238import org .mockito .ArgumentCaptor ;
@@ -71,39 +67,17 @@ public void testDatabaseMutationRequestsUseConfiguredParentAndModes() {
7167 }
7268
7369 @ Test
74- public void testForceDropDatabaseDeletesNestedContentsBeforeNamespaces () {
70+ public void testForceDropDatabaseUsesNativeCascade () {
7571 LanceNamespace namespace = Mockito .mock (LanceNamespace .class );
76- Mockito .when (namespace .listNamespaces (Mockito .any ())).thenAnswer (invocation -> {
77- ListNamespacesRequest request = invocation .getArgument (0 );
78- if (request .getId ().equals (Arrays .asList ("tenant" , "analytics" ))) {
79- return new ListNamespacesResponse ().namespaces (Collections .singleton ("archive" ));
80- }
81- return new ListNamespacesResponse ().namespaces (Collections .emptySet ());
82- });
83- Mockito .when (namespace .listTables (Mockito .any ())).thenAnswer (invocation -> {
84- ListTablesRequest request = invocation .getArgument (0 );
85- if (request .getId ().equals (Arrays .asList ("tenant" , "analytics" , "archive" ))) {
86- return new ListTablesResponse ().tables (Collections .singleton ("old_events" ));
87- }
88- return new ListTablesResponse ().tables (Collections .singleton ("events" ));
89- });
9072 LanceNamespaceClient client = client (namespace );
9173
9274 client .dropDatabase ("analytics" , true , true );
9375
94- InOrder order = Mockito .inOrder (namespace );
95- order .verify (namespace ).dropTable (Mockito .argThat (request ->
96- request .getId ().equals (Arrays .asList ("tenant" , "analytics" , "archive" , "old_events" ))));
97- order .verify (namespace ).dropNamespace (Mockito .argThat (request ->
98- request .getId ().equals (Arrays .asList ("tenant" , "analytics" , "archive" ))
99- && "Fail" .equals (request .getMode ())
100- && "Restrict" .equals (request .getBehavior ())));
101- order .verify (namespace ).dropTable (Mockito .argThat (request ->
102- request .getId ().equals (Arrays .asList ("tenant" , "analytics" , "events" ))));
103- order .verify (namespace ).dropNamespace (Mockito .argThat (request ->
76+ Mockito .verify (namespace ).dropNamespace (Mockito .argThat (request ->
10477 request .getId ().equals (Arrays .asList ("tenant" , "analytics" ))
10578 && "Skip" .equals (request .getMode ())
106- && "Restrict" .equals (request .getBehavior ())));
79+ && "Cascade" .equals (request .getBehavior ())));
80+ Mockito .verify (namespace , Mockito .never ()).dropTable (Mockito .any ());
10781 }
10882
10983 @ Test
@@ -251,6 +225,8 @@ public void testConcurrentExternalTableRegistrationStillRetriesMutation() {
251225 .when (namespace ).alterTableAddColumns (Mockito .any ());
252226 Mockito .doThrow (new TableAlreadyExistsException ("registered concurrently" ))
253227 .when (namespace ).registerTable (Mockito .any ());
228+ Mockito .when (namespace .describeTable (Mockito .any ()))
229+ .thenReturn (new DescribeTableResponse ().location ("events.lance" ));
254230 LanceNamespaceClient client = rootFilesystemClient (namespace );
255231
256232 client .addColumns ("default" , "events" , Collections .singletonList (
@@ -259,6 +235,24 @@ public void testConcurrentExternalTableRegistrationStillRetriesMutation() {
259235 Mockito .verify (namespace , Mockito .times (2 )).alterTableAddColumns (Mockito .any ());
260236 }
261237
238+ @ Test
239+ public void testConcurrentExternalTableRegistrationAtAnotherLocationFails () {
240+ LanceNamespace namespace = Mockito .mock (LanceNamespace .class );
241+ Mockito .doThrow (new TableNotFoundException ("not registered" ))
242+ .when (namespace ).alterTableAddColumns (Mockito .any ());
243+ Mockito .doThrow (new TableAlreadyExistsException ("registered concurrently" ))
244+ .when (namespace ).registerTable (Mockito .any ());
245+ Mockito .when (namespace .describeTable (Mockito .any ()))
246+ .thenReturn (new DescribeTableResponse ().location ("other.lance" ));
247+ LanceNamespaceClient client = rootFilesystemClient (namespace );
248+
249+ Assertions .assertThrows (RuntimeException .class , () -> client .addColumns (
250+ "default" , "events" , Collections .singletonList (
251+ new AddColumnsEntry ().name ("score" ).expression ("CAST(NULL AS BIGINT)" ))));
252+
253+ Mockito .verify (namespace ).alterTableAddColumns (Mockito .any ());
254+ }
255+
262256 @ Test
263257 public void testMissingRootFilesystemTablePreservesMutationFailure () {
264258 LanceNamespace namespace = Mockito .mock (LanceNamespace .class );
0 commit comments