Repository navigation
Commit ea9d174
committed
[fix](iceberg) Prepare row-level isolation before backend writes
### What problem does this PR solve?
Issue Number: N/A
Related PR: #69702
Problem Summary: Standard-only isolation selection made existing tables configured
with delete_isolation_level=snapshot fall back to serializable and reject
previously permitted concurrent appends. Parsing an invalid selected value only
during commit also failed after backend files had been reported, when normal
rollback could no longer reclaim them.
Resolve the operation's standard property, legacy compatibility property, then SDK
default. Parse and cache the SDK isolation enum from the opened transaction's
metadata before publishing the prepared transaction or returning a backend sink.
Commit uses that cached selection while retaining the other row-delta validations.
### Release note
Iceberg row-level writes retain valid legacy isolation settings and reject invalid
selected isolation values before backend file creation.
### Check List (For Author)
- Test: Unit Test
- run-fe-ut.sh --run: six targeted connector/planner classes, 237 tests
discovered, 236 passed, one pre-existing unrelated disabled test
- Independent Checkstyle for fe-connector-iceberg and fe-core: zero violations
- Scoped git diff --check and added-lines checks passed
- Behavior changed: Yes, preserve legacy-only isolation compatibility and validate
the selected isolation before backend writes, fixed for the statement lifetime
- Does this need documentation: No1 parent a4dc943 commit ea9d174
3 files changed
Lines changed: 244 additions & 33 deletions
File tree
- fe/fe-connector/fe-connector-iceberg/src
- main/java/org/apache/doris/connector/iceberg
- test/java/org/apache/doris/connector/iceberg
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
| 133 | + | |
133 | 134 | | |
134 | 135 | | |
135 | 136 | | |
| |||
165 | 166 | | |
166 | 167 | | |
167 | 168 | | |
| 169 | + | |
168 | 170 | | |
169 | 171 | | |
170 | 172 | | |
| |||
287 | 289 | | |
288 | 290 | | |
289 | 291 | | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
290 | 299 | | |
291 | 300 | | |
292 | 301 | | |
293 | 302 | | |
294 | 303 | | |
295 | 304 | | |
296 | | - | |
| 305 | + | |
297 | 306 | | |
298 | 307 | | |
| 308 | + | |
299 | 309 | | |
300 | 310 | | |
301 | 311 | | |
| |||
1194 | 1204 | | |
1195 | 1205 | | |
1196 | 1206 | | |
1197 | | - | |
| 1207 | + | |
1198 | 1208 | | |
1199 | 1209 | | |
1200 | 1210 | | |
| |||
1349 | 1359 | | |
1350 | 1360 | | |
1351 | 1361 | | |
1352 | | - | |
1353 | | - | |
1354 | | - | |
1355 | | - | |
1356 | | - | |
| 1362 | + | |
| 1363 | + | |
| 1364 | + | |
1357 | 1365 | | |
1358 | 1366 | | |
1359 | | - | |
1360 | | - | |
1361 | | - | |
| 1367 | + | |
| 1368 | + | |
1362 | 1369 | | |
1363 | 1370 | | |
1364 | | - | |
1365 | | - | |
1366 | | - | |
| 1371 | + | |
| 1372 | + | |
1367 | 1373 | | |
1368 | 1374 | | |
1369 | | - | |
1370 | | - | |
1371 | | - | |
| 1375 | + | |
| 1376 | + | |
1372 | 1377 | | |
1373 | 1378 | | |
1374 | 1379 | | |
1375 | 1380 | | |
1376 | 1381 | | |
1377 | | - | |
| 1382 | + | |
| 1383 | + | |
| 1384 | + | |
| 1385 | + | |
| 1386 | + | |
| 1387 | + | |
1378 | 1388 | | |
1379 | 1389 | | |
1380 | 1390 | | |
| |||
0 commit comments