You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit e1299ba
Browse filesBrowse the repository at this point in the historyBrowse files
[fix](build) Make ENABLE_UNITY_BUILD=OFF authoritative over CMAKE_UNITY_BUILD
Each pilot target set its UNITY_BUILD property inside `if (ENABLE_UNITY_BUILD)`,
which is a one-way gate: OFF took the empty branch and left the property alone.
CMake's own CMAKE_UNITY_BUILD initializes UNITY_BUILD when add_library runs, so
a cache carrying CMAKE_UNITY_BUILD=ON kept the pilot targets unity-built while
the build advertised the opposite.
Normalize the option to a strict ON/OFF once and set the property
unconditionally from it, so OFF is an explicit OFF. Normalizing also keeps an
empty -DENABLE_UNITY_BUILD= (an unset variable forwarded by a script) from
turning into a malformed set_target_properties call.
Verified on this tree with `-DENABLE_UNITY_BUILD=OFF -DCMAKE_UNITY_BUILD=ON`:
28 unity TUs across the three pilot targets before, 0 after; the ordinary
`-DENABLE_UNITY_BUILD=ON` configure still produces exactly the 6 advertised
batches (InformationSchema 1, Service 1, Storage 4).
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01Gdfkk7RqgD5e3Uv7bTM3NV
0 commit comments