Repository navigation
Commit e02d93d
authored
[fix](ivm) Rename leftover row binlog to changelog in IVM tests (#69372)
Related PR: #69311, #69268, #63639
Problem Summary: #69311 renamed the row binlog (the change stream IVM
reads) to **changelog** and rejected the legacy keys `binlog.format` /
`binlog.need_historical_value` in every DDL. Two test files merged just
before it fell outside that rename sweep and now fail:
1.
`regression-test/suites/mtmv_p0/ivm/test_ivm_datetime_sequence.groovy`
(from #69268) — creates its IVM base tables with `"binlog.enable" =
"true", "binlog.format" = "ROW", "binlog.need_historical_value" =
"true"`, which CREATE TABLE now rejects.
2.
`RelationImpliedPredicateTest#testIvmOutputPredicatesSkipHiddenColumns`
(from #63639) — same legacy properties in the base-table DDL, and it
gates the creation on `enable_feature_binlog` instead of the new
`enable_feature_changelog`.
Fix: switch both to `"changelog.enable" = "true"` (plus
`"changelog.need_historical_value" = "true"` where the before-image is
needed), drop the rejected `binlog.format`, and use
`enable_feature_changelog` as the feature gate in the FE unit test.
Related IVM trace issue: #65418 .1 parent 7a84ab6 commit e02d93d
2 files changed
Lines changed: 9 additions & 11 deletions
File tree
- fe/fe-core/src/test/java/org/apache/doris/nereids/mv
- regression-test/suites/mtmv_p0/ivm
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
414 | 414 | | |
415 | 415 | | |
416 | 416 | | |
417 | | - | |
| 417 | + | |
418 | 418 | | |
419 | 419 | | |
420 | | - | |
421 | | - | |
| 420 | + | |
| 421 | + | |
422 | 422 | | |
423 | 423 | | |
424 | 424 | | |
425 | 425 | | |
426 | 426 | | |
427 | | - | |
| 427 | + | |
428 | 428 | | |
429 | 429 | | |
430 | 430 | | |
| |||
458 | 458 | | |
459 | 459 | | |
460 | 460 | | |
461 | | - | |
| 461 | + | |
462 | 462 | | |
463 | 463 | | |
464 | 464 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
52 | | - | |
53 | | - | |
| 51 | + | |
| 52 | + | |
54 | 53 | | |
55 | 54 | | |
56 | 55 | | |
| |||
64 | 63 | | |
65 | 64 | | |
66 | 65 | | |
67 | | - | |
68 | | - | |
69 | | - | |
| 66 | + | |
| 67 | + | |
70 | 68 | | |
71 | 69 | | |
72 | 70 | | |
| |||
0 commit comments