Repository navigation
Commit d8de816
committed
[test](nereids) Cover query columns captured inside nested lambda bodies
### What problem does this PR solve?
Issue Number: None
Related PR: #68260
Problem Summary:
A lambda body may reference the columns of the enclosing query, but this
only worked for a single level of high-order function. As soon as the
lambda was nested inside another lambda, the reference failed to bind:
```sql
WITH t2 AS (SELECT c IS NULL AS dict_flag, ARRAY('A') AS arr1, ARRAY('a') AS arr2 FROM t)
SELECT ARRAY_MAP(arg1 -> ARRAY_SUM(ARRAY_MAP(arg2 -> IF(dict_flag, 1, 0), arr2)), arr1) FROM t2;
-- ERROR 1105 (HY000): Unknown lambda slot 'dict_flag in lambda arguments[arg2]
```
The same happened with `array_sortby`, `array_filter` and any other
high-order function used as the inner lambda.
Root cause: `ExpressionAnalyzer` analyzed every lambda body with a
nested analyzer whose scope only held the lambda arguments and whose
outer scope was the enclosing scope. Slot binding looks at most one
level up, so with two nested lambdas the query columns were out of
reach for the inner lambda body.
#68260 has since changed the lambda analyzer so that every name that is
not a lambda argument is resolved by the enclosing analyzer, which
recurses through the enclosing lambdas up to the query analyzer. That
already makes the query columns bindable at any nesting depth, and an
unknown name is now reported by the query analyzer as
`Unknown column 'x' in 'table list' ...`. No production change is left;
this PR keeps the coverage so the behavior cannot regress silently:
- `BindFunctionTest`: query-column capture in nested
`array_map`/`array_sortby`/three-level lambdas, visibility of all
enclosing lambda arguments, same-name shadowing, and the unknown
column error.
- `test_nested_array_map`: nested lambdas that capture query columns
(plain column, CTE alias, together with the enclosing lambda
argument, three levels deep) and the unknown column error.
### Release note
None
### Check List (For Author)
- Test:
- Unit Test: `BindFunctionTest` (new cases pass on current master)
- Regression test: `test_nested_array_map` (passes on current master)
- Behavior changed: No
- Does this need documentation: No
Claude-Session: https://claude.ai/code/session_01FfTgMuMpYGGFWuckWxeGNw1 parent d4f052b commit d8de816
3 files changed
Lines changed: 162 additions & 1 deletion
File tree
- fe/fe-core/src/test/java/org/apache/doris/nereids/rules/analysis
- regression-test
- data/query_p0/sql_functions/array_functions
- suites/query_p0/sql_functions/array_functions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
21 | 22 | | |
| 23 | + | |
| 24 | + | |
22 | 25 | | |
| 26 | + | |
| 27 | + | |
23 | 28 | | |
| 29 | + | |
24 | 30 | | |
25 | 31 | | |
26 | 32 | | |
27 | 33 | | |
| 34 | + | |
| 35 | + | |
28 | 36 | | |
29 | 37 | | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
30 | 42 | | |
31 | 43 | | |
32 | 44 | | |
| |||
40 | 52 | | |
41 | 53 | | |
42 | 54 | | |
43 | | - | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
44 | 59 | | |
45 | 60 | | |
46 | 61 | | |
| |||
74 | 89 | | |
75 | 90 | | |
76 | 91 | | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
77 | 151 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
90 | 146 | | |
0 commit comments