Skip to content

Commit d60a614

Browse files
morningmanclaude
andcommitted
[test](session) Keep the follower JDBC URL's query string on the same Groovy expression
test_mysql_forward_to_master built the follower's JDBC URL over two lines with the `+` at the start of the second one. In a bare assignment Groovy ends the statement at the line break, so the second line became a statement of its own -- a unary plus on a String -- and the suite died with MissingMethodException: No signature of method: java.lang.String.positive() before reaching the COM_STMT_EXECUTE half. Nothing caught it because the suite is a docker suite and CI never runs those. Found by running the suite's body against a local 2-FE cluster, where it now passes end to end (the forwarded server-side prepared statement included). Trailing `+` keeps the concatenation inside one expression. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_013hRBG4Au5xYrRvs5T9y2CH
1 parent 5181cba commit d60a614

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎regression-test/suites/query_p0/test_mysql_forward_to_master.groovy‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,8 @@ suite("test_mysql_forward_to_master", "docker") {
8585
// result comes back shaped for the cursor the client asked for. A server-side prepared
8686
// statement has to be prepared while forwarding is off (a forwarded COM_STMT_PREPARE
8787
// is refused), so forwarding is switched on between PREPARE and EXECUTE.
88-
String followerUrl = "jdbc:mysql://${follower.host}:${follower.queryPort}/${context.dbName}"
89-
+ "?useServerPrepStmts=true&useCursorFetch=true&emulateUnsupportedPstmts=false&socketTimeout=30000"
88+
String followerUrl = "jdbc:mysql://${follower.host}:${follower.queryPort}/${context.dbName}" +
89+
"?useServerPrepStmts=true&useCursorFetch=true&emulateUnsupportedPstmts=false&socketTimeout=30000"
9090
connect(context.config.jdbcUser, context.config.jdbcPassword, followerUrl) {
9191
def connection = context.getConnection()
9292
connection.createStatement().withCloseable { control ->

0 commit comments

Comments
 (0)