You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit d3b3311
Browse filesBrowse the repository at this point in the historyBrowse files
[fix](fe) Close catalog driver and endpoint validation gaps
### What problem does this PR solve?
Issue Number: None
Related PR: #69588
Problem Summary: ALTER CATALOG could persist an unchecked driver_url while its
connector provider was unavailable. Restoring the plugin then consumed the URL
without statement-time validation. Reject interactive property updates without a
provider, while keeping degraded catalog replay unchanged. Also parse schemed
endpoints with URI host/port semantics so query, fragment, and userinfo cannot
hide an HMS destination from the configured SSRF probe. Exercise production
provider lookup and the real degraded replay path in the gate tests.
### Release note
ALTER CATALOG property updates require an available connector provider. With an
SSRF checker configured, HMS URI query, fragment, and userinfo components no
longer bypass destination checks. Replay and lazy rebuild remain unchanged.
### Check List (For Author)
- Test: Unit Test - 88 selected tests passed via run-fe-ut.sh; Maven validate
with Checkstyle and architecture gates; git diff --check
- Behavior changed: Yes - reject property ALTER without a provider and probe
the actual destination of schemed HMS URIs
- Does this need documentation: No
// Drop a leading scheme (thrift://, http://, ...) and any trailing path, leaving the authority.
426
-
Stringauthority = value;
427
-
intschemeIdx = authority.indexOf("://");
428
-
if (schemeIdx >= 0) {
429
-
authority = authority.substring(schemeIdx + 3);
430
-
}
431
-
intslashIdx = authority.indexOf('/');
432
-
if (slashIdx >= 0) {
433
-
authority = authority.substring(0, slashIdx);
434
-
}
435
428
try {
429
+
if (value.contains("://")) {
430
+
// Match the HMS client's URI semantics: query, fragment and userinfo do not name
431
+
// the socket destination. HostAndPort.fromParts also strips IPv6 brackets.
Copy file name to clipboardExpand all lines: fe/fe-core/src/test/java/org/apache/doris/datasource/plugin/PluginDrivenExternalCatalogConcurrencyTest.java
Copy file name to clipboardExpand all lines: fe/fe-core/src/test/java/org/apache/doris/datasource/plugin/PluginDrivenExternalCatalogDriverUrlGateTest.java
0 commit comments