Skip to content

Commit cffd088

Browse files
committed
[fix](iceberg) Add static_partition_null_keys, renumber field 19
branch-4.1 uses TIcebergTableSink field id 19 for static_partition_null_keys while master used the same id for nan_count_field_ids. Keep the shared field aligned across branches: reserve 19 for static_partition_null_keys and move nan_count_field_ids to 20. Both are still bound by name in the generated code, so no caller changes.
1 parent a74e711 commit cffd088

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

‎gensrc/thrift/DataSinks.thrift‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -494,12 +494,14 @@ struct TIcebergTableSink {
494494
17: optional TIcebergWriteType write_type = TIcebergWriteType.INSERT;
495495
// Unset keeps collection enabled for rolling upgrades with older FEs.
496496
18: optional bool collect_column_stats;
497+
// Thrift map values cannot be null. These keys distinguish SQL NULL from text and empty bytes.
498+
19: optional set<string> static_partition_null_keys;
497499
// Iceberg field ids of the FLOAT/DOUBLE fields whose NaN count would survive the table's metrics policy
498500
// (effective mode != none). Counting a NaN is an extra pass over the data -- unlike the other statistics,
499501
// which the parquet footer already carries -- so BE must not pay it for a field FE would then drop.
500502
// Unset or empty means count nothing: an older FE does not read nan_value_counts back, so counting for it
501503
// would be pure waste, and a table whose float fields are all metrics-disabled has nothing to report.
502-
19: optional list<i32> nan_count_field_ids;
504+
20: optional list<i32> nan_count_field_ids;
503505
}
504506

505507
struct TIcebergRewritableDeleteFileSet {

0 commit comments

Comments
 (0)