Repository navigation
Commit c8d9172
committed
[fix](fe) Fail the statement when FE rejects a final external-file report
### What problem does this PR solve?
Issue Number: None
Related PR: #69392
Problem Summary: When FE rejects a final external-file report (for example the
Iceberg commit-location check finds a file outside the sink's commit location),
QeProcessorImpl only answered BE with external_file_commit_data_accepted=false.
The fragment was never marked done and the coordinator status was never set.
BE treats the rejection as terminal: it removes the files and never resends the
report. The coordinator join therefore kept waiting on the fragment latch until
insert_timeout (4 hours by default), and the user saw a timeout instead of the
real reason.
Now QeProcessorImpl cancels the coordinator with the rejection reason before it
answers BE. Both coordinators' cancel release the fragment latch, so the INSERT
fails immediately with the validation error and the transaction is aborted.
### Release note
None
### Check List (For Author)
- Test: Unit Test (QeProcessorImplReportAckTest, run by CI)
- Behavior changed: Yes. A rejected final external-file report now fails the statement immediately instead of waiting until timeout.
- Does this need documentation: No1 parent bec29aa commit c8d9172
2 files changed
Lines changed: 38 additions & 3 deletions
File tree
- fe/fe-core/src
- main/java/org/apache/doris/qe
- test/java/org/apache/doris/qe
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
324 | 324 | | |
325 | 325 | | |
326 | 326 | | |
327 | | - | |
| 327 | + | |
| 328 | + | |
328 | 329 | | |
329 | 330 | | |
330 | 331 | | |
331 | 332 | | |
332 | 333 | | |
333 | | - | |
| 334 | + | |
| 335 | + | |
334 | 336 | | |
335 | 337 | | |
336 | 338 | | |
| |||
354 | 356 | | |
355 | 357 | | |
356 | 358 | | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
357 | 367 | | |
358 | 368 | | |
359 | 369 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
| |||
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
| 38 | + | |
37 | 39 | | |
38 | 40 | | |
39 | 41 | | |
| |||
82 | 84 | | |
83 | 85 | | |
84 | 86 | | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
85 | 91 | | |
86 | 92 | | |
87 | 93 | | |
88 | 94 | | |
89 | 95 | | |
90 | | - | |
| 96 | + | |
91 | 97 | | |
92 | 98 | | |
93 | 99 | | |
94 | 100 | | |
95 | 101 | | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
96 | 115 | | |
97 | 116 | | |
98 | 117 | | |
| |||
186 | 205 | | |
187 | 206 | | |
188 | 207 | | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
189 | 214 | | |
190 | 215 | | |
191 | 216 | | |
| |||
0 commit comments