Repository navigation
Commit c779dc5
branch-4.1: [test](jdbc) Assert SQL Server bit IN pushdown form and make filter checks selective (#64772)
### What problem does this PR solve?
Issue Number: #64464
Related PR: #64757 (the branch-4.1 fix this follows up on)
Problem Summary:
Test-only follow-up to #64757 (already merged into `branch-4.1`),
addressing review feedback on the SQL Server `bit` pushdown regression
test.
The merged test executed `select * from test_binary where bit_value in
('1', '0')` without asserting the pushed-down form, and because the IN
list covers every value of a `bit` column it matched all rows — so it
would still pass if the IN predicate were dropped, or rendered with
`TRUE`/`FALSE` instead of `1`/`0`.
This PR:
- adds an `explain` assertion that the pushed remote SQL renders the IN
with integer literals (`[bit_value] IN (1, 0)`);
- replaces the non-asserting executions with selective `order_qt` cases
(`= '0'` -> id=1, `= '1'` -> id=2,3) that fail if the filter is not
applied, with matching `.out` baselines.
No production code change — the boolean pushdown fix itself already
landed in `branch-4.1` via #64757.
### Release note
None
### Check List (For Author)
- Test
- [x] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test.
- Behavior changed:
- [x] No.
- [ ] Yes.
- Does this need documentation?
- [x] No.
- [ ] Yes.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 4.8 (1M context) <[email protected]>1 parent 57b4d23 commit c779dc5
2 files changed
Lines changed: 28 additions & 9 deletions
File tree
- regression-test
- data/external_table_p0/jdbc
- suites/external_table_p0/jdbc
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
184 | 184 | | |
185 | 185 | | |
186 | 186 | | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
187 | 199 | | |
188 | 200 | | |
189 | 201 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
142 | 142 | | |
143 | 143 | | |
144 | 144 | | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
149 | 149 | | |
150 | 150 | | |
151 | 151 | | |
| |||
154 | 154 | | |
155 | 155 | | |
156 | 156 | | |
157 | | - | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
162 | 169 | | |
163 | 170 | | |
164 | 171 | | |
| |||
0 commit comments