@@ -344,6 +344,142 @@ private static void nativeRequest(Configuration configuration, String root, Stri
344344 configuration .set (TvfGuard .PATH_KEY , path );
345345 }
346346
347+ @ Test
348+ void escapedListingComponentsAreCheckedBeforeDiscovery () throws Exception {
349+ Map <String , String > properties = readProperties ("viewfs://cluster/da\\ ta/*.csv" );
350+ properties .put ("fs.defaultFS" , "viewfs://cluster" );
351+ properties .put ("fs.viewfs.mounttable.cluster.link./data" , "file:///tmp" );
352+ properties .put ("fs.viewfs.mounttable.cluster.linkFallback" , "hdfs://remote/base" );
353+ Assertions .assertThrows (org .apache .doris .nereids .exceptions .AnalysisException .class ,
354+ () -> new HdfsTableValuedFunction (properties ));
355+ properties .put ("fs.viewfs.mounttable.cluster.link./data" , "hdfs://remote/data" );
356+ Assertions .assertDoesNotThrow (() -> new HdfsTableValuedFunction (properties ));
357+ Configuration actual = defaults (Collections .singletonMap (
358+ "fs.viewfs.mounttable.cluster.link./data" , "file:///tmp" ));
359+ properties .remove ("fs.viewfs.mounttable.cluster.link./data" );
360+ overlay (actual , HadoopTvfAdmission .protectJava (
361+ HadoopTvfAdmission .Access .HADOOP_READ , properties .get ("uri" ), properties ));
362+ Assertions .assertThrows (IOException .class ,
363+ () -> TvfGuard .check (URI .create ("viewfs://cluster" ), actual ));
364+ }
365+
366+ @ Test
367+ void globTraversalChecksIntermediateParentsAndEscapedDotSegments () {
368+ Map <String , String > properties = hdfs ("viewfs://cluster" );
369+ properties .put ("fs.viewfs.mounttable.cluster.link./data" , "file:///tmp" );
370+ properties .put ("fs.viewfs.mounttable.cluster.linkFallback" , "hdfs://remote/base" );
371+ for (String path : new String [] {"viewfs://cluster/da\\ ta/*/\\ .\\ ./other/*.csv" ,
372+ "viewfs://cluster/{da\\ ta/x,remote/y}/*.csv" }) {
373+ Assertions .assertThrows (org .apache .doris .nereids .exceptions .AnalysisException .class ,
374+ () -> HadoopTvfAdmission .check (HadoopTvfAdmission .Access .HADOOP_READ , path , properties , false ));
375+ }
376+ properties .put ("fs.viewfs.mounttable.cluster.link./data" , "hdfs://remote/data" );
377+ Assertions .assertDoesNotThrow (() -> HadoopTvfAdmission .check (HadoopTvfAdmission .Access .HADOOP_READ ,
378+ "viewfs://cluster/da\\ ta/\\ */file.csv" , properties , false ));
379+ properties .put ("fs.viewfs.mounttable.cluster.link./local" , "file:///tmp" );
380+ properties .put ("fs.viewfs.mounttable.cluster.link./literal\\ name" , "hdfs://remote/base" );
381+ Assertions .assertDoesNotThrow (() -> HadoopTvfAdmission .check (HadoopTvfAdmission .Access .JAVA_DELETE ,
382+ "viewfs://cluster/literal\\ name/file.csv" , properties ));
383+ }
384+
385+ @ Test
386+ void explicitJuiceFsUsesTheSameKnownRemoteProviderAsRuntime () throws Exception {
387+ for (boolean enabled : new boolean [] {false , true }) {
388+ Config .enable_local_tvf = enabled ;
389+ Map <String , String > properties = readProperties ("jfs://cluster/data.csv" );
390+ properties .put ("fs.defaultFS" , "jfs://cluster" );
391+ properties .put ("fs.jfs.impl" , "io.juicefs.JuiceFileSystem" );
392+ properties .put ("juicefs.cluster.meta" , "redis://meta:6379/1" );
393+ Assertions .assertDoesNotThrow (() -> new HdfsTableValuedFunction (properties ));
394+ properties .put ("fs.jfs.impl" , LocalFileSystem .class .getName ());
395+ Assertions .assertThrows (org .apache .doris .nereids .exceptions .AnalysisException .class ,
396+ () -> new HdfsTableValuedFunction (properties ));
397+ }
398+ }
399+
400+ @ Test
401+ void secureWasbDefaultAndDelegatedRoutesKeepRemoteAdmission () throws Exception {
402+ Configuration direct = defaults (Collections .emptyMap ());
403+ Assertions .assertEquals ("org.apache.hadoop.fs.azure.NativeAzureFileSystem$Secure" ,
404+ FileSystem .getFileSystemClass ("wasbs" , direct ).getName ());
405+ direct .set (TvfGuard .POLICY_KEY , TvfGuard .NATIVE_POLICY );
406+ nativeRequest (
direct ,
"wasbs://[email protected] " ,
"/exports/file" );
407+ Assertions .
assertDoesNotThrow (() ->
TvfGuard .
check (
URI .
create (
"wasbs://[email protected] " ),
direct ));
408+ Configuration delegated = new Configuration (direct );
409+ nativeRequest (delegated , "viewfs://cluster" , "/exports/file" );
410+ delegated .set ("fs.viewfs.mounttable.cluster.link./exports" ,
411+ "wasbs://[email protected] /base" );
412+ Assertions .assertDoesNotThrow (() -> TvfGuard .check (URI .create ("viewfs://cluster" ), delegated ));
413+ delegated .set ("fs.wasbs.impl" , LocalFileSystem .class .getName ());
414+ Assertions .assertThrows (IOException .class , () -> TvfGuard .check (URI .create ("viewfs://cluster" ), delegated ));
415+ }
416+
417+ @ Test
418+ void guardedSnapshotDisablesOnlyViewFsInnerCache () throws Exception {
419+ Configuration source = defaults (Collections .emptyMap ());
420+ source .setBoolean ("fs.viewfs.enable.inner.cache" , true );
421+ Configuration frozen = TvfGuard .prepareJavaRead (source , new Path ("hdfs://runtime/data.csv" ), TvfGuard .NATIVE_POLICY );
422+ Assertions .assertFalse (frozen .getBoolean ("fs.viewfs.enable.inner.cache" , true ));
423+ Assertions .assertTrue (source .getBoolean ("fs.viewfs.enable.inner.cache" , false ));
424+ Assertions .assertSame (source , TvfGuard .prepareJavaRead (source , new Path ("file:///unused" ), null ));
425+ }
426+
427+ @ Test
428+ void noGlobBackslashMatchesTheBranchListingConsumer () {
429+ Map <String , String > properties = hdfs ("viewfs://cluster" );
430+ properties .put ("fs.viewfs.mounttable.cluster.link./data" , "file:///tmp" );
431+ properties .put ("fs.viewfs.mounttable.cluster.linkFallback" , "hdfs://remote/base" );
432+ Assertions .assertDoesNotThrow (() -> HadoopTvfAdmission .check (
433+ HadoopTvfAdmission .Access .HADOOP_READ , "viewfs://cluster/da\\ ta/file.csv" , properties , false ));
434+ }
435+
436+ @ Test
437+ void nestedViewFsCaseDistinctTargetsKeepTheirActualIdentityAfterWarmup () throws Exception {
438+ Configuration source = defaults (Collections .emptyMap ());
439+ source .set (TvfGuard .POLICY_KEY , TvfGuard .NATIVE_POLICY );
440+ nativeRequest (source , "viewfs://outer" , "/warm/file.csv" );
441+ source .setBoolean ("fs.viewfs.enable.inner.cache" , true );
442+ source .set ("fs.viewfs.mounttable.outer.link./warm" , "viewfs://A/remote" );
443+ source .set ("fs.viewfs.mounttable.outer.link./evil" , "viewfs://a/secret" );
444+ source .set ("fs.viewfs.mounttable.A.link./remote" , "hdfs://nn/base" );
445+ source .set ("fs.viewfs.mounttable.A.link./secret" , "file:///unused-local" );
446+ source .set ("fs.viewfs.mounttable.a.linkFallback" , "hdfs://nn/lower" );
447+ java .util .List <String > accesses = new java .util .ArrayList <>();
448+ LocalFileSystem local = Mockito .mock (LocalFileSystem .class );
449+ Mockito .when (local .getUri ()).thenReturn (URI .create ("file:///" ));
450+ Mockito .when (local .getWorkingDirectory ()).thenReturn (new Path ("/" ));
451+ try (MockedStatic <ReflectionUtils > factory = Mockito .mockStatic (
452+ ReflectionUtils .class , Mockito .CALLS_REAL_METHODS )) {
453+ factory .when (() -> ReflectionUtils .newInstance (Mockito .eq (DistributedFileSystem .class ),
454+ Mockito .any (Configuration .class ))).thenAnswer (invocation -> {
455+ DistributedFileSystem remote = Mockito .mock (DistributedFileSystem .class );
456+ Mockito .when (remote .getConf ()).thenReturn (invocation .getArgument (1 ));
457+ Mockito .when (remote .getUri ()).thenReturn (URI .create ("hdfs://nn" ));
458+ Mockito .when (remote .getWorkingDirectory ()).thenReturn (new Path ("/" ));
459+ Mockito .when (remote .getFileStatus (Mockito .any (Path .class ))).thenAnswer (call -> {
460+ Path path = call .getArgument (0 );
461+ accesses .add (path .toUri ().getPath ());
462+ return new org .apache .hadoop .fs .FileStatus (1 , false , 1 , 1 , 0 , path );
463+ });
464+ return remote ;
465+ });
466+ factory .when (() -> ReflectionUtils .newInstance (Mockito .eq (LocalFileSystem .class ),
467+ Mockito .any (Configuration .class ))).thenReturn (local );
468+ FileSystem outer = FileSystem .newInstance (URI .create ("viewfs://outer" ), source );
469+ TvfGuard .Context context = TvfGuard .takeNativeContext ();
470+ Assertions .assertNotNull (context );
471+ Assertions .assertFalse (outer .getConf ().getBoolean ("fs.viewfs.enable.inner.cache" , true ));
472+ outer .getFileStatus (new Path ("/warm/file.csv" ));
473+ context .checkNative ("viewfs://outer" , "/evil/file.csv" );
474+ outer .getFileStatus (new Path ("/evil/file.csv" ));
475+ outer .getFileStatus (new Path ("/evil/next.csv" ));
476+ Assertions .assertTrue (accesses .contains ("/base/file.csv" ), accesses .toString ());
477+ Assertions .assertTrue (accesses .contains ("/lower/secret/file.csv" ), accesses .toString ());
478+ Assertions .assertTrue (accesses .contains ("/lower/secret/next.csv" ), accesses .toString ());
479+ Mockito .verify (local , Mockito .never ()).getFileStatus (Mockito .any (Path .class ));
480+ }
481+ }
482+
347483 private Configuration defaults (Map <String , String > entries ) throws Exception {
348484 StringBuilder xml = new StringBuilder ("<configuration>" );
349485 entries .forEach ((key , value ) -> xml .append ("<property><name>" ).append (key )
0 commit comments