You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit c5ee12c
Browse filesBrowse the repository at this point in the historyBrowse files
committed
[test](iceberg) Port the branch-4.1 schema matrix assertions for joins, branch reads and DESC comments
### What problem does this PR solve?
Issue Number: None
Related PR: #66246, #66007, #66112
Problem Summary: branch-4.1 #66246 backported #66112, #66223 and #66007
and added test assertions that master never got. Master implements the
behavior, but its tests either lack the checks or still assert an old,
negative contract:
- test_iceberg_schema_dual_relation_matrix: a historical relation joined
with the latest relation of the same table, in either order, keeps each
relation's own schema (old_name on the snapshot, new_name on the latest
table).
- test_iceberg_schema_time_travel_matrix: a branch read uses the table's
current schema. Master only checked that the old name is unknown and
that nested types are the promoted ones, and called both a leak. The
suite now also reads the renamed and re-added fields from the branch
head, which come back NULL instead of old values.
- test_iceberg_schema_metadata_atomicity_matrix: with
show_column_comment_in_describe enabled, DESC shows the top-level and
nested Iceberg field comments. Master asserted that they were absent,
which only held because the variable is off by default.
- CreateTableCommandTest: an existing CTAS target fails with "already
exists" before any sink is built. #67545 replaced this case with the
configuration preflight case; it is added back next to that case.
An audit of the rest of #66246 against master found no other missing test
or behavior, apart from a deliberate difference in Hudi plain reads,
which this change leaves alone.
### Release note
None
### Check List (For Author)
- Test: Regression test / Unit Test
- The three suites pass on a local Iceberg docker environment against
master. test_iceberg_schema_time_travel_matrix.out is generated by
the regression script and has the same rows as on branch-4.2
- CreateTableCommandTest: all 4 cases pass
- Behavior changed: No
- Does this need documentation: No
Co-authored-by: Gabriel <[email protected]>
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
0 commit comments