Skip to content

Commit c5a9b97

Browse files
committed
[fix](function) Fix HLL downsample constant column access
### What problem does this PR solve? Issue Number: None Related PR: #69257, #69679 Problem Summary: The constant-expression API migration missed two HLL downsample calls, breaking the BE build. Invoke ConstantExprResult::column_ptr() when reading the constant arguments. ### Release note None ### Check List (For Author) - Test: Local ASAN BE build passed (`./build.sh --be -j 48`). - Behavior changed: No - Does this need documentation: No
1 parent e8e4444 commit c5a9b97

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎be/src/exprs/function/function_datasketches_hll.cpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,13 +97,13 @@ class FunctionDataSketchesHllDownsample : public IFunction {
9797
// `10 + crc32('') % 2`, may not be evaluated in open either, then it is read from the
9898
// first row in execute.
9999
if (context->is_col_constant(1)) {
100-
RETURN_IF_ERROR(parse_lg_k(*context->get_constant_col(1)->column_ptr, state->lg_k));
100+
RETURN_IF_ERROR(parse_lg_k(*context->get_constant_col(1)->column_ptr(), state->lg_k));
101101
}
102102
if (context->get_num_args() == 2) {
103103
state->tgt_type = datasketches::HLL_4;
104104
} else if (context->is_col_constant(2)) {
105105
RETURN_IF_ERROR(
106-
parse_tgt_type(*context->get_constant_col(2)->column_ptr, state->tgt_type));
106+
parse_tgt_type(*context->get_constant_col(2)->column_ptr(), state->tgt_type));
107107
}
108108
context->set_function_state(scope, state);
109109
return Status::OK();

0 commit comments

Comments
 (0)