Skip to content

Commit bbd7d55

Browse files
authored
[fix] remove useless const_cast and explain const_cast for vec (5) (#56609)
### What problem does this PR solve? go through whole be/ and find all const_cast Issue Number: #55057 Problem Summary: 1. remove useless const_cast 2. explain why using const_cast does not result in undefined behavior 3. don't modify some const_cast (1) some code in DBUG_EXECUTE_IF or test file (2) underlying data structures, such as cow (3) const_cast<const T*>
1 parent 11d48b6 commit bbd7d55

9 files changed

Lines changed: 38 additions & 35 deletions

‎be/src/vec/data_types/data_type_factory.cpp‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -472,12 +472,12 @@ DataTypePtr DataTypeFactory::create_data_type(const PrimitiveType primitive_type
472472
nested = vectorized::create_decimal(precision, scale, false);
473473
break;
474474
// Just Mock A NULL Type in Vec Exec Engine
475-
case TYPE_NULL:
476-
nested = std::make_shared<vectorized::DataTypeUInt8>();
477-
const_cast<vectorized::DataTypeUInt8&>(
478-
reinterpret_cast<const vectorized::DataTypeUInt8&>(*nested))
479-
.set_null_literal(true);
475+
case TYPE_NULL: {
476+
auto temp_nested = std::make_shared<vectorized::DataTypeUInt8>();
477+
temp_nested->set_null_literal(true);
478+
nested = std::move(temp_nested);
480479
break;
480+
}
481481
case TYPE_VARBINARY:
482482
nested = std::make_shared<vectorized::DataTypeVarbinary>(len, TYPE_VARBINARY);
483483
break;

‎be/src/vec/data_types/data_type_hll.cpp‎

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ char* DataTypeHLL::serialize(const IColumn& column, char* buf, int be_exec_versi
5656
buf += allocate_len_size;
5757

5858
for (size_t i = 0; i < real_need_copy_num; ++i) {
59-
auto& hll = const_cast<HyperLogLog&>(data_column.get_element(i));
59+
const auto& hll = data_column.get_element(i);
6060
size_t actual_size = hll.serialize(reinterpret_cast<uint8_t*>(buf));
6161
hll_size_array[i] = actual_size;
6262
buf += actual_size;
@@ -77,7 +77,7 @@ char* DataTypeHLL::serialize(const IColumn& column, char* buf, int be_exec_versi
7777
buf += allocate_len_size;
7878

7979
for (size_t i = 0; i < row_num; ++i) {
80-
auto& hll = const_cast<HyperLogLog&>(data_column.get_element(i));
80+
auto& hll = data_column.get_element(i);
8181
size_t actual_size = hll.serialize(reinterpret_cast<uint8_t*>(buf));
8282
hll_size_array[i + 1] = actual_size;
8383
buf += actual_size;
@@ -152,7 +152,7 @@ int64_t DataTypeHLL::get_uncompressed_serialized_bytes(const IColumn& column,
152152
auto allocate_len_size = sizeof(size_t) * real_need_copy_num;
153153
size_t allocate_content_size = 0;
154154
for (size_t i = 0; i < real_need_copy_num; ++i) {
155-
auto& hll = const_cast<HyperLogLog&>(data_column.get_element(i));
155+
auto& hll = data_column.get_element(i);
156156
allocate_content_size += hll.max_serialized_size();
157157
}
158158
return size + allocate_len_size + allocate_content_size;
@@ -163,7 +163,7 @@ int64_t DataTypeHLL::get_uncompressed_serialized_bytes(const IColumn& column,
163163
auto allocate_len_size = sizeof(size_t) * (column.size() + 1);
164164
size_t allocate_content_size = 0;
165165
for (size_t i = 0; i < column.size(); ++i) {
166-
auto& hll = const_cast<HyperLogLog&>(data_column.get_element(i));
166+
auto& hll = data_column.get_element(i);
167167
allocate_content_size += hll.max_serialized_size();
168168
}
169169

@@ -180,9 +180,8 @@ Status DataTypeHLL::check_column(const IColumn& column) const {
180180
}
181181

182182
void DataTypeHLL::serialize_as_stream(const HyperLogLog& cvalue, BufferWritable& buf) {
183-
auto& value = const_cast<HyperLogLog&>(cvalue);
184-
std::string memory_buffer(value.max_serialized_size(), '0');
185-
size_t actual_size = value.serialize((uint8_t*)memory_buffer.data());
183+
std::string memory_buffer(cvalue.max_serialized_size(), '0');
184+
size_t actual_size = cvalue.serialize((uint8_t*)memory_buffer.data());
186185
memory_buffer.resize(actual_size);
187186
buf.write_binary(memory_buffer);
188187
}

‎be/src/vec/data_types/data_type_quantilestate.cpp‎

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ int64_t DataTypeQuantileState::get_uncompressed_serialized_bytes(const IColumn&
4646
auto allocate_len_size = sizeof(size_t) * real_need_copy_num;
4747
size_t allocate_content_size = 0;
4848
for (size_t i = 0; i < real_need_copy_num; ++i) {
49-
auto& quantile_state = const_cast<QuantileState&>(data_column.get_element(i));
49+
auto& quantile_state = data_column.get_element(i);
5050
allocate_content_size += quantile_state.get_serialized_size();
5151
}
5252
return size + allocate_len_size + allocate_content_size;
@@ -57,7 +57,7 @@ int64_t DataTypeQuantileState::get_uncompressed_serialized_bytes(const IColumn&
5757
auto allocate_len_size = sizeof(size_t) * (column.size() + 1);
5858
size_t allocate_content_size = 0;
5959
for (size_t i = 0; i < column.size(); ++i) {
60-
auto& quantile_state = const_cast<QuantileState&>(data_column.get_element(i));
60+
auto& quantile_state = data_column.get_element(i);
6161
allocate_content_size += quantile_state.get_serialized_size();
6262
}
6363

@@ -76,14 +76,14 @@ char* DataTypeQuantileState::serialize(const IColumn& column, char* buf,
7676
// serialize the quantile_state size array, row num saves at index 0
7777
auto* meta_ptr = (size_t*)buf;
7878
for (size_t i = 0; i < real_need_copy_num; ++i) {
79-
auto& quantile_state = const_cast<QuantileState&>(data_column.get_element(i));
79+
auto& quantile_state = data_column.get_element(i);
8080
unaligned_store<size_t>(&meta_ptr[i], quantile_state.get_serialized_size());
8181
}
8282

8383
// serialize each quantile_state
8484
char* data_ptr = buf + sizeof(size_t) * real_need_copy_num;
8585
for (size_t i = 0; i < real_need_copy_num; ++i) {
86-
auto& quantile_state = const_cast<QuantileState&>(data_column.get_element(i));
86+
auto& quantile_state = data_column.get_element(i);
8787
quantile_state.serialize((uint8_t*)data_ptr);
8888
data_ptr += unaligned_load<size_t>(&meta_ptr[i]);
8989
}
@@ -96,14 +96,14 @@ char* DataTypeQuantileState::serialize(const IColumn& column, char* buf,
9696
size_t* meta_ptr = (size_t*)buf;
9797
meta_ptr[0] = column.size();
9898
for (size_t i = 0; i < meta_ptr[0]; ++i) {
99-
auto& quantile_state = const_cast<QuantileState&>(data_column.get_element(i));
99+
auto& quantile_state = data_column.get_element(i);
100100
unaligned_store<size_t>(&meta_ptr[i + 1], quantile_state.get_serialized_size());
101101
}
102102

103103
// serialize each quantile_state
104104
char* data_ptr = buf + sizeof(size_t) * (meta_ptr[0] + 1);
105105
for (size_t i = 0; i < meta_ptr[0]; ++i) {
106-
auto& quantile_state = const_cast<QuantileState&>(data_column.get_element(i));
106+
auto& quantile_state = data_column.get_element(i);
107107
quantile_state.serialize((uint8_t*)data_ptr);
108108
data_ptr += unaligned_load<size_t>(&meta_ptr[i + 1]);
109109
}
@@ -163,10 +163,9 @@ Status DataTypeQuantileState::check_column(const IColumn& column) const {
163163
}
164164

165165
void DataTypeQuantileState::serialize_as_stream(const QuantileState& cvalue, BufferWritable& buf) {
166-
auto& value = const_cast<QuantileState&>(cvalue);
167166
std::string memory_buffer;
168-
memory_buffer.resize(value.get_serialized_size());
169-
value.serialize(const_cast<uint8_t*>(reinterpret_cast<uint8_t*>(memory_buffer.data())));
167+
memory_buffer.resize(cvalue.get_serialized_size());
168+
cvalue.serialize(reinterpret_cast<uint8_t*>(memory_buffer.data()));
170169
buf.write_binary(memory_buffer);
171170
}
172171

‎be/src/vec/data_types/data_type_variant.cpp‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,8 @@ int64_t DataTypeVariant::get_uncompressed_serialized_bytes(const IColumn& column
6767
int be_exec_version) const {
6868
const auto& column_variant = assert_cast<const ColumnVariant&>(column);
6969
if (!column_variant.is_finalized()) {
70+
// Icolumn originates from MutablePtr or block, and therefore can be modified.
71+
// todo: We should reconsider the logic here, why are we using finalize() in this context?
7072
const_cast<ColumnVariant&>(column_variant).finalize();
7173
}
7274

@@ -105,6 +107,8 @@ int64_t DataTypeVariant::get_uncompressed_serialized_bytes(const IColumn& column
105107
char* DataTypeVariant::serialize(const IColumn& column, char* buf, int be_exec_version) const {
106108
const auto& column_variant = assert_cast<const ColumnVariant&>(column);
107109
if (!column_variant.is_finalized()) {
110+
// Icolumn originates from block, and therefore can be modified.
111+
// todo: We should reconsider the logic here, why are we using finalize() in this context?
108112
const_cast<ColumnVariant&>(column_variant).finalize();
109113
}
110114
#ifndef NDEBUG

‎be/src/vec/data_types/serde/data_type_hll_serde.cpp‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ Status DataTypeHLLSerDe::write_column_to_pb(const IColumn& column, PValues& resu
8989
auto row_count = cast_set<int>(end - start);
9090
result.mutable_bytes_value()->Reserve(row_count);
9191
for (size_t row_num = start; row_num < end; ++row_num) {
92-
auto& value = const_cast<HyperLogLog&>(data_column.get_element(row_num));
92+
auto& value = data_column.get_element(row_num);
9393
std::string memory_buffer(value.max_serialized_size(), '0');
9494
value.serialize((uint8_t*)memory_buffer.data());
9595
result.add_bytes_value(memory_buffer.data(), memory_buffer.size());
@@ -111,7 +111,7 @@ void DataTypeHLLSerDe::write_one_cell_to_jsonb(const IColumn& column, JsonbWrite
111111
int64_t row_num) const {
112112
result.writeKey(cast_set<JsonbKeyValue::keyid_type>(col_id));
113113
const auto& data_column = assert_cast<const ColumnHLL&>(column);
114-
auto& hll_value = const_cast<HyperLogLog&>(data_column.get_element(row_num));
114+
auto& hll_value = data_column.get_element(row_num);
115115
auto size = hll_value.max_serialized_size();
116116
auto* ptr = reinterpret_cast<char*>(arena.alloc(size));
117117
size_t actual_size = hll_value.serialize((uint8_t*)ptr);
@@ -136,7 +136,7 @@ Status DataTypeHLLSerDe::write_column_to_arrow(const IColumn& column, const Null
136136
RETURN_IF_ERROR(checkArrowStatus(builder.AppendNull(), column.get_name(),
137137
array_builder->type()->name()));
138138
} else {
139-
auto& hll_value = const_cast<HyperLogLog&>(col.get_element(string_i));
139+
auto& hll_value = col.get_element(string_i);
140140
std::string memory_buffer(hll_value.max_serialized_size(), '0');
141141
hll_value.serialize((uint8_t*)memory_buffer.data());
142142
RETURN_IF_ERROR(checkArrowStatus(
@@ -192,7 +192,7 @@ Status DataTypeHLLSerDe::write_column_to_orc(const std::string& timezone, const
192192
size_t total_size = 0;
193193
for (size_t row_id = start; row_id < end; row_id++) {
194194
if (cur_batch->notNull[row_id] == 1) {
195-
auto hll_value = const_cast<HyperLogLog&>(col_data.get_element(row_id));
195+
auto hll_value = col_data.get_element(row_id);
196196
size_t len = hll_value.max_serialized_size();
197197
total_size += len;
198198
}
@@ -207,7 +207,7 @@ Status DataTypeHLLSerDe::write_column_to_orc(const std::string& timezone, const
207207
size_t offset = 0;
208208
for (size_t row_id = start; row_id < end; row_id++) {
209209
if (cur_batch->notNull[row_id] == 1) {
210-
auto hll_value = const_cast<HyperLogLog&>(col_data.get_element(row_id));
210+
auto hll_value = col_data.get_element(row_id);
211211
size_t len = hll_value.max_serialized_size();
212212
if (offset + len > total_size) {
213213
return Status::InternalError(

‎be/src/vec/data_types/serde/data_type_quantilestate_serde.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ void DataTypeQuantileStateSerDe::write_one_cell_to_jsonb(const IColumn& column,
2525
Arena& arena, int32_t col_id,
2626
int64_t row_num) const {
2727
const auto& col = reinterpret_cast<const ColumnQuantileState&>(column);
28-
auto& val = const_cast<QuantileState&>(col.get_element(row_num));
28+
auto& val = col.get_element(row_num);
2929
size_t actual_size = val.get_serialized_size();
3030
auto* ptr = arena.alloc(actual_size);
3131
val.serialize((uint8_t*)ptr);

‎be/src/vec/data_types/serde/data_type_quantilestate_serde.h‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ class DataTypeQuantileStateSerDe : public DataTypeSerDe {
108108
RETURN_IF_ERROR(checkArrowStatus(builder.AppendNull(), column.get_name(),
109109
array_builder->type()->name()));
110110
} else {
111-
auto& quantile_state_value = const_cast<QuantileState&>(col.get_element(string_i));
111+
auto& quantile_state_value = col.get_element(string_i);
112112
std::string memory_buffer(quantile_state_value.get_serialized_size(), '0');
113113
quantile_state_value.serialize((uint8_t*)memory_buffer.data());
114114
RETURN_IF_ERROR(
@@ -146,7 +146,7 @@ class DataTypeQuantileStateSerDe : public DataTypeSerDe {
146146
size_t total_size = 0;
147147
for (size_t row_id = start; row_id < end; row_id++) {
148148
if (cur_batch->notNull[row_id] == 1) {
149-
auto quantilestate_value = const_cast<QuantileState&>(col_data.get_element(row_id));
149+
auto quantilestate_value = col_data.get_element(row_id);
150150
size_t len = quantilestate_value.get_serialized_size();
151151
total_size += len;
152152
}
@@ -162,7 +162,7 @@ class DataTypeQuantileStateSerDe : public DataTypeSerDe {
162162
size_t offset = 0;
163163
for (size_t row_id = start; row_id < end; row_id++) {
164164
if (cur_batch->notNull[row_id] == 1) {
165-
auto quantilestate_value = const_cast<QuantileState&>(col_data.get_element(row_id));
165+
auto quantilestate_value = col_data.get_element(row_id);
166166
size_t len = quantilestate_value.get_serialized_size();
167167
if (offset + len > total_size) {
168168
return Status::InternalError(
@@ -205,7 +205,7 @@ Status DataTypeQuantileStateSerDe::_write_column_to_mysql(const IColumn& column,
205205

206206
if (_return_object_as_string) {
207207
const auto col_index = index_check_const(row_idx, col_const);
208-
auto& quantile_value = const_cast<QuantileState&>(data_column.get_element(col_index));
208+
auto& quantile_value = data_column.get_element(col_index);
209209
size_t size = quantile_value.get_serialized_size();
210210
std::unique_ptr<char[]> buf = std::make_unique_for_overwrite<char[]>(size);
211211
quantile_value.serialize((uint8_t*)buf.get());

‎be/src/vec/data_types/serde/data_type_string_serde.cpp‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -328,6 +328,7 @@ Status DataTypeStringSerDeBase<ColumnType>::write_column_to_orc(
328328

329329
for (auto row_id = start; row_id < end; row_id++) {
330330
const auto& ele = assert_cast<const ColumnType&>(column).get_data_at(row_id);
331+
// to adapt to orc::Writer, no modifications will be made. so can use const_cast
331332
cur_batch->data[row_id] = const_cast<char*>(ele.data);
332333
cur_batch->length[row_id] = ele.size;
333334
}

‎be/src/vec/data_types/serde/data_type_string_serde.h‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@ class IColumn;
3838
class Arena;
3939
#include "common/compile_check_begin.h"
4040

41-
inline void escape_string(const char* src, size_t* len, char escape_char) {
41+
inline void escape_string(char* src, size_t* len, char escape_char) {
4242
const char* start = src;
43-
char* dest_ptr = const_cast<char*>(src);
43+
char* dest_ptr = src;
4444
const char* end = src + *len;
4545
bool escape_next_char = false;
4646

@@ -66,9 +66,9 @@ inline void escape_string(const char* src, size_t* len, char escape_char) {
6666
}
6767

6868
// specially escape quote with double quote
69-
inline void escape_string_for_csv(const char* src, size_t* len, char escape_char, char quote_char) {
69+
inline void escape_string_for_csv(char* src, size_t* len, char escape_char, char quote_char) {
7070
const char* start = src;
71-
char* dest_ptr = const_cast<char*>(src);
71+
char* dest_ptr = src;
7272
const char* end = src + *len;
7373
bool escape_next_char = false;
7474

0 commit comments

Comments
 (0)