Repository navigation
Commit b562478
committed
[fix](be) Pass peer tablet IDs to startup cache restoration
### What problem does this PR solve?
Issue Number: None
Problem Summary: Peer cache requests carried a tablet ID in rowset_meta, but
the server left CacheContext.tablet_id at zero. During startup, lazy cache
restoration therefore queried the wrong metadata prefix and missed persisted
blocks. Pass the supplied tablet ID to get_or_set while preserving the zero
default for older clients that omit rowset_meta. Cover both request versions
with a restart test, and verify that background restoration preserves cache
accounting and the block objects already restored synchronously.
### Release note
Peer reads can restore persisted cache blocks under the requested tablet
before background cache loading finishes.
### Check List (For Author)
- Test: Unit Test
- Reproduced the peer startup miss before the fix; the legacy request passed.
- Passed 65 related ASAN unit tests using run-be-ut.sh, including peer
reads, cache metadata, all five lazy-restore cases, and both peer
startup request versions.
- Passed clang-format v16, check-format, build hygiene, and git diff --check.
- clang-tidy: no diagnostics on modified source lines; test checks passed.
The existing peer handler cognitive-complexity warning remains (58 > 50).
- Used GLIBC_COMPATIBILITY=OFF for the local unit-test link, as in the
preceding cache restoration validation; no production build options changed.
- Behavior changed: Yes; peer requests use their supplied tablet ID for cache restoration.
- Does this need documentation: No1 parent f8f8121 commit b562478
3 files changed
Lines changed: 101 additions & 1 deletion
File tree
- be
- src/cloud
- test/io/cache
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
724 | 724 | | |
725 | 725 | | |
726 | 726 | | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
727 | 731 | | |
728 | 732 | | |
729 | 733 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
892 | 892 | | |
893 | 893 | | |
894 | 894 | | |
| 895 | + | |
| 896 | + | |
| 897 | + | |
| 898 | + | |
| 899 | + | |
| 900 | + | |
| 901 | + | |
| 902 | + | |
| 903 | + | |
| 904 | + | |
| 905 | + | |
| 906 | + | |
| 907 | + | |
| 908 | + | |
895 | 909 | | |
896 | 910 | | |
897 | 911 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
142 | 142 | | |
143 | 143 | | |
144 | 144 | | |
145 | | - | |
| 145 | + | |
| 146 | + | |
146 | 147 | | |
147 | 148 | | |
148 | 149 | | |
| 150 | + | |
149 | 151 | | |
150 | 152 | | |
151 | 153 | | |
| |||
551 | 553 | | |
552 | 554 | | |
553 | 555 | | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
554 | 559 | | |
555 | 560 | | |
556 | 561 | | |
| |||
1005 | 1010 | | |
1006 | 1011 | | |
1007 | 1012 | | |
| 1013 | + | |
| 1014 | + | |
| 1015 | + | |
| 1016 | + | |
| 1017 | + | |
| 1018 | + | |
| 1019 | + | |
| 1020 | + | |
| 1021 | + | |
| 1022 | + | |
| 1023 | + | |
| 1024 | + | |
| 1025 | + | |
| 1026 | + | |
| 1027 | + | |
| 1028 | + | |
| 1029 | + | |
| 1030 | + | |
| 1031 | + | |
| 1032 | + | |
| 1033 | + | |
| 1034 | + | |
| 1035 | + | |
| 1036 | + | |
| 1037 | + | |
| 1038 | + | |
| 1039 | + | |
| 1040 | + | |
| 1041 | + | |
| 1042 | + | |
| 1043 | + | |
| 1044 | + | |
| 1045 | + | |
| 1046 | + | |
| 1047 | + | |
| 1048 | + | |
| 1049 | + | |
| 1050 | + | |
| 1051 | + | |
| 1052 | + | |
| 1053 | + | |
| 1054 | + | |
| 1055 | + | |
| 1056 | + | |
| 1057 | + | |
| 1058 | + | |
| 1059 | + | |
| 1060 | + | |
| 1061 | + | |
| 1062 | + | |
| 1063 | + | |
| 1064 | + | |
| 1065 | + | |
| 1066 | + | |
| 1067 | + | |
| 1068 | + | |
| 1069 | + | |
| 1070 | + | |
| 1071 | + | |
| 1072 | + | |
| 1073 | + | |
| 1074 | + | |
| 1075 | + | |
| 1076 | + | |
| 1077 | + | |
| 1078 | + | |
| 1079 | + | |
| 1080 | + | |
| 1081 | + | |
| 1082 | + | |
| 1083 | + | |
| 1084 | + | |
| 1085 | + | |
| 1086 | + | |
| 1087 | + | |
| 1088 | + | |
| 1089 | + | |
1008 | 1090 | | |
1009 | 1091 | | |
1010 | 1092 | | |
| |||
0 commit comments