You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit b21ac40
Browse filesBrowse the repository at this point in the historyBrowse files
[fix](be) Preserve point-query I/O context when resolving commit TSO
### What problem does this PR solve?
Issue Number: None
Related PR: #68097
Problem Summary: A point query requesting commit TSO fetched that column through
an independent helper with local statistics and no query I/O context. For a
multi-version rowset with a cold physical TSO page, this bypassed the query's
file-cache write limiter and omitted detailed read statistics from its profile.
Always classify TSO as unavailable from JSONB. Build explicit row-store and
missing-column projections, skip empty JSONB projections, and resolve TSO through
the existing missing-column loop with the pinned source rowset. Reuse query I/O
context and limiter, and use the same statistics object as print_profile for all
point-query reads. Preserve delete-sign reads and restrictions on ordinary missing
columns when column-store access is disabled. Remove the independent TSO fetch,
placeholder rollback and redundant projection-set copies.
### Release note
Preserve point-query file-cache write limits and detailed I/O statistics when
reading commit TSO, including physical TSO pages in multi-version rowsets.
### Check List (For Author)
- Test: Unit Test: 85 tests in 8 suites passed under ASAN_UT via run-be-ut.sh -j 96.
Covers row-store projections, ordinary column restrictions, delete-sign reads,
physical multi-version TSO with zero/exhausted cache-write budgets, an unlimited
control, query statistics, and the existing logical TSO/cache/historical paths.
The real remote-cache reader uses a local file as the object-storage stand-in.
Regression test: extended tso_p0/test_commit_tso_reader_paths; not run locally.
Manual test: clang-format 16, build hygiene and git diff --check passed.
clang-tidy attempted; existing core/types.h:576 unmatched NOLINTEND blocks a clean
result. New diagnostics were corrected; the check is not reported as passed.
- Behavior changed: Yes. TSO uses the normal missing-column I/O context and
profile statistics; JSONB never supplies its value.
- Does this need documentation: No.
0 commit comments