Repository navigation
Commit af6a803
committed
[fix](be) Reserve nullable spill cuts and fill peer results by range
### What problem does this PR solve?
Issue Number: None
Related PR: #68500
Problem Summary: Window spill replay estimated a retained input slice from serialized row bytes. A NULL fixed-width nullable value serializes without its nested value, but ColumnNullable::cut copies both the null map and nested storage, so a wide all-NULL slice could be admitted with too little memory. Use the in-memory type width for non-constant fixed-width columns while preserving the existing variable-width and constant paths. Replay also evaluated PERCENT_RANK and CUME_DIST once per row even though each peer/output intersection has a single result; fill that intersection in one operation while retaining cancellation checks. Add focused storage-budget and cross-Block/sidecar peer tests.
### Release note
Window spill replay accounts for fixed-width nullable input slices and fills peer results by range.
### Check List (For Author)
- Test: Regression test and compile checks
- Regression test: spill_p0/window_function_spill passed with an isolated ASAN BE and FE cluster.
- Unit Test: focused test source compiled; execution was blocked by pre-existing function_string_test.cpp compile errors in the standard BE UT runner.
- Manual test: None.
- Behavior changed: Yes (spill replay reservation and peer-result fill strategy; SQL results unchanged).
- Does this need documentation: No.1 parent cccbed2 commit af6a803
2 files changed
Lines changed: 126 additions & 7 deletions
File tree
- be
- src/exec/operator
- test/exec/operator
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| 28 | + | |
28 | 29 | | |
29 | 30 | | |
30 | 31 | | |
| |||
257 | 258 | | |
258 | 259 | | |
259 | 260 | | |
260 | | - | |
261 | | - | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
262 | 269 | | |
263 | 270 | | |
264 | 271 | | |
| |||
424 | 431 | | |
425 | 432 | | |
426 | 433 | | |
427 | | - | |
428 | | - | |
| 434 | + | |
| 435 | + | |
429 | 436 | | |
430 | 437 | | |
431 | | - | |
| 438 | + | |
432 | 439 | | |
433 | 440 | | |
434 | 441 | | |
435 | 442 | | |
436 | 443 | | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
437 | 448 | | |
438 | 449 | | |
439 | 450 | | |
440 | 451 | | |
441 | 452 | | |
442 | | - | |
443 | | - | |
| 453 | + | |
444 | 454 | | |
| 455 | + | |
445 | 456 | | |
446 | 457 | | |
447 | 458 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| 35 | + | |
35 | 36 | | |
36 | 37 | | |
| 38 | + | |
37 | 39 | | |
38 | 40 | | |
39 | 41 | | |
| |||
609 | 611 | | |
610 | 612 | | |
611 | 613 | | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
| 642 | + | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
| 648 | + | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
| 653 | + | |
| 654 | + | |
| 655 | + | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
612 | 664 | | |
613 | 665 | | |
614 | 666 | | |
| |||
1350 | 1402 | | |
1351 | 1403 | | |
1352 | 1404 | | |
| 1405 | + | |
| 1406 | + | |
| 1407 | + | |
| 1408 | + | |
| 1409 | + | |
| 1410 | + | |
| 1411 | + | |
| 1412 | + | |
| 1413 | + | |
| 1414 | + | |
| 1415 | + | |
| 1416 | + | |
| 1417 | + | |
| 1418 | + | |
| 1419 | + | |
| 1420 | + | |
| 1421 | + | |
| 1422 | + | |
| 1423 | + | |
| 1424 | + | |
| 1425 | + | |
| 1426 | + | |
| 1427 | + | |
| 1428 | + | |
| 1429 | + | |
| 1430 | + | |
| 1431 | + | |
| 1432 | + | |
| 1433 | + | |
| 1434 | + | |
| 1435 | + | |
| 1436 | + | |
1353 | 1437 | | |
1354 | 1438 | | |
1355 | 1439 | | |
| |||
1601 | 1685 | | |
1602 | 1686 | | |
1603 | 1687 | | |
| 1688 | + | |
| 1689 | + | |
| 1690 | + | |
| 1691 | + | |
| 1692 | + | |
| 1693 | + | |
| 1694 | + | |
| 1695 | + | |
| 1696 | + | |
| 1697 | + | |
| 1698 | + | |
| 1699 | + | |
| 1700 | + | |
| 1701 | + | |
| 1702 | + | |
| 1703 | + | |
| 1704 | + | |
| 1705 | + | |
| 1706 | + | |
| 1707 | + | |
| 1708 | + | |
| 1709 | + | |
| 1710 | + | |
| 1711 | + | |
1604 | 1712 | | |
1605 | 1713 | | |
1606 | 1714 | | |
| |||
0 commit comments