|
31 | 31 | #include "storage/delete/delete_handler.h" |
32 | 32 | #include "storage/rowset/rowset_meta.h" |
33 | 33 | #include "storage/schema.h" |
| 34 | +#include "storage/storage_engine.h" |
| 35 | +#include "storage/tablet/tablet.h" |
| 36 | +#include "storage/tablet/tablet_meta.h" |
34 | 37 | #include "storage/tablet/tablet_schema.h" |
35 | 38 |
|
36 | 39 | namespace doris { |
@@ -70,6 +73,25 @@ class TabletReaderTest : public testing::Test { |
70 | 73 | ASSERT_TRUE(handler.init({rs_meta}, /*version=*/100, *read_schema, &dropped_columns).ok()); |
71 | 74 | (*read_schema)->append_dropped_columns(std::move(dropped_columns)); |
72 | 75 | } |
| 76 | + |
| 77 | + // Give `reader` a tablet with the given keys type. Its only key column is k1. |
| 78 | + static void init_tablet(StorageEngine& engine, TabletReader& reader, KeysType keys_type, |
| 79 | + bool enable_mow) { |
| 80 | + auto tablet_meta = std::make_shared<TabletMeta>(); |
| 81 | + tablet_meta->set_enable_unique_key_merge_on_write(enable_mow); |
| 82 | + reader._tablet = std::make_shared<Tablet>(engine, std::move(tablet_meta), nullptr); |
| 83 | + reader._tablet_schema = create_schema({{"k1", 10}, {"v1", 12}}, keys_type); |
| 84 | + reader._read_schema = std::make_shared<ReadSchema>(reader._tablet_schema->columns()); |
| 85 | + } |
| 86 | + |
| 87 | + // Set up the order-by key columns for a storage TopN that sorts by the first |
| 88 | + // `num_prefix_columns` key columns. |
| 89 | + static Status init_storage_topn(TabletReader& reader, size_t num_prefix_columns) { |
| 90 | + TabletReader::ReaderParams params; |
| 91 | + params.read_orderby_key_num_prefix_columns = num_prefix_columns; |
| 92 | + params.read_orderby_key_limit = 10; |
| 93 | + return reader._init_orderby_keys_param(params); |
| 94 | + } |
73 | 95 | }; |
74 | 96 |
|
75 | 97 | // The delete columns (resolved by the delete handler to read-schema ordinals) are mapped to their |
@@ -211,4 +233,43 @@ TEST_F(TabletReaderTest, delete_predicate_keeps_dropped_same_name_column_identit |
211 | 233 | EXPECT_EQ(1, delete_zone_maps.count(2)); |
212 | 234 | } |
213 | 235 | } |
| 236 | + |
| 237 | +// DUP and merge-on-write tablets give storage TopN the leading key columns to sort by. |
| 238 | +TEST_F(TabletReaderTest, storage_topn_sorts_by_leading_key_columns) { |
| 239 | + StorageEngine engine({}); |
| 240 | + TabletReader dup_reader; |
| 241 | + init_tablet(engine, dup_reader, KeysType::DUP_KEYS, /*enable_mow=*/false); |
| 242 | + auto st = init_storage_topn(dup_reader, 1); |
| 243 | + ASSERT_TRUE(st.ok()) << st; |
| 244 | + EXPECT_EQ(std::vector<uint32_t>({0}), dup_reader._orderby_key_columns); |
| 245 | + |
| 246 | + TabletReader mow_reader; |
| 247 | + init_tablet(engine, mow_reader, KeysType::UNIQUE_KEYS, /*enable_mow=*/true); |
| 248 | + st = init_storage_topn(mow_reader, 1); |
| 249 | + ASSERT_TRUE(st.ok()) << st; |
| 250 | + EXPECT_EQ(std::vector<uint32_t>({0}), mow_reader._orderby_key_columns); |
| 251 | +} |
| 252 | + |
| 253 | +// Storage TopN without order-by key columns fails at init, instead of aborting the BE |
| 254 | +// later in VCollectIterator. |
| 255 | +TEST_F(TabletReaderTest, storage_topn_without_orderby_key_columns_fails) { |
| 256 | + StorageEngine engine({}); |
| 257 | + // A merge-on-read tablet, such as one read as DUP, sets up no order-by key columns. |
| 258 | + TabletReader mor_reader; |
| 259 | + init_tablet(engine, mor_reader, KeysType::UNIQUE_KEYS, /*enable_mow=*/false); |
| 260 | + auto st = init_storage_topn(mor_reader, 1); |
| 261 | + EXPECT_TRUE(st.is<ErrorCode::INTERNAL_ERROR>()) << st; |
| 262 | + |
| 263 | + // An empty key prefix leaves nothing to sort by. |
| 264 | + TabletReader dup_reader; |
| 265 | + init_tablet(engine, dup_reader, KeysType::DUP_KEYS, /*enable_mow=*/false); |
| 266 | + st = init_storage_topn(dup_reader, 0); |
| 267 | + EXPECT_TRUE(st.is<ErrorCode::INTERNAL_ERROR>()) << st; |
| 268 | + |
| 269 | + // Without TopN, a merge-on-read tablet needs no order-by key columns. |
| 270 | + TabletReader plain_reader; |
| 271 | + init_tablet(engine, plain_reader, KeysType::UNIQUE_KEYS, /*enable_mow=*/false); |
| 272 | + st = plain_reader._init_orderby_keys_param(TabletReader::ReaderParams {}); |
| 273 | + EXPECT_TRUE(st.ok()) << st; |
| 274 | +} |
214 | 275 | } // namespace doris |
0 commit comments